July 2016 - Koha-bugs - lists.koha-community.org

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '16

17 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52299|0 |1 is obsolete| | --- Comment #320 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 53460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53460&action=ed… Bug 7143: [QA Follow-up] Adjusting developer information For consistency we should not only add firstnames to the list of developers in about.tt and history.txt. Adding some surnames with the help of git log and Bugzilla. Also corrected a closing li tag. Note that I did not find one surname: Natasha of Catalyst Academy. Probably Chris could add that missing piece. NOTE: Natasha piece still needs clean up. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '16

17 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com --- Comment #319 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to M. Tompsett from comment #318) > Claire Gravely is here, but not in the about.tt DOH! Already in. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '16

17 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #318 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 52636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52636 Bug 7143 : Adding new developers Review of attachment 52636: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=714…) ----------------------------------------------------------------- ::: docs/history.txt @@ +853,4 @@ > January 19 2016 Gus Ellerm becomes the 295th developer to have a patch pushed developer > February 25 2016 Francois Charbonnier becomes the 296th developer to have a patch pushed developer > April 28 2016 Arslan Farooq becomes the 297th developer to have a patch pushed developer > +June 3 2016 Claire Gravely becomes the 298th developer to have a patch pushed developer Claire Gravely is here, but not in the about.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '16

17 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #33 from M. Tompsett <mtompset(a)hotmail.com> --- SHORT VERSION: Not enough test coverage. LONGER VERSION: In these code changes, there are multiple blocks changed in C4::Items. @@ -2890,7 +2890,7 (one if) @@ -2901,7 +2901,7 (one if) @@ -2909,7 +2909,7 (one if) @@ -3003,15 +3003,18 (three pieces of code) I placed a print STDERR "TRIGGERED!\n"; inside the ifs or below the last line of the block of code. We are still lacking test coverage on C4::Items. Only the first two of three changes were triggered in the last block of changes. So, while I do believe the added test catches the failure before, I am uncertain it catches all the fixes after. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '16

16 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49911|0 |1 is obsolete| | --- Comment #32 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 53459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53459&action=ed… Bug 15030: Add tests This test will prevent regression on the lost of data when items.itemcallnumber is linked with a plugin. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '16

16 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49910|0 |1 is obsolete| | --- Comment #31 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 53458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53458&action=ed… Bug 15030 - continue. The enumchron value was overwritten by 'header' even when value supplied Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '16

16 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49909|0 |1 is obsolete| | --- Comment #30 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 53457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53457&action=ed… Bug 15030 - Fixes the serials fields associated with a plugin, to not overwrite the previously saved value This fixes the remaining fields from serials-edit.pl that were seeing their previously entered values be oblitarated with each new edit. The fields associated to a plugin (dateaccessioned and barcode) were always displaying <empty> with each new edit, losing the previous effort. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '16

16 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49908|0 |1 is obsolete| | --- Comment #29 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 53456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53456&action=ed… Bug 15030 - Certain values in serials' items are lost on next edit When editing serials subscription, we can edit them but some values are not pulled from the DB correctly to be put in the edit box. If not noticed, the value will be overwritten on the next save. Test: - Create a subscription - Edit itemcallnumber (952o?) and make sure to have a different value than the default one. - Save. - Edit it again - The saved value is not there. This is true for itemcallnumber and a few other fields. This was caused by calls to ->field($subfield). This would always fail, of course. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '16

16 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53450|0 |1 is obsolete| | --- Comment #28 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 53450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53450 Bug 15030: Fix the uninitialized warnings in ClassSortRoutine::_get_class_sort_key Had issues with applying when I fixed merge conflicts on a fresh apply. This patch wasn't applied, and error messages have disappeared. No need for this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #27 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 53450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53450 Bug 15030: Fix the uninitialized warnings in ClassSortRoutine::_get_class_sort_key Review of attachment 53450: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=150…) ----------------------------------------------------------------- ::: C4/ClassSortRoutine.pm @@ +112,5 @@ > =cut > > sub _get_class_sort_key { > + my $cn_class = shift || ''; > + my $cn_item = shift || ''; @_ is the better way to assign. Shift on a missing parameter will trigger a warning. $cn_class //= q{}; $cn_item //= q{}; Then you could do two assigns like the above to handle if they aren't assigned values. -- You are receiving this mail because: You are watching all bug changes.

1 0