July 2016 - Koha-bugs - lists.koha-community.org

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '16

16 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53450|0 |1 is obsolete| | --- Comment #28 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 53450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53450 Bug 15030: Fix the uninitialized warnings in ClassSortRoutine::_get_class_sort_key Had issues with applying when I fixed merge conflicts on a fresh apply. This patch wasn't applied, and error messages have disappeared. No need for this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #27 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 53450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53450 Bug 15030: Fix the uninitialized warnings in ClassSortRoutine::_get_class_sort_key Review of attachment 53450: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=150…) ----------------------------------------------------------------- ::: C4/ClassSortRoutine.pm @@ +112,5 @@ > =cut > > sub _get_class_sort_key { > + my $cn_class = shift || ''; > + my $cn_item = shift || ''; @_ is the better way to assign. Shift on a missing parameter will trigger a warning. $cn_class //= q{}; $cn_item //= q{}; Then you could do two assigns like the above to handle if they aren't assigned values. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13945] Multiple dialogs for item that needs transferred and hold captured at checkin
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945 jdemuth(a)roseville.ca.us <jdemuth(a)roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth(a)roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53449|0 |1 is obsolete| | --- Comment #26 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 53450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53450&action=ed… Bug 15030: Fix the uninitialized warnings in ClassSortRoutine::_get_class_sort_key -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #25 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 53449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53449&action=ed… Fix the uninitialized warnings in ClassSortRoutine::_get_class_sort_key -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14668] Show serial enumeration in the patron's opac checkout summary
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49711|0 |1 is obsolete| | --- Comment #10 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 53448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53448&action=ed… Bug 14668 - Show serial enumeration in INTRANET circulation.tt and OPAC patron's relatives' checkouts TEST PLAN 1. THE CHECKOUT TAB, INTRANET 1.1. Add a value to the 'h' subfield of an item. ie: 'volume #42' 1.2. Check out the item to a patron 1.3. Display this patron's issues in his checkout page 1.3.1. The enumchron should be concatenated with the title 2. A PATRON'S RELATIVE, INTRANET + OPAC 1.1. Add somebody to a patron's guarantee list 1.2. Checkout a serial to this guarantee 1.3. Visit the guarantor's OPAC and INTRANET checkout page 1.3.1. You should see the enumchron in his guarantee's issues -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14668] Show serial enumeration in the patron's opac checkout summary
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer(a)inlibro.com --- Comment #24 from Charles Farmer <charles.farmer(a)inlibro.com> --- I'm sorry Mark, I honestly don't know what to make of this. On my system, this is what I get from a fresh install of 16.05 with an empty database: charles@beauce(inlibro-dev)/inlibro/git/koha-inlibro-dev-inlibro$ prove t/db_dependent/Serials.t t/db_dependent/Serials.t .. 1/49 attempting to use non-existent class sorting routine Use of uninitialized value $cn_class in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. Use of uninitialized value $cn_item in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. Use of uninitialized value $cn_class in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. Use of uninitialized value $cn_item in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. Use of uninitialized value $cn_class in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. Use of uninitialized value $cn_item in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. Use of uninitialized value $cn_class in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. Use of uninitialized value $cn_item in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. t/db_dependent/Serials.t .. 14/49 Use of uninitialized value $cn_class in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. Use of uninitialized value $cn_item in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. Use of uninitialized value $cn_class in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. Use of uninitialized value $cn_item in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. Use of uninitialized value $cn_class in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. Use of uninitialized value $cn_item in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. Use of uninitialized value $cn_class in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. Use of uninitialized value $cn_item in concatenation (.) or string at /inlibro/git/koha-inlibro-dev-inlibro/C4/ClassSortRoutine.pm line 116. t/db_dependent/Serials.t .. ok All tests successful. Files=1, Tests=49, 2 wallclock secs ( 0.03 usr 0.00 sys + 2.03 cusr 0.11 csys = 2.17 CPU) Result: PASS I see you ran 46 test, and we're now up to 48. I don't know if somebody else can try again to shed some new light on this, but I'll try to see what I can do about those empty concat. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16913] New: Remove the unused C4::Members:: GetBorrowersNamesAndLatest subroutine
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16913 Bug ID: 16913 Summary: Remove the unused C4::Members::GetBorrowersNamesAndLatest subroutine Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org This subroutine has been added by commit 5904681faca77c87ff8071414d66e123a2d3baa9 Date: Wed Mar 19 10:11:12 2008 -0500 CleanBorrowers fixing. but has never been used. It can be removed safely. -- You are receiving this mail because: You are watching all bug changes.

1 10