July 2016 - Koha-bugs - lists.koha-community.org

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #47 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53014&action=ed… Bug 15006: Centralize timeout logic and allow zero client timeout Moving timeout logic to one routine in Sip.pm (with unit test). This further implements two suggestions from Kyle and Larry: [1] You could use a client_timeout of 0 to specify no timeout at all. [2] Have the client_timeout default to the timeout if not defined. Test plan: [1] Run t/SIP_Sip.t [2] Test login timeout for raw and telnet. [3] Check ACS status message for timeout value. Should match policy timeout from institution. [4] Test client timeout (zero and non-zero). [5] Remove client timeout. Test fallback to service. [6] Remove service timeout too. Test fallback to 30 at login. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Amended after feedback of Colin. Added a test. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #46 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53013&action=ed… Bug 15006: Add timeout and strikes to raw_transport The code in raw_transport includes setting a $SIG{ALRM}, but did not use it. For consistency, we add an alarm statement here. Similarly, we add the "three strikes" to raw_transport just as telnet_transport does. Note that raw_transport still responds to other requests, but will exit if there is no valid login within three attempts. (If we want more restrictions, add them later?) Test plan: [1] Start sip session with telnet on raw port 6001. Wait until it times out (probably the default 60 seconds). [2] Change SIPconfig.xml: set timeout=5 for service port 6001. Restart SIP and start another telnet 6001 session. Did it timeout within 5 seconds? [3] Start another 6001 session. Give three wrong requests or false login attempts. Does the connection close? Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16729] New: The street number missing when printing user summary
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 Bug ID: 16729 Summary: The street number missing when printing user summary Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: mehdi.hamidi(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When printing a user summary, the street number is not showing up. The template used for the printing(moremember-print.tt) only shows the address, instead of street number + address. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 16693] New: reserve/renewscript.pl is not used and should be removed
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16693 Bug ID: 16693 Summary: reserve/renewscript.pl is not used and should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org It seems that reserve/renewscript.pl is not used since bug 11703. This script should be removed. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 16543] New: Make edit and delete links styled buttons in patron attribute types administration
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16543 Bug ID: 16543 Summary: Make edit and delete links styled buttons in patron attribute types administration Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/cities.pl OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org In Administration -> Patron attribute types, the edit and delete buttons should be made into Bootstrap-styled buttons with Font Awesome icons. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 16541] New: Make edit and delete links styled buttons in cities administration
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541 Bug ID: 16541 Summary: Make edit and delete links styled buttons in cities administration Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/cities.pl OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org In Administration -> Cities, the edit and delete buttons should be made into Bootstrap-styled buttons with Font Awesome icons. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 16127] New: Add discharge menu item to patron toolbar
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 Bug ID: 16127 Summary: Add discharge menu item to patron toolbar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The patron discharge feature added a "Discharge" tab in the left-hand sidebar menu. I think if we follow views vs. actions guideline (https://wiki.koha-community.org/wiki/Interface_patterns#Views_and_Actions) the link in the sidebar should say "Discharges" (as in view the patron's list of discharges) and there should be menu item in the toolbar (members-toolbar.inc) for the action of discharging the patron. I think this should be added to the "More" drop-down menu. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 8007] Discharge management
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16127 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 [Bug 16127] Add discharge menu item to patron toolbar -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16594] New: Orders by fund has wrong link to css and other issues
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 Bug ID: 16594 Summary: Orders by fund has wrong link to css and other issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: hector.hecaxmmx(a)gmail.com Reporter: hector.hecaxmmx(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Orders by fund has wrong link to css and other issues -> The example in the wiki is wrong: <https://wiki.koha-community.org/wiki/DataTables_HowTo> <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> [% INCLUDE 'datatables.inc' %] -> Must be: <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" /> NOTE: Wiki needs to be updated -> Missing <th></th> in <tfoot> tag -> Wrong word used "Date deceived" should be "Date received" -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 16717] New: Remove hardcoded category from Holds.t
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16717 Bug ID: 16717 Summary: Remove hardcoded category from Holds.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: gmcharlt(a)gmail.com This patch comes from report 16607. With a limited scope it needed its own report. -- You are receiving this mail because: You are watching all bug changes.

1 11