July 2016 - Koha-bugs - lists.koha-community.org

[Bug 11023] Automatic item modification by age (Was "Toggle new status for items")
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 [Bug 16607] Remove CPL/MPL from two unit tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16607] New: Add verbose flag to builder sub in TestBuilder
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 Bug ID: 16607 Summary: Add verbose flag to builder sub in TestBuilder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: gmcharlt(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 16500] New: Replace two warns in TestBuilder.t with warning_like
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500 Bug ID: 16500 Summary: Replace two warns in TestBuilder.t with warning_like Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: gmcharlt(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #45 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #35) > Marcel, would you be able to rebase these patches on top of bug 13807? I did now. But in view of Colin's comments I will still have a look on the last patch. Working on it.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13807] SIPServer Input loop not checking for closed connections reliably
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #5) > Passing QA provisionally, we should deal with the interaction with bug 13807 > before anything is pushed. 13807->15006 I rebased 15006 on top of this one. So it can go first.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #44 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53012&action=ed… Bug 15006: [COUNTERPATCH] Timeout logic in sip_protocol_loop Instead of adding yet another client timeout, I propose to use the policy timeout that we also communicate in send_acs_status. Although I agree that we perhaps better move it from institution to account/login level, this c/should be done on another report. We may have issues with existing configurations. In order to find a compromise between bug 13432 and the originally proposed 15006 patch, this patch allows you to put a zero in the policy timeout entry in the SIPconfig. The timeout logic is moved to a Sip.pm subroutine. Will add a test :) Test plan: [1] Check timeout after login with policy/timeout > 0. [2] Check timeout after login with policy/timeout = 0. (No timeout!) [3] Check timeout after login with no policy timeout. Fallback to service. [4] Check timeout after login with no policy and service timeout. Should fallback to 30 seconds for both login process and after login. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53011&action=ed… Bug 15006: [COUNTERPATCH] Add timeout and strikes to raw_transport The code in raw_transport includes setting a $SIG{ALRM}, but did not use it. For consistency, we add an alarm statement here. Similarly, we add the "three strikes" to raw_transport just as telnet_transport does. Note that raw_transport still responds to other requests, but will exit if there is no valid login within three attempts. (If we want more restrictions, add them later?) Test plan: [1] Start sip session with telnet on raw port 6001. Wait until it times out (probably the default 60 seconds). [2] Change SIPconfig.xml: set timeout=5 for service port 6001. Restart SIP and start another telnet 6001 session. Did it timeout within 5 seconds? [3] Start another 6001 session. Give three wrong requests or false login attempts. Does the connection close? Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #42 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53010&action=ed… Bug 15006 Sip separate global from login timeouts Timeout logic has been added to the main sip loop However the timeout parameter was initially for the login process which requires a short duration applying such a brief timeout to the main sip loop causes instability in many selfcheck units Most selfchecks have persistent connections and send a periodic status request at intervals (approx every 5mins appears the norm) The timeout was dropping connections by default every 30secs which for the client appears as a very flakey network This patch adds a separate parameter client_timeout that can be used if you do want to force a disconnect if the client sends no requests for a period. By not defining it you can switch off the timeout in the main loop, I recommend this unless you have a good reason not too. If you do want this behaviour you can at least now set it to a more realistic value (see sample config file) Removed the commented out html entry in the config file, this was dead code born of a misconception and was just a source of confusion for users Signed-off-by: Frederic Demians <f.demians(a)tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52850|0 |1 is obsolete| | Attachment #52851|0 |1 is obsolete| | Attachment #52852|0 |1 is obsolete| | Attachment #52853|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53009&action=ed… Bug 15006: [QA Follow-up] Indentation for two subroutines Remove tabs from telnet_transport and sip_protocol_loop. Correct indentation. Test plan: Compare files before and after without whitespace (diff -b). Notice only two split lines. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16670] New: +cgi-
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16670 Bug ID: 16670 Summary: +cgi- Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 18