July 2016 - Koha-bugs - lists.koha-community.org

[Bug 16960] New: Patron::Modifications should be fixed
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 Bug ID: 16960 Summary: Patron::Modifications should be fixed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The changes from opac-memberentry do not reach the table, since the Patron::Modifications object does not work well. Look at this from opac-memberentry: Koha::Patron::Modifications->new( borrowernumber => $borrowernumber ); Passing borrowernumber here is useless, since it is an instance of Koha::Objects. On the contrary, the following call $m->DelModifications; should have the borrowernumber passed ! So what could we add a sub new to Patron::Modifications like: +sub new { + my ( $class, $params ) = @_; + my $self = $class->SUPER::new(); + $self->{borrowernumber} = $params->{borrowernumber}; + return $self; +} And in opac-memberentry: + my $patronmod = Koha::Patron::Modifications->new({ borrowernumber => $borrowernumber }); + $patronmod->DelModifications({ borrowernumber => $borrowernumber }); + $patronmod->AddModifications(\%borrower_changes); But this is a horrible hack. We should not use a Koha::Objects like that.. And what about its unit test: t/db_dependent/Koha_borrower_modifications.t Currently fails ! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 42

[Bug 16491] New: Link barcodes in messages link to specific item during check in
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '16

19 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16491 Bug ID: 16491 Summary: Link barcodes in messages link to specific item during check in Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 15736 introduced a fix that turns off local use from populating the check in table. However, this takes away some functionality. There are times, after checking in an item, that a staff member needs to adjust something on the item. When the item appears in the check in table, the barcode gives a direct link to the item. With it off, all you have is what is shown in the message. The barcode shows, but the barcode and title are a single link to the record. Because of this, with the ShowAllCheckins preference set to Do not show, it takes an extra click to get to the item. It would be helpful if the barcode was a separate link to the item. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 16884] New: Branch transfer dialog does not appear for check-ins on check-out screen
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '16

19 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16884 Bug ID: 16884 Summary: Branch transfer dialog does not appear for check-ins on check-out screen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To reproduce: Given item with barcode 1234, having homebranch AAA and patron cardnumber 7890: 1/ Set library to branch AAA 2/ Check out item 1234 to Borrower 7890 3/ Change branches in the staff client (We'll call the second branch BBB). 4/ Type 7890 in the 'Check out' bar (I.e. we're going to the check out screen) for borrower 7890 5/ Click 'Show Checkouts' 6/ Check the 'Check in' box for item 1234 7/ Click 'Renew or check in selected Items' Because the item is checked in at a branch other than its home branch, this *should* trigger a branch transfer, but the item is checked in, and no branch transfer dialog appears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 16829] New: action_logs should have an 'interface' column
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Bug ID: 16829 Summary: action_logs should have an 'interface' column Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org This will be handy for further developments. -- You are receiving this mail because: You are watching all bug changes.

1 30

[Bug 16372] New: Replace the use of "onclick" for deletion confirmation in some templates
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 Bug ID: 16372 Summary: Replace the use of "onclick" for deletion confirmation in some templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Several templates include the use of an "onclick" attribute to handle deletion confirmations: intranet-main.tt patron_lists/lists.tt patroncards/image-manage.tt tools/koha-news.tt These should be modified so that events are handled in JavaScript. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 16622] New: some tests triggered by prove t fail for unset KOHA_CONF
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622 Bug ID: 16622 Summary: some tests triggered by prove t fail for unset KOHA_CONF Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com unset'ing KOHA_CONF from your environment, and then triggering 'prove t' results in several tests warning and complaining about C4::Context. Make sure failing tests are in the correct location (t vs t/db_dependent), properly mocked, or catch the warnings. The second option being the preferred one. -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 16727] New: Upload tool needs better warning
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727 Bug ID: 16727 Summary: Upload tool needs better warning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org If you don't have an UPLOAD authorized value category set the upload tool says "Note: No upload categories have been defined. All uploads will be marked as temporary." But doesn't say that you have to create an authorized value. The error should be clearer. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 16864] New: Silence warnings in t/db_dependent/ILSDI_Services.t
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Bug ID: 16864 Summary: Silence warnings in t/db_dependent/ILSDI_Services.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: mtompset(a)hotmail.com Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com $cgi->param() is used in an ambiguous context, so it doesn't realize it should be scalar. Clarify the context while maintaining readability by novices. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 16868] New: Silence error t/db_dependent/Linker_FirstMatch.t
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 Bug ID: 16868 Summary: Silence error t/db_dependent/Linker_FirstMatch.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: mtompset(a)hotmail.com Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com When the auth_header table has records which exclude 1xx and 2xx tags, the $bibfield doesn't match anything. This in turn sets it to undef, which triggers an error on the next line killing the test. Solution: improve the SQL query so it will find the expected records, or not and properly skip tests. -- You are receiving this mail because: You are watching all bug changes.

1 27

[Bug 16971] New: Missing dependency for HTML::Entities
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971 Bug ID: 16971 Summary: Missing dependency for HTML::Entities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 18