July 2016 - Koha-bugs - lists.koha-community.org

[Bug 16806] New: "Too soon" renewal error generates no alert for user
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Bug ID: 16806 Summary: "Too soon" renewal error generates no alert for user Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: ephetteplace(a)cca.edu QA Contact: testopia(a)bugs.koha-community.org Created attachment 52773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52773&action=ed… example of error Steps to recreate: - for a particular item type & patron category, configure a non-zero "no renewal before" date i.e. make it so items cannot be immediately renewed - sign in as a patron in aforementioned patron category - check out an item of aforementioned item type - go to your renewals page in OPAC /cgi-bin/koha/opac-user.pl Actual results: - note that under the "Renew" column a message prints indicating you cannot renew, due to lines 244-249 of /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt - https://github.com/Koha-Community/Koha/blob/87dbed0abd67e88ae85f633d9f4c63c… - however, the logic above on lines 77-85 doesn't match, the "too_soon" error isn't being tested for - https://github.com/Koha-Community/Koha/blob/87dbed0abd67e88ae85f633d9f4c63c… The end result is undesirable: because the error loop triggers, the patron sees a message, but *there's no reason given*! See attached screenshot. Expected results: - a message prints indicating the reason why you cannot renew the item I'll add a patch to opac-user.tt for this shortly. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 16776] New: If language is set by external link language switcher does not work
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 Bug ID: 16776 Summary: If language is set by external link language switcher does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Follwoing scenario: - Have a multilingual koha installation, let's say en, de-CH, fr-FR and it-IT - Create external links e.g. from the multilingual library website to each language variant of OPAC: ...cgi-bin/koha/opac-main.pl?language=en ...cgi-bin/koha/opac-main.pl?language=de-CH ...cgi-bin/koha/opac-main.pl?language=fr-FR ...cgi-bin/koha/opac-main.pl?language=it-IT Each link opens fine displaying the language as appropriate. Now try to switch language on the page you just opened via the external link. It won't work, it will always stay on the language defined by the external link. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 16848] New: Wrong warning "Invalid date ... passed to output_pre" can be carped
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Bug ID: 16848 Summary: Wrong warning "Invalid date ... passed to output_pre" can be carped Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org >From Koha::DateUtils::output_pref: $dt = eval { dt_from_string( $str ) } if $str; carp "Invalid date '$str' passed to output_pref\n" if $@; This second line is wrong: if $str does not exist, the first line is not evaluated and $@ could be filled with previous error. To reproduce: diff --git a/t/DateUtils.t b/t/DateUtils.t index eede4a0..2dd6a9d 100755 --- a/t/DateUtils.t +++ b/t/DateUtils.t @@ -229,3 +229,5 @@ is( $output_for_invalid_date, undef, 'output_pref should return undef if an inva warning_is { output_pref( { 'str' => $testdate_iso, dt => $dt, dateformat => 'iso', dateonly => 1 } ) } { carped => 'output_pref should not be called with both dt and str parameters' }, 'output_pref should carp if str and dt parameters are passed together'; + +output_pref(); Then: prove t/DateUtils.t will display: t/DateUtils.t .. 20/60 Use of uninitialized value $str in concatenation (.) or string at Koha/DateUtils.pm line 217. Invalid date '' passed to output_pref at t/DateUtils.t line 233. t/DateUtils.t .. ok All tests successful. Files=1, Tests=60, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.40 cusr 0.00 csys = 1.42 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 16741] New: Dead code (?) - sub itemissues in C4/Circulation.pm
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Bug ID: 16741 Summary: Dead code (?) - sub itemissues in C4/Circulation.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org It seems that sub itemissues, defined in C4/Circulation.pm, is never used. Behalve of C4/Circulation.pm it is only found (but not used) in: catalogue/moredetail.pl:use C4::Circulation; # to use itemissues To verify: - git grep itemissues - comment out line 33 in catalogue/moredetail.pl, verifiy that there are no errors or side effects -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 17001] New: filtering overdue report by due date can fail if TimeFormat is 12hr
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001 Bug ID: 17001 Summary: filtering overdue report by due date can fail if TimeFormat is 12hr Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: gmcharlt(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When using the overdue report circ/overdue.pl, if the TimeFormat system preference is set to 12-hour, setting a filter on the due date range can result in zero overdue loans being displayed, even if there are ones that fall in the range. This happens because the date/time that gets passed to the SQL is formatted incorrectly; rather than '2016-07-29 23:59', it gets passed as '2016-07-29 11:59 PM'; on many MySQL and MariaDB versions, that becomes NULL when cast to a datetime. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 16953] New: Acquisitions home: Remove trailing &rsaquo; from breadcrumbs
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 Bug ID: 16953 Summary: Acquisitions home: Remove trailing &rsaquo; from breadcrumbs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org The breadcrumb on the Acquisition's home page reads: Home > Acquisitions > Remove trailing > (&rsaquo;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 16964] New: Fix capitalization for "Report Plugins" in reports-home.tt
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964 Bug ID: 16964 Summary: Fix capitalization for "Report Plugins" in reports-home.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: hector.hecaxmmx(a)gmail.com Reporter: hector.hecaxmmx(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Fix capitalization for "Report Plugins" in reports-home.tt according with Coding Guidelines <https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML4:_Upper_and_low…> -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 16989] New: Advanced search form does not display translated itemtype
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16989 Bug ID: 16989 Summary: Advanced search form does not display translated itemtype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In Staff client, the advanced serach form does not display the translations item types. (Note: It is not necessary to have translations installed to verify this bug.) Prerequisites: - Go to Home > Administration > Item types administration - Edit e.g. item type "BK" (Book) - Near "Description", click link "Translate into other languages - If you have other languaes installed, add translatons for those - If you have an Englis only installation, add a "translation" for English, make sure that you can identify it while testing (I used "BOOOOOOOOOOOOKS") Verify: - Go to Home › Advanced search - Verify near "Limit to any of the following" that the description for itemtype BK reads "Book" instead of "BOOOOOOOOOOOOKS" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 16960] New: Patron::Modifications should be fixed
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 Bug ID: 16960 Summary: Patron::Modifications should be fixed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The changes from opac-memberentry do not reach the table, since the Patron::Modifications object does not work well. Look at this from opac-memberentry: Koha::Patron::Modifications->new( borrowernumber => $borrowernumber ); Passing borrowernumber here is useless, since it is an instance of Koha::Objects. On the contrary, the following call $m->DelModifications; should have the borrowernumber passed ! So what could we add a sub new to Patron::Modifications like: +sub new { + my ( $class, $params ) = @_; + my $self = $class->SUPER::new(); + $self->{borrowernumber} = $params->{borrowernumber}; + return $self; +} And in opac-memberentry: + my $patronmod = Koha::Patron::Modifications->new({ borrowernumber => $borrowernumber }); + $patronmod->DelModifications({ borrowernumber => $borrowernumber }); + $patronmod->AddModifications(\%borrower_changes); But this is a horrible hack. We should not use a Koha::Objects like that.. And what about its unit test: t/db_dependent/Koha_borrower_modifications.t Currently fails ! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 42

[Bug 16491] New: Link barcodes in messages link to specific item during check in
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '16

19 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16491 Bug ID: 16491 Summary: Link barcodes in messages link to specific item during check in Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 15736 introduced a fix that turns off local use from populating the check in table. However, this takes away some functionality. There are times, after checking in an item, that a staff member needs to adjust something on the item. When the item appears in the check in table, the barcode gives a direct link to the item. With it off, all you have is what is shown in the message. The barcode shows, but the barcode and title are a single link to the record. Because of this, with the ShowAllCheckins preference set to Do not show, it takes an extra click to get to the item. It would be helpful if the barcode was a separate link to the item. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1