August 2016 - Koha-bugs - lists.koha-community.org

[Bug 17020] New: findborrower is not used in circulation.tt
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020 Bug ID: 17020 Summary: findborrower is not used in circulation.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org It's passed to the template but never used. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #52 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Marcel de Rooy from comment #49) > (In reply to Kyle M Hall from comment #48) > > (In reply to Katrin Fischer from comment #45) > > > > How to solve this? Can we remove the issue id in accountlines after > > > > switching to F? Or should UpdateFine no longer update a F record although it > > > > has the right issue id, but add a new record? > > > > > > I think it should add a new line as it's a 'new fine'. If we differentiate > > > between F and FU cleanly, we can keep the issue_id too, I think? > > > > Katrin has is exactly. If the same checkout goes overdue twice, the patron > > should have two separate fines ( and each one will show a different due date > > for the same checkout ). > > > > This new followup will stop UpdateFine from updating closed out fines. > > We are coming closer to a solution! > But please note that we need type F (imo) in the totalamount calculation and > the max fine reduction. We should focus on what happens next in UpdateFine. IMO adding the filter (for FU, or FU|O|M ?) in if ( $rec->{issue_id} == $issue_id ) { should do the trick. > The test $data->{'amount'} != $amount is not sufficient. Here we should > exclude type F somehow. This test is kind of broken by itself (not always reliable, Bug 17138) but excluding F fines in there will not be sufficient IMO - it would prevent updating of the wrong fine record (in case when the one in $data is an incorrect match), but the right fine record update may get skipped too in such case. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10148] 007 not filling in with existing values
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic(a)tamil.fr --- Comment #10 from Frédéric Demians <frederic(a)tamil.fr> --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7441] Search results showing wrong branch
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #93 from Frédéric Demians <frederic(a)tamil.fr> --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #51 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Katrin Fischer from comment #50) > I think Jacek is right - we need the F fines for the total amount > calculation in order to not break the MaxFine behaviour: s/Jacek/Marcel/, but yep, the last patch changes existing MaxFine behaviour quite dramatically. While this feature current behaviour looks a bit broken to me (hard to say, syspref description is far from clear), implementation is lacking (there is no need to fetch all that old fines from accountlines in UpdateFine() even when this syspref is not enabled), and - call me a Marxist - IMO it's socially unjust feature ;), sorting it out (if really necessary) is outside of the scope of this report. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6890] Add reserves to modification logging
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 --- Comment #9 from Marc Véron <veron(a)veron.ch> --- - Still an issue on current master, see comment #8 - Patch does not apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6772] Implementation of a recommendations engine
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6772 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6271] GetItemIssue(s) : renewals in both items and issues tables
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6271 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6138] Show local help and isbd punctuation automatically when we are cataloguing
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6138 --- Comment #10 from Marc Véron <veron(a)veron.ch> --- - Is this bug still valid? - Patch does not apply -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0