August 2016 - Koha-bugs - lists.koha-community.org

[Bug 8976] Default sequence of subfields in cataloguing editor
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sequence of subfield in |Default sequence of |Editor |subfields in cataloguing | |editor -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #35 from Lari Taskula <larit(a)student.uef.fi> --- (In reply to Katrin Fischer from comment #34) > >Let user access their own checkouts and if OpacRenewalAllowed system preference > >is on, also let user to renew their checkouts. > > I am concerned about this kind of behaviour. Would it mean that any user > (without any permission) can do this using the REST API as long as they can > get access to a valid session cookie/log into the OPAC? Yes, only for their own checkouts. Of course appropriate system preferences need to be considered, as you mentioned: > This checks for OpacRenewalAllowed, but what about opacuserlogin? Great suggestion, I totally ignored opacuserlogin. I think it is very important to also check opacuserlogin here and in other operations where this type of behaviour would be useful. There are many operations where it would be useful to let resource owner to access their own data even if they have no special permissions for it (checkouts/history, holds, accountlines, patron info, password change etc.). For this behaviour, I have proposed a patch in Bug 14868 which will centralize that feature so we don't have to check permissions/ownership in each controller over and over again, and also for each operation will add permission documentation into Swagger. Perhaps opacuserlogin could be considered there and restrict access to this behaviour in every operation, if it is disabled. > Could we make this behaviour optional? I'm not fully sure I understand your concern enough to see why it should have extra optionality, if this behaviour is already enabled in OPAC. If your main concern was opacuserlogin, then I think it is enough to consider it. Are there some other preferences that should also be considered? Thanks for the comment Katrin, very much appreciated! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16741] New: Dead code (?) - sub itemissues in C4/Circulation.pm
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Bug ID: 16741 Summary: Dead code (?) - sub itemissues in C4/Circulation.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org It seems that sub itemissues, defined in C4/Circulation.pm, is never used. Behalve of C4/Circulation.pm it is only found (but not used) in: catalogue/moredetail.pl:use C4::Circulation; # to use itemissues To verify: - git grep itemissues - comment out line 33 in catalogue/moredetail.pl, verifiy that there are no errors or side effects -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 17001] New: filtering overdue report by due date can fail if TimeFormat is 12hr
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001 Bug ID: 17001 Summary: filtering overdue report by due date can fail if TimeFormat is 12hr Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: gmcharlt(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When using the overdue report circ/overdue.pl, if the TimeFormat system preference is set to 12-hour, setting a filter on the due date range can result in zero overdue loans being displayed, even if there are ones that fall in the range. This happens because the date/time that gets passed to the SQL is formatted incorrectly; rather than '2016-07-29 23:59', it gets passed as '2016-07-29 11:59 PM'; on many MySQL and MariaDB versions, that becomes NULL when cast to a datetime. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 17124] New: DecreaseLoanHighHolds.t does not pass
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17124 Bug ID: 17124 Summary: DecreaseLoanHighHolds.t does not pass Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 11425] Search form for items
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13949 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949 [Bug 13949] Item search should have holding library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13949] Item search should have holding library
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11425 CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 [Bug 11425] Search form for items -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13949] Item search should have holding library
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54724|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54762&action=ed… Bug 13949 - Item search should have holding library This patch adds holding library ("current location") to the list of fields available in the item search form. To test, apply the patch and go to Search -> Item search. - Perform a search using the "current location" option and verify that it returns the correct results. - Try other searches to confirm that they work as before. Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13949] Item search should have holding library
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14844] Corrupted storable string. When adding/editing an Item, cookie LastCreatedItem might be corrupted.
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Frédéric Demians <frederic(a)tamil.fr> --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes.

1 0