August 2016 - Koha-bugs - lists.koha-community.org

[Bug 11019] Require some fields when adding authorized value category
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54723|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54761&action=ed… Bug 11019 - Require some fields when adding authorized value category This patch modifies the form for adding an authorized value so that category, authorized value, and description are required fields. Previously a new authorized value category could be saved with no data. To test, apply the patch and go to Administration -> Authorized values. - Click the "New category" button. - Click the save button without filling in category, authorized value, or description. You should be prevented from submitting the form. - Verify that filling in the required fields allows the form to be submitted. - Perform the same test when editing an existing authorized value. Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11019] Require some fields when adding authorized value category
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15200] t/Creators.t fails when using build-git-snapshot
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic(a)tamil.fr --- Comment #17 from Frédéric Demians <frederic(a)tamil.fr> --- Is relevant for 16.05? It doesn't apply as it is on stable branch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16953] New: Acquisitions home: Remove trailing &rsaquo; from breadcrumbs
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 Bug ID: 16953 Summary: Acquisitions home: Remove trailing &rsaquo; from breadcrumbs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org The breadcrumb on the Acquisition's home page reads: Home > Acquisitions > Remove trailing > (&rsaquo;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 16964] New: Fix capitalization for "Report Plugins" in reports-home.tt
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964 Bug ID: 16964 Summary: Fix capitalization for "Report Plugins" in reports-home.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: hector.hecaxmmx(a)gmail.com Reporter: hector.hecaxmmx(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Fix capitalization for "Report Plugins" in reports-home.tt according with Coding Guidelines <https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML4:_Upper_and_low…> -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 16989] New: Advanced search form does not display translated itemtype
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16989 Bug ID: 16989 Summary: Advanced search form does not display translated itemtype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In Staff client, the advanced serach form does not display the translations item types. (Note: It is not necessary to have translations installed to verify this bug.) Prerequisites: - Go to Home > Administration > Item types administration - Edit e.g. item type "BK" (Book) - Near "Description", click link "Translate into other languages - If you have other languaes installed, add translatons for those - If you have an Englis only installation, add a "translation" for English, make sure that you can identify it while testing (I used "BOOOOOOOOOOOOKS") Verify: - Go to Home › Advanced search - Verify near "Limit to any of the following" that the description for itemtype BK reads "Book" instead of "BOOOOOOOOOOOOKS" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #53 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Marcel de Rooy from comment #49) > But take care with $type that you get from CalcFine. > It may not be what you expect it to be .. Looks like $type argument passed to UpdateFine() is always NULL / undef, setting it to the custom string is not possible in Administration -> Circulation and fines rules, or anywhere else in the system (not implemented?). But in case it's not NULL in the database, it affects just a fine description and the log entry. There doesn't seem to be anything wrong with it - ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17081] New: Incorrect comparison operator used in edifactmsgs.pl
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17081 Bug ID: 17081 Summary: Incorrect comparison operator used in edifactmsgs.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: colin.campbell(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org numeric comparison operator used where string comparison required, results in following warning in the log: Argument "delete" isn't numeric in numeric eq (==) at /usr/share/koha/intranet/cgi-bin/acqui/edifactmsgs.pl line 42 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 17020] New: findborrower is not used in circulation.tt
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020 Bug ID: 17020 Summary: findborrower is not used in circulation.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org It's passed to the template but never used. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #52 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Marcel de Rooy from comment #49) > (In reply to Kyle M Hall from comment #48) > > (In reply to Katrin Fischer from comment #45) > > > > How to solve this? Can we remove the issue id in accountlines after > > > > switching to F? Or should UpdateFine no longer update a F record although it > > > > has the right issue id, but add a new record? > > > > > > I think it should add a new line as it's a 'new fine'. If we differentiate > > > between F and FU cleanly, we can keep the issue_id too, I think? > > > > Katrin has is exactly. If the same checkout goes overdue twice, the patron > > should have two separate fines ( and each one will show a different due date > > for the same checkout ). > > > > This new followup will stop UpdateFine from updating closed out fines. > > We are coming closer to a solution! > But please note that we need type F (imo) in the totalamount calculation and > the max fine reduction. We should focus on what happens next in UpdateFine. IMO adding the filter (for FU, or FU|O|M ?) in if ( $rec->{issue_id} == $issue_id ) { should do the trick. > The test $data->{'amount'} != $amount is not sufficient. Here we should > exclude type F somehow. This test is kind of broken by itself (not always reliable, Bug 17138) but excluding F fines in there will not be sufficient IMO - it would prevent updating of the wrong fine record (in case when the one in $data is an incorrect match), but the right fine record update may get skipped too in such case. -- You are receiving this mail because: You are watching all bug changes.

1 0