August 2016 - Koha-bugs - lists.koha-community.org

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #55 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Marcel de Rooy from comment #54) > (In reply to Jacek Ablewicz from comment #53) > > (In reply to Marcel de Rooy from comment #49) > > > > > But take care with $type that you get from CalcFine. > > > It may not be what you expect it to be .. > > > > Looks like $type argument passed to UpdateFine() is always NULL / undef, > > setting it to the custom string is not possible in Administration -> > > Circulation and fines rules, or anywhere else in the system (not > > implemented?). But in case it's not NULL in the database, it affects just a > > fine description and the log entry. > > > > There doesn't seem to be anything wrong with it - ? > > Well anything? :) > These kind of things make maintaining code only harder. They implicitly > suggest something while it is not there. Couldn't agree more.. What I meant was: anything wrong with it in UpdateFine() in particular, which may make a proposed solutions insufficient or more problematic? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15139] Show nonpublic note in overdues report
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 --- Comment #1 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Another library is asking for this - almost missed I had already filed a report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #54 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jacek Ablewicz from comment #53) > (In reply to Marcel de Rooy from comment #49) > > > But take care with $type that you get from CalcFine. > > It may not be what you expect it to be .. > > Looks like $type argument passed to UpdateFine() is always NULL / undef, > setting it to the custom string is not possible in Administration -> > Circulation and fines rules, or anywhere else in the system (not > implemented?). But in case it's not NULL in the database, it affects just a > fine description and the log entry. > > There doesn't seem to be anything wrong with it - ? Well anything? :) These kind of things make maintaining code only harder. They implicitly suggest something while it is not there. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54770|0 |1 is obsolete| | --- Comment #36 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 54771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54771&action=ed… Bug 14868: Display required permissions in permission error response When user does not have required permissions to use API operation, it would be useful to let them know which permissions he is missing. Since they are now defined in Swagger, we can easily render them into the response. To test: 1. Use a patron without any permissions 2. Make GET request to http://yourlib/api/v1/patrons 3. Observe permission error and see that required_permissions are displayed. 4. Run t/db_dependent/api/v1/patrons.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 --- Comment #35 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 54770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54770&action=ed… Bug 14868: Display required permissions in permission error response When user does not have required permissions to use API operation, it would be useful to let him know which permissions he is missing. Since they are now defined in Swagger, we can easily render them into the response. To test: 1. Use a patron without any permissions 2. Make GET request to http://yourlib/api/v1/patrons 3. Observe permission error and see that required_permissions are displayed. 4. Run t/db_dependent/api/v1/patrons.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13665] Retrieve facets from zebra is slow
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 Eric Bégin <eric.begin(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin(a)inLibro.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17050 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050 [Bug 17050] Accessing the REST API through Plack kicks the session out -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54633|0 |1 is obsolete| | --- Comment #34 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 54767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54767&action=ed… Bug 14868: Use x-koha-authorization in current routes To test: 1. Run t/db_dependent/api/v1/holds.t 2. Run t/db_dependent/api/v1/patrons.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54632|0 |1 is obsolete| | --- Comment #33 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 54766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54766&action=ed… Bug 14868: Give users possibility to request their own object Allow access to user's own objects even if they do not have required permissions. This will be very useful in many cases where an user wants to request their own object, for example renewing their checkouts or placing a hold for themselves. First, this patch renames "x-koha-permission" to "x-koha-authorization" in order to describe the new functionality better. Second, we can now add two extra parameters under "x-koha-authorization": - "allow-owner"; Allows the owner of object to access it (without permission) - "allow-guarantor"; Allows guarantor of the owner of object to access it (without permission) Third, since permission checking is outside of actual controller, we need a way to find out ownership from different types of parameters, e.g. checkout_id from /checkouts/{checkout_id}, borrowernumber from /patrons/{borrowernumber} etc. A solution is to match the parameter with a subroutine that is designed to verify the ownership for that object. See the new subroutines in Koha::REST::V1. To use this functionality you will simply define it in Swagger: "/patrons/{borrowernumber}": { "get": { ..., "x-koha-authorization": { "allow-owner": true, "permissions": { "borrowers": "1" } } } } If a parameter that is not yet defined in Koha::REST::V1::check_object_ownership, you also need to define it and implement a subroutine that determines ownership. Tests are provided in a following patch that adds this functionality for current API operations. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54631|0 |1 is obsolete| | --- Comment #32 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 54765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54765&action=ed… Bug 14868: Swagger2-driven Permission checking Define 'x-koha-permission' for the Swagger2 Operation Object, to automatically authorize against the required permissions. This way we immediately tell the API consumer in the Swagger2-definition, which permissions are needed to access defined resources. Also we don't need to maintain permissions in multiple locations and we can build a smart testing framework to help a lot in creating tests for the new REST API. -- You are receiving this mail because: You are watching all bug changes.

1 0