August 2016 - Koha-bugs - lists.koha-community.org

[Bug 7533] T::T caching during installation
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '16

31 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 --- Comment #1 from Mason James <mtj(a)kohaaloha.com> --- (In reply to Paul Poulain from comment #0) > Add an option to the command-line installer that will let the user choose to > activate T::T during installation. Hi Paul, do you think it would be better to enable this feature by default? It seems to good to just have it as an 'optional' choice :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7511] Caching Templates
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7511 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj(a)kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7533] T::T caching during installation
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj(a)kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17227] New: SQL reserved words should be dis-allowed as branchcodes / authorized values / item types
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17227 Bug ID: 17227 Summary: SQL reserved words should be dis-allowed as branchcodes / authorized values / item types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Related to bug 13727 It is possible for the report selectors <<...|branch>> <<...|[authorised value]>> <<...|itemtypes>> ... etc. To insert SQL keywords into the SQL of a report, causing a software error when the report runs, because Koha will now allow SQL reserved words in the queries. To replicate: Create a branch with the branch code 'CREATE' Then create a report using the following query: SELECT * FROM items WHERE items.homebranch = <<Branch|branch>> Run the report, and select the branch with branchcode 'CREATE'. This will cause a software error. There is no way around this (because we *don't* want to allow SQL reserved words to be injected by user input). Therefore we *must* restrict the use of SQL reserved words on branch/authorized value/itemtype creation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14228] fill in patron info by scanning an ID
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14228 jdemuth(a)roseville.ca.us <jdemuth(a)roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth(a)roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #142 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to M. Tompsett from comment #140) > Comment on attachment 55045 [details] [review] > Bug 11592: (QA followup) Simplify code > > Review of attachment 55045 [details] [review]: > ----------------------------------------------------------------- > > Just an eyeball. > > ::: catalogue/ISBDdetail.pl > @@ -33,5 @@ > > > > =cut > > > > -use strict; > > -#use warnings; FIXME - Bug 2505 > > I wouldn't change to Modern::Perl, unless all the Bug 2505 references are > fixed like this. I prefer to do it, and take responsability if it introduces a warning. Haven't seen one so far. > ::: opac/opac-showmarc.pl > @@ -58,4 @@ > > > > if ($view eq 'card' || $view eq 'html') { > > - # FIXME: GetXmlBiblio needs filtering later. > > - my $xml = $importid ? $record->as_xml(): GetXmlBiblio($biblionumber); > > GetXmlBiblio includes fields which aren't necessarily in GetMarcBiblio, if I > recall correctly. I'm not sure about this. The main difference is that GetMarcBiblio does some sanitization. I think it is safe. This is probably some reminder from the days when everything was done against biblioitems.marc instead of biblioitems.marcxml. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 --- Comment #19 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Dependency is in Wheezy and Jessie, we're good to go from my side. I'll update the control file once this is pushed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #141 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 55046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55046 Bug 11592: (QA followup) Add missing framework code to ViewPolicy filter calls Review of attachment 55046: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=115…) ----------------------------------------------------------------- Just a quick eyeball. ::: opac/opac-MARCdetail.pl @@ +73,5 @@ > +if ( ! $record ) { > + print $query->redirect("/cgi-bin/koha/errors/404.pl"); > + exit; > +} > + Okay. More logical location. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #140 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 55045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55045 Bug 11592: (QA followup) Simplify code Review of attachment 55045: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=115…) ----------------------------------------------------------------- Just an eyeball. ::: catalogue/ISBDdetail.pl @@ -33,5 @@ > > =cut > > -use strict; > -#use warnings; FIXME - Bug 2505 I wouldn't change to Modern::Perl, unless all the Bug 2505 references are fixed like this. ::: opac/opac-export.pl @@ +35,5 @@ > $biblionumber = int($biblionumber); > my $error = q{}; > > +my $include_items = ($format =~ /bibtex/) ? 0 : 1; > +my $marc = GetMarcBiblio($biblionumber, $include_items) Oooo... nice simplification. ::: opac/opac-showmarc.pl @@ -58,4 @@ > > if ($view eq 'card' || $view eq 'html') { > - # FIXME: GetXmlBiblio needs filtering later. > - my $xml = $importid ? $record->as_xml(): GetXmlBiblio($biblionumber); GetXmlBiblio includes fields which aren't necessarily in GetMarcBiblio, if I recall correctly. I'm not sure about this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #139 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 55046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55046&action=ed… Bug 11592: (QA followup) Add missing framework code to ViewPolicy filter calls This patch adds the frameworkcode option param, using each record's frameworkcode as expected by the filter. Otherwise the ViewPolicy filter falls back to the default framework. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0