August 2016 - Koha-bugs - lists.koha-community.org

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54902|0 |1 is obsolete| | --- Comment #42 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 55012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55012&action=ed… [SIGNED-OFF] Bug 14060: Remove readonly attributes on date inputs In order to remove accessibility issues due to the readonly attributes on date inputs, this patch will remove them and introduce a javascript validation on them. This patch is not perfect for some reason: I didn't manage to force the user to select a valid date. One solution would be to reopen the datepicker plugin until a valid date is inserted. But it could be annoying for users (and for me: I did not manage to implement this solution). You will note that input is emptied if the date is not valid. This is a quick and efficient solution to prevent submitting invalid date and make Koha explodes. A proper solution would be to implement the check server side send a friendly message to the user. Test plan: For all inputs, try an invalid and a valid date. 1/ Debar a patron 2/ On the checkout tables (circulation and moremember), add a renewal due date (at the bottom of the tables) 3/ On the checkout page, specify a due date 4/ On the return page, specify a return date 5/ On the invoice page (acquisition module), enter a shipment and billing date 6/ On the invoice search page (invoices.pl) use filters shipment and billing dates 7/ On the offline circ page, specify a due date 8/ On the edit patron page (memberentry), add a debarment 9/ On the reserve page (reserve/request.pl), use the date inputs to suspend until a defined date 10/ Edit patrons in a batch (tools/modborrowers.pl) and use the registration and expiry date inputs Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13414] Enable right truncation with search by relevance
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 --- Comment #20 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- How is this different from enabling "QueryStemming" ? Automatic truncation can lead to huge number of results, consider the automatic truncation of author names and short words. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #61 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Petter Goksøyr Åsen from comment #59) > I seem to get a lot of failures after this patch. > > I can't get HOLD_SLIP to render without error: > SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: unexpected operator > 'author' with undef operand at /home/vagrant/kohaclone/Koha/Objects.pm line > 168 > > I hooked it up with debugger and it fails in sub _get_tt_params Bug 16942 should fix this problem. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #60 from Petter Goksøyr Åsen <boutrosboutrosboutros(a)gmail.com> --- I managed to fix it by changing the config hash in _get_tt_params: > git diff diff --git a/C4/Letters.pm b/C4/Letters.pm index 737c8cd..c1ef404 100644 --- a/C4/Letters.pm +++ b/C4/Letters.pm @@ -1437,7 +1437,7 @@ sub _get_tt_params { module => 'Koha::Holds', singular => 'hold', plural => 'holds', - fk => [ 'borrowernumber', 'biblionumber' ], + pk => 'reserve_id', }, serial => { module => 'Koha::Serials', But I don't understand this code very well, so you folks have to look at it! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Petter Goksøyr Åsen <boutrosboutrosboutros(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boutrosboutrosboutros@gmail | |.com --- Comment #59 from Petter Goksøyr Åsen <boutrosboutrosboutros(a)gmail.com> --- I seem to get a lot of failures after this patch. I can't get HOLD_SLIP to render without error: SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: unexpected operator 'author' with undef operand at /home/vagrant/kohaclone/Koha/Objects.pm line 168 I hooked it up with debugger and it fails in sub _get_tt_params -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15388] Show Syndetics covers by UPC in search results
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15388 --- Comment #2 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 55007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55007&action=ed… [SIGNED-OFF] Bug 15388 - Show Syndetics covers by UPC in search results Syndetics code accepts UPC and OCLC numbers, however, we were only passing this if there was an ISBN. This patch alters the code to search if either an ISBN or UPC is present To test: Enable syndetics (will need an account) Search for items with UPCs or OCLC numbers and no ISBN (DVDs) Note there are no images in search results but there are in details Apply patch Note that items with images in details now also have images in results Signed-off-by: Barbara.Johnson(a)bedfordtx.gov -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15388] Show Syndetics covers by UPC in search results
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15388 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #41 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 55002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55002&action=ed… Bug 14060: Add the datepicker class to dateofbirth -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 55001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55001&action=ed… Bug 14060: Force leading zeros on date If a date does not contain leading zeros for day and month, the date will be refused. parseDate function considers 1/1/1990 as a valid date, but our perl code does not. We must refuse it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0