August 2016 - Koha-bugs - lists.koha-community.org

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55002|0 |1 is obsolete| | --- Comment #49 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 55019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55019&action=ed… [SIGNED-OFF] Bug 14060: Add the datepicker class to dateofbirth Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55001|0 |1 is obsolete| | --- Comment #48 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 55018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55018&action=ed… [SIGNED-OFF] Bug 14060: Force leading zeros on date If a date does not contain leading zeros for day and month, the date will be refused. parseDate function considers 1/1/1990 as a valid date, but our perl code does not. We must refuse it. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54907|0 |1 is obsolete| | --- Comment #47 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 55017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55017&action=ed… [SIGNED-OFF] Bug 14060: Display date format pattern instead of date format name Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54906|0 |1 is obsolete| | --- Comment #46 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 55016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55016&action=ed… [SIGNED-OFF] Bug 14060: Add support for dmydot Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54905|0 |1 is obsolete| | --- Comment #45 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 55015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55015&action=ed… [SIGNED-OFF] Bug 14060: Force the input to contain a valid date Before this patch, the user was still allowed to enter a valid date. Now, if the date is not valid, the input is emptied. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54904|0 |1 is obsolete| | --- Comment #44 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 55014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55014&action=ed… [SIGNED-OFF] Bug 14060: Display the date format on the warning popup The date format is now displayed on the warning popup. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54903|0 |1 is obsolete| | --- Comment #43 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 55013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55013&action=ed… [SIGNED-OFF] Bug 14060: Add OnClose event on missing datepicker The "suspend until" inputs (hold list on circ/circulation.pl and members/moremember.pl) were not set in the same way. The minDate option should be set for both (bug 10703 removed it for circ/circulation.pl). This patch reintroduces the option and add the OnClose event on both. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54902|0 |1 is obsolete| | --- Comment #42 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 55012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55012&action=ed… [SIGNED-OFF] Bug 14060: Remove readonly attributes on date inputs In order to remove accessibility issues due to the readonly attributes on date inputs, this patch will remove them and introduce a javascript validation on them. This patch is not perfect for some reason: I didn't manage to force the user to select a valid date. One solution would be to reopen the datepicker plugin until a valid date is inserted. But it could be annoying for users (and for me: I did not manage to implement this solution). You will note that input is emptied if the date is not valid. This is a quick and efficient solution to prevent submitting invalid date and make Koha explodes. A proper solution would be to implement the check server side send a friendly message to the user. Test plan: For all inputs, try an invalid and a valid date. 1/ Debar a patron 2/ On the checkout tables (circulation and moremember), add a renewal due date (at the bottom of the tables) 3/ On the checkout page, specify a due date 4/ On the return page, specify a return date 5/ On the invoice page (acquisition module), enter a shipment and billing date 6/ On the invoice search page (invoices.pl) use filters shipment and billing dates 7/ On the offline circ page, specify a due date 8/ On the edit patron page (memberentry), add a debarment 9/ On the reserve page (reserve/request.pl), use the date inputs to suspend until a defined date 10/ Edit patrons in a batch (tools/modborrowers.pl) and use the registration and expiry date inputs Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13414] Enable right truncation with search by relevance
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 --- Comment #20 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- How is this different from enabling "QueryStemming" ? Automatic truncation can lead to huge number of results, consider the automatic truncation of author names and short words. -- You are receiving this mail because: You are watching all bug changes.

1 0