August 2016 - Koha-bugs - lists.koha-community.org

[Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 --- Comment #19 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Dependency is in Wheezy and Jessie, we're good to go from my side. I'll update the control file once this is pushed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #141 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 55046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55046 Bug 11592: (QA followup) Add missing framework code to ViewPolicy filter calls Review of attachment 55046: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=115…) ----------------------------------------------------------------- Just a quick eyeball. ::: opac/opac-MARCdetail.pl @@ +73,5 @@ > +if ( ! $record ) { > + print $query->redirect("/cgi-bin/koha/errors/404.pl"); > + exit; > +} > + Okay. More logical location. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #140 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 55045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55045 Bug 11592: (QA followup) Simplify code Review of attachment 55045: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=115…) ----------------------------------------------------------------- Just an eyeball. ::: catalogue/ISBDdetail.pl @@ -33,5 @@ > > =cut > > -use strict; > -#use warnings; FIXME - Bug 2505 I wouldn't change to Modern::Perl, unless all the Bug 2505 references are fixed like this. ::: opac/opac-export.pl @@ +35,5 @@ > $biblionumber = int($biblionumber); > my $error = q{}; > > +my $include_items = ($format =~ /bibtex/) ? 0 : 1; > +my $marc = GetMarcBiblio($biblionumber, $include_items) Oooo... nice simplification. ::: opac/opac-showmarc.pl @@ -58,4 @@ > > if ($view eq 'card' || $view eq 'html') { > - # FIXME: GetXmlBiblio needs filtering later. > - my $xml = $importid ? $record->as_xml(): GetXmlBiblio($biblionumber); GetXmlBiblio includes fields which aren't necessarily in GetMarcBiblio, if I recall correctly. I'm not sure about this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #139 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 55046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55046&action=ed… Bug 11592: (QA followup) Add missing framework code to ViewPolicy filter calls This patch adds the frameworkcode option param, using each record's frameworkcode as expected by the filter. Otherwise the ViewPolicy filter falls back to the default framework. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #138 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 55045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55045&action=ed… Bug 11592: (QA followup) Simplify code Koha::RecordProcessor and the defined filters are supposed to bring us joy and happiness. Let's keep the code compact, simple and clean. This patch removes record cloning all over the place. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53444|0 |1 is obsolete| | --- Comment #137 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 55044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55044&action=ed… Bug 11592: MARCView and ISBD followup There are still some leaks, but it is not as a result of the filter, but rather a result of poorly written template files. Bug fixing template files is beyond the scope of this set of patches. TEST PLAN --------- 1) Backup your DB 2) run the following SQL on your DB. > UPDATE marc_subfield_structure set hidden=-8; -- this should set EVERYTHING to hidden across the board. 3) In staff client, set OPACXSLTDetailsDisplay to blank 4) In OPAC, view any detail. -- Normal view may mostly leak values still. -- MARC view may leak values. -- ISBD view may leak values. 5) In staff client, set OPACXSLTDetailsDisplay to default 6) In OPAC, view any detail. -- same issues as step 4 -- 'View Plain' may leak too. 7) 'Save record' -> 'Dublin Core' 8) Apply this patch 9) run koha qa test tools -- should be fine 10) prove -v t/db_dependent/Filter_MARC_ViewPolicy.t -- should pass -- this proves Koha/Filter/MARC/ViewPolicy.pm tweaks too 11) In OPAC, view any detail. -- Normal view: -- Material type comes from the LEADER field. -- Lists this is on will still display -- 'Tags from this library' will still display -- Item information in table will still display (THIS IS BEYOND SCOPE) -- MARC view: -- Record number is leaked (THIS IS BEYOND SCOPE) -- 'View plain' leaks LEADER field. -- ISBD view may leak field headings, but not values. (THIS IS BEYOND SCOPE) 12) In staff client, set OPACXSLTDetailsDisplay to blank 13) In OPAC, view any detail. -- same kind of output as step 10 14) 'Save record' -> BIBTEXT -- Should be next to nothing leaked. 15) 'Save record' -> Dublin Core -- Should be the same or less leaked between the two versions. -- (XML FILTERING IS BEYOND SCOPE) 16) In the staff client, go view the same record. -- it should be mostly hidden in ISBD View. 17) run the following SQL on your DB. > UPDATE marc_subfield_structure set hidden=1; -- this should set EVERYTHING to hidden in OPAC, but not the STAFF across the board. 18) Refresh the staff ISBD page -- values should reappear. 19) View the ISBD details in the OPAC -- values should still be hidden. 20) Check out the OPAC Cart and List -- while the intermediate pages may still leak the download links should leak very minimally. -- (CARTS AND LISTS ARE BEYOND SCOPE, THOUGH THE INTRANET ISBD AND SOME CART/LIST STUFF WERE FIXED BECAUSE OF THE GetISBDView REFACTOR) Expectations: Before Patch - all the OPAC Detail pages will display things After Patch - all the OPAC Detail pages will display much less, and hopefully nothing (though there are known limits). the ISBD detail page in the Staff client will be filtered as well based on STAFF settings. The saving/exporting should generate nearly empty files. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53443|0 |1 is obsolete| | --- Comment #136 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 55043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55043&action=ed… Bug 11592: Biblio tweak for MARCSUBJECT https://bugs.koha-community.org/show_bug.cgi?id=11592 Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53442|0 |1 is obsolete| | --- Comment #135 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 55042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55042&action=ed… Bug 11592: Applying filtering to opac interface. Applying the filtering and then... Debugging opac/opac-detail.pl filtering Debugging opac/opac-ISBDdetail.pl more Debugging opac/opac-export.pl Tweak opac/opac-export.pl fix variable declarations, conditional assignments Debugging opac/opac-showmarc.pl https://bugs.koha-community.org/show_bug.cgi?id=11592 Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53441|0 |1 is obsolete| | --- Comment #134 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 55041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55041&action=ed… Bug 11592: Add should_hide_marc method to filter Add should_hide_marc to ViewPolicy filter Add should_hide_marc tests to t/db_dependent/Filter_MARC_ViewPolicy.t Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '16

30 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53440|0 |1 is obsolete| | --- Comment #133 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 55040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55040&action=ed… Bug 11592: Updated License Text and use Modern::Perl Why not clean up the License Agreement stuff while the files are being changed? Used the current one found at: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Changed the strict and warning lines into just a Modern::Perl. Signed-off-by: Robin Sheat <robin(a)catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Brendan Gallagher <brendan(a)bywatersolutions.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0