January 2017 - Koha-bugs - lists.koha-community.org

[Bug 17988] New: Select2 prevents correct tag expand/ minimize functionality
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '17

25 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Bug ID: 17988 Summary: Select2 prevents correct tag expand/minimize functionality Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: synapse.ova(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Overview: Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure. Because of that, expanding fields to show all hidden subfields does not work properly. Steps to Reproduce: 1. Open some book in the editor or create new (cataloguing/addbiblio.pl) 2. Try to minimize or expand fields, that have among subfields the following: — Thesaurus driven subfield → subfield with Select2 — Hidden subfield. Actual Results: — some fields become hidden, some not, and vice versa — in the console, you'll see «Uncaught TypeError: Cannot read property 'match' of null» Expected Results: — all subfields should minimize/maximize completely Additional Information: This happens because Select2 adds some divs, that do not have ID property. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 17913] New: Merge three authority merge fixes
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '17

24 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Bug ID: 17913 Summary: Merge three authority merge fixes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Best from 5572/11315/11700 comes here -- You are receiving this mail because: You are watching all bug changes.

1 104

[Bug 17782] New: Patron updated_on field should be set to current timestamp when borrower is deleted
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Bug ID: 17782 Summary: Patron updated_on field should be set to current timestamp when borrower is deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Currently the timestamp is not udpated when a patron is deleted. This is because we insert the db value of updated_on from the patron when we move the borrower. Clearing the value beforehand should resolve this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 31

[Bug 17838] New: Availability limit broken until an item has been checked out
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17838 Bug ID: 17838 Summary: Availability limit broken until an item has been checked out Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The availability limit in the OPAC will return on results, until an item has been checked out for the first time. >From the mailing list: The index doesn't exist, so the query fails, the index just has to exist (which it does as soon as something is circulated, it will continue to work if you return that item, the index doesn't go away, unless you do a full reindex and have not circulated anything ever) In practice people don't run into this much at all. However the fix is just in the ccl.properties file /etc/koha/zebradb/ccl.properties change line 1032 From onloan 1=8024 to onloan 1=8024 14=1 And it will work even if you library has never done a circulation operation -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 17788] New: (MARC21) $9 fields not indexed in authority-linked fields
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 Bug ID: 17788 Summary: (MARC21) $9 fields not indexed in authority-linked fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt(a)gmail.com Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org If you check the default framework shipped with Koha, you will notice several fields are linked to authority records (even though they might be hidden in the editor): MariaDB [koha_kohadev]> SELECT tagfield,tagsubfield,authtypecode FROM marc_subfield_structure WHERE authtypecode IS NOT NULL AND authtypecode<>'' AND frameworkcode='' GROUP BY tagfield,tagsubfield,authtypecode ; +----------+-------------+--------------+ | tagfield | tagsubfield | authtypecode | +----------+-------------+--------------+ | 100 | a | PERSO_NAME | | 110 | a | CORPO_NAME | | 111 | a | MEETI_NAME | | 130 | a | UNIF_TITLE | | 440 | a | UNIF_TITLE | | 600 | a | PERSO_NAME | | 610 | a | CORPO_NAME | | 611 | a | MEETI_NAME | | 630 | a | UNIF_TITLE | | 648 | a | CHRON_TERM | | 650 | a | TOPIC_TERM | | 651 | a | GEOGR_NAME | | 654 | a | TOPIC_TERM | | 655 | a | GENRE/FORM | | 656 | a | TOPIC_TERM | | 657 | a | TOPIC_TERM | | 658 | a | TOPIC_TERM | | 662 | a | GEOGR_NAME | | 690 | a | TOPIC_TERM | | 691 | a | GEOGR_NAME | | 696 | a | PERSO_NAME | | 697 | a | CORPO_NAME | | 698 | a | MEETI_NAME | | 699 | a | UNIF_TITLE | | 700 | a | PERSO_NAME | | 710 | a | CORPO_NAME | | 711 | a | MEETI_NAME | | 730 | a | UNIF_TITLE | | 796 | a | PERSO_NAME | | 797 | a | CORPO_NAME | | 798 | a | MEETI_NAME | | 799 | a | UNIF_TITLE | | 800 | a | PERSO_NAME | | 810 | a | CORPO_NAME | | 811 | a | MEETI_NAME | | 830 | a | UNIF_TITLE | | 896 | a | PERSO_NAME | | 897 | a | CORPO_NAME | | 898 | a | MEETI_NAME | | 899 | a | UNIF_TITLE | +----------+-------------+--------------+ But looking at etc/zebradb/marc_defs/marc21/biblio-koha-indexdefs.xml you will notice the $9 subfields is not correctly added to the Koha-Auth-Number:w index. This has the consequence of authority usage count not being precise if those fields are used and linked. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 18025] New: Expired password recovery links cause sql crash
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025 Bug ID: 18025 Summary: Expired password recovery links cause sql crash Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: liz(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Trying to reset a password with an expired token leads to a very user unfriendly sql crash: DBD::mysql::st execute failed: Duplicate entry '19' for key 'PRIMARY' [for Statement "INSERT INTO `borrower_password_recovery` ( `borrowernumber`, `uuid`, `valid_until`) VALUES ( ?, ?, ? )" with ParamValues: 0='19', 1='$2a$08$O8FjE434Ue3DLtGTgQB3Bu', 2='2017-02-02T22:03:01'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '19' for key 'PRIMARY' at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 127 We should delete these if they exist, and issue a new token. -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 16984] New: Acquisitions broken
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984 Bug ID: 16984 Summary: Acquisitions broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In acquisitions, even if AcqCreateItem is set to create an item at the time of ordering, the item creation form does not display. Instead, this JavaScript error shows in the console: additem.js:176 Uncaught TypeError: window[events[i]] is not a function I believe this regression was introduced by bug 15531. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 16115] New: JavaScript error on item search form
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115 Bug ID: 16115 Summary: JavaScript error on item search form Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/catalogue/itemsearch.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org In the template for the item search page there is this at line 290: { 'type': 'select', 'values': [% notforloans.json %] }, [% notforloans.json %] appears to be undefined, whether the search form has been submitted or not. Viewing source shows this: { 'type': 'select', 'values': }, ...and the Firebug console reports this error: SyntaxError: expected expression, got '}' /cgi-bin/koha/catalogue/itemsearch.pl Line 240 -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 17871] New: Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 Bug ID: 17871 Summary: Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt(a)gmail.com Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Colin Campbell and Frédéric Demians mentioned in 2015 that Zebra facets don't work with YAZ 5.8.1: https://lists.katipo.co.nz/public/koha/2015-February/041987.html In 2016, Zeno said he couldn't get zebra::snippet to work: http://koha.1045719.n5.nabble.com/Zebra-the-elements-zebra-snippet-doesn-t-… I've looked at Indexdata's YAZ git repo for 5.8.1: https://github.com/indexdata/yaz/blame/v5.8.1/src/retrieval.c And I think the problem is this commit: https://github.com/indexdata/yaz/commit/f24766f1e9fc5404fc0b512af8607d7f705… At first, I thought the problem was with yaz_match_glob, but I've tested this function independently, and I think it's OK. I think the problem might be with how "el_best" is getting set. In theory, <retrieval syntax="xml"/> should be selected as el_best first... then zebra::* should be selected as it should have a true value returned from yaz_match_glob. (Note that "return 0" appears to indicate success for yaz_retrieval_request.) So if you try to use facets with YAZ 5.8.1, you get the following from Zebra: [25] Specified element set name not valid for specified database -- v2 addinfo ''. That makes it seem like el_best isn't being set at all... but I don't know. I'm going to email Indexdata and see what they come up with for this one. But in any case... I have a solution for now. If we remove the line <retrieval syntax="xml" name="zebra::*" /> and restart Zebra, we can get results using zebra::facet and zebra::snippet. I've tested this change with OpenSuse Leap 42.2 with Zebra 2.0.60 and YAZ 5.8.1, and it works, but I'd be interested in hearing about other people's experiences with older (and newer) versions of YAZ. With commit 67abcc64, Marcel actually removed most unnecessary retrieval elements, but Tomas added them back with ca074c92 along with the zebra::* line. -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 17487] New: Improper placement of select/clear all in Z39.50/ SRU search dialog
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Bug ID: 17487 Summary: Improper placement of select/clear all in Z39.50/SRU search dialog Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt(a)gmail.com Reporter: rbit(a)rbit.cz QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Links allowing to select/clear all Z39.50 servers have icons next to the text. These links are improperly placed in the case the localized caption is a bit longer than English version, see picture: http://prntscr.com/cy0bey In addition, these links are placed in an <h2> header, but it's not semantically correct. -- You are receiving this mail because: You are watching all bug changes.

1 24