January 2017 - Koha-bugs - lists.koha-community.org

[Bug 17871] New: Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 Bug ID: 17871 Summary: Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt(a)gmail.com Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Colin Campbell and Frédéric Demians mentioned in 2015 that Zebra facets don't work with YAZ 5.8.1: https://lists.katipo.co.nz/public/koha/2015-February/041987.html In 2016, Zeno said he couldn't get zebra::snippet to work: http://koha.1045719.n5.nabble.com/Zebra-the-elements-zebra-snippet-doesn-t-… I've looked at Indexdata's YAZ git repo for 5.8.1: https://github.com/indexdata/yaz/blame/v5.8.1/src/retrieval.c And I think the problem is this commit: https://github.com/indexdata/yaz/commit/f24766f1e9fc5404fc0b512af8607d7f705… At first, I thought the problem was with yaz_match_glob, but I've tested this function independently, and I think it's OK. I think the problem might be with how "el_best" is getting set. In theory, <retrieval syntax="xml"/> should be selected as el_best first... then zebra::* should be selected as it should have a true value returned from yaz_match_glob. (Note that "return 0" appears to indicate success for yaz_retrieval_request.) So if you try to use facets with YAZ 5.8.1, you get the following from Zebra: [25] Specified element set name not valid for specified database -- v2 addinfo ''. That makes it seem like el_best isn't being set at all... but I don't know. I'm going to email Indexdata and see what they come up with for this one. But in any case... I have a solution for now. If we remove the line <retrieval syntax="xml" name="zebra::*" /> and restart Zebra, we can get results using zebra::facet and zebra::snippet. I've tested this change with OpenSuse Leap 42.2 with Zebra 2.0.60 and YAZ 5.8.1, and it works, but I'd be interested in hearing about other people's experiences with older (and newer) versions of YAZ. With commit 67abcc64, Marcel actually removed most unnecessary retrieval elements, but Tomas added them back with ca074c92 along with the zebra::* line. -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 17487] New: Improper placement of select/clear all in Z39.50/ SRU search dialog
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Bug ID: 17487 Summary: Improper placement of select/clear all in Z39.50/SRU search dialog Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt(a)gmail.com Reporter: rbit(a)rbit.cz QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Links allowing to select/clear all Z39.50 servers have icons next to the text. These links are improperly placed in the case the localized caption is a bit longer than English version, see picture: http://prntscr.com/cy0bey In addition, these links are placed in an <h2> header, but it's not semantically correct. -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 17726] New: TestBuilder's refactoring removed default values
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 Bug ID: 17726 Summary: TestBuilder's refactoring removed default values Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Reading the commit message of bug 16155, it was expected to remove the default values for given fields. But actually I think we should reintroduce it. -- You are receiving this mail because: You are watching all bug changes.

1 27

[Bug 17823] New: XSLT: Add label for MARC 583 - Action note
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823 Bug ID: 17823 Summary: XSLT: Add label for MARC 583 - Action note Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The Action note has no label/description in the detail pages. It should have one :) -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 17990] New: Code to check perl module versions is buggy
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '17

21 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 Bug ID: 17990 Summary: Code to check perl module versions is buggy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17986 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 [Bug 17986] Perl dependency evaluation incorrect -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 17414] New: Add GIR codes added to Edifact since 1.2
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17414 Bug ID: 17414 Summary: Add GIR codes added to Edifact since 1.2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: colin.campbell(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org 4 new GIR codes have been added to Edifact since version 1.2 see http://www.editeur.org/files/EDIfact%20eancom%20pdfs/EDIfact%20library%20su… The following codes have been added to DE 7405: LHC Library Holding Code: may hold a combination of information i ncluding location , sequence, item type etc. as a single data string (contents defined by the library). LRP Library Rotation Plan: a code number assigned by a library to identify a rotation plan to which an item belongs. LSC Statistical category: a c ode used by a library to identify a statistical category (e.g. „605‟ or „Children‟s Picture Books‟) for management reporting purposes. RIC Reader Interest Category: code to identify stock at a lower level than LST (Stock Category) eg. Western, Science Fiction. These need to be added to list of recognized codes for future developments ( e.g. to include Stock Rotation intp in LRP ) to be able to utilize these -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 17909] New: Add unit tests for authority merge
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Bug ID: 17909 Summary: Add unit tests for authority merge Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 40

[Bug 18009] New: IssueSlip.t test fails if launched between 00:00 and 00: 59
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 Bug ID: 18009 Summary: IssueSlip.t test fails if launched between 00:00 and 00:59 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mtj(a)kohaaloha.com QA Contact: gmcharlt(a)gmail.com here's an example of the test passing then failing with 2 different dates. ------------------------- vagrant@kohadevbox:~$ sudo date -s 'Sun Jan 29 01:41:55 UTC 2017' Sun Jan 29 01:41:55 GMT 2017 kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Members/IssueSlip.t t/db_dependent/Members/IssueSlip.t .. ok All tests successful. Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 2.10 cusr 0.12 csys = 2.25 CPU) Result: PASS ------------------------- vagrant@kohadevbox:~$ sudo date -s 'Sun Jan 29 00:41:55 UTC 2017' Sun Jan 29 00:41:55 GMT 2017 kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Members/IssueSlip.t t/db_dependent/Members/IssueSlip.t .. # Looks like you planned 2 tests but ran 1. # Failed test 'Hourly loans' # at t/db_dependent/Members/IssueSlip.t line 279. # Looks like you failed 1 test of 3. t/db_dependent/Members/IssueSlip.t .. 1/3 # Failed test 'Issue slip' # at t/db_dependent/Members/IssueSlip.t line 281. The 'hour' parameter ("-1") to DateTime::set did not pass the 'an integer between 0 and 23' callback at /usr/lib/x86_64-linux-gnu/perl5/5.20/DateTime.pm line 1946. DateTime::set(undef, "hour", -1) called at t/db_dependent/Members/IssueSlip.t line 254 main::__ANON__() called at /usr/local/share/perl/5.20.2/Test/Builder.pm line 309 eval {...} called at /usr/local/share/perl/5.20.2/Test/Builder.pm line 309 Test::Builder::subtest(Test::Builder=HASH(0x1cfa9d0), "Hourly loans", CODE(0x85c7ea0)) called at /usr/local/share/perl/5.20.2/Test/More.pm line 807 Test::More::subtest("Hourly loans", CODE(0x85c7ea0)) called at t/db_dependent/Members/IssueSlip.t line 279 main::__ANON__() called at /usr/local/share/perl/5.20.2/Test/Builder.pm line 309 eval {...} called at /usr/local/share/perl/5.20.2/Test/Builder.pm line 309 Test::Builder::subtest(Test::Builder=HASH(0x1cfa9d0), "Issue slip", CODE(0x86031c8)) called at /usr/local/share/perl/5.20.2/Test/More.pm line 807 Test::More::subtest("Issue slip", CODE(0x86031c8)) called at t/db_dependent/Members/IssueSlip.t line 281 # Looks like your test exited with 255 just after 1. t/db_dependent/Members/IssueSlip.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/3 subtests Test Summary Report ------------------- t/db_dependent/Members/IssueSlip.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 3 tests but ran 1. Files=1, Tests=1, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.79 cusr 0.08 csys = 1.89 CPU) Result: FAIL ------------------------- -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 17566] New: Change initial focus in item editor depending on last action
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17566 Bug ID: 17566 Summary: Change initial focus in item editor depending on last action Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl If you have saved an existing item or added a new one, it would be nice to have the focus in the search box. In other cases, at the start of adding or editing an item, it would be good to have focus in the item fields already. This patch sets the focus in the second case on the first item input field, since focus on the first select (combo box) does not show up. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 17493] New: Improve OAI Server tests
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17493 Bug ID: 17493 Summary: Improve OAI Server tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: frederic(a)tamil.fr QA Contact: gmcharlt(a)gmail.com Required to help validate bug 15108. -- You are receiving this mail because: You are watching all bug changes.

1 19