October 2017 - Koha-bugs - lists.koha-community.org

[Bug 19276] New: CanBookBeIssued: unsuccessfully refers to borrower category_type X
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 Bug ID: 19276 Summary: CanBookBeIssued: unsuccessfully refers to borrower category_type X Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org This code seems to be unused now: if ( $borrower->{'category_type'} eq 'X' && ( $item->{barcode} )) { # stats only borrower -- add entry to statistics table, and return issuingimpossible{STATS} = 1 . &UpdateStats({ ... Why? The key category_type does not exist. Or perhaps does no longer exist. Perhaps it has been refactored to a Koha object hash or something ? The check itself refers to a column in the categories table that formerly got included in the borrower hash. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 18282] New: OpenAPI operationId must be unique
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 Bug ID: 18282 Summary: OpenAPI operationId must be unique Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org operationId has the following documentation: "Unique string used to identify the operation. The id MUST be unique among all operations described in the API." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 18290] New: Fix t/db_dependent/Koha/Object.t, Mojo::JSON:: Bool is a JSON::PP::Boolean :)
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290 Bug ID: 18290 Summary: Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON::PP::Boolean :) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Bug 11897 depends on bug 18137, which changed state. Bug 18137 Summary: REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19119] New: Remove t/db_dependent/api/v1/swagger/definitions.t
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19119 Bug ID: 19119 Summary: Remove t/db_dependent/api/v1/swagger/definitions.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org While it might have seemed a good idea to have such a test, I find it useless as-is, because there's no obvious reason why we would expose our model on the API spec while it is just user-facing and not a technical explanation on how we do things inside our codebase. A good example of this could be bug 18120, in which it is obvious that some attribute names are misleading or the attributes themselves need to be stripped out of the object for exposing on the API. There can be ways of doing this two operations (i.e. removing/adding attributes, and renaming) without handling it on the controller as those patches do. But in any case, there's no need for definitions.t. We could have a gentle 'warning' in the QA tools in case of a column being added to the DB structure and not to the corresponding endpoint, but it has to be a soft requirement IMO. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 18508] New: Fix t/db_dependent/api/v1/swagger/definitions.t ( follow-up of 18137)
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 Bug ID: 18508 Summary: Fix t/db_dependent/api/v1/swagger/definitions.t (follow-up of 18137) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: lari.taskula(a)jns.fi QA Contact: gmcharlt(a)gmail.com t/db_dependent/api/v1/swagger/definitions.t .. Can't locate object method "cache_dir" via package "Swagger2::SchemaValidator" at /usr/share/perl5/Swagger2.pm line 42. -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 6758] Capture membership renewal date for reporting purposes
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers(a)biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #18 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15336] Script for merging vendors
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 --- Comment #35 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- (In reply to Jonathan Druart from comment #32) > + Add more POD to explain what the script actually does. I've added a little description for the script. Are you ok with that? Also squashed patches -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15336] Script for merging vendors
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15336] Script for merging vendors
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66765|0 |1 is obsolete| | Attachment #66766|0 |1 is obsolete| | Attachment #66767|0 |1 is obsolete| | --- Comment #34 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 68676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68676&action=ed… Bug 15336 - New command-line script: merge_bookseller.pl Test plan (i.e. merge bookseller n° 3 into the n° 6): run perl misc/migration_tools/merge_booksellers.pl -f 3 -t 6 -v -c Check that basketgroups, baskets, contacts, contracts and invoices had moved into bookseller 6. Check that bookseller n° 3 has been deleted. Remove -c (confirm) parameter to run in test mode only. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0