November 2017 - Koha-bugs - lists.koha-community.org

[Bug 19058] New: Move C4::Reserves::GetReserveId to Koha::Holds
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '17

06 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19058 Bug ID: 19058 Summary: Move C4::Reserves::GetReserveId to Koha::Holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 19057 Blocks: 17728 GetReserveId can easily be replaced with a call to Koha::Holds->search->next->reserve_id It will ease next changes to use Koha::Hold objects Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] Move C4::Reserves code to the Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19057 [Bug 19057] Move C4::Reserves::GetReserve to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 19374] New: CircSidebar overlapping transferred items table
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '17

05 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Bug ID: 19374 Summary: CircSidebar overlapping transferred items table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Created attachment 67395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67395&action=ed… CircSidebar overlapping transferred items table When CircSidebar is activated, "Transferred items" table at Circulation -> Transfers goes under the sidebar. See attachment. To reproduce: 1. Activate CircSidebar system preference 2. Go to cgi-bin/koha/circ/branchtransfers.pl 3. Enter a barcode and click submit 4. Observe transferred items table under the circulation side bar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 19675] New: Cannot save notices when setting the TranslateNotices preference
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '17

05 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675 Bug ID: 19675 Summary: Cannot save notices when setting the TranslateNotices preference Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: andreas.jonsson(a)kreablo.se QA Contact: testopia(a)bugs.koha-community.org The lang parameter is missing in the where clause of the update statement. The below patch fixes the problem. diff --git a/tools/letter.pl b/tools/letter.pl index 5920a8437f..f89930472c 100755 --- a/tools/letter.pl +++ b/tools/letter.pl @@ -303,11 +303,11 @@ sub add_validate { q{ UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? - WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? + WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? AND lang = ? }, undef, $branchcode || '', $module, $name, $is_html || 0, $title, $content, $lang, - $branchcode, $oldmodule, $code, $mtt + $branchcode, $oldmodule, $code, $mtt, $lang ); } else { $dbh->do( To reproduce: 1. Enable TranslateNotices global preference. 2. Edit any notice message and save a translation. 3. Try updating any translation. The save will fail and the log-file will contain errors such as this: DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/koha/lib/Koha/Objects.pm line 92 DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/koha/lib/Koha/Objects.pm line 92 DBD::mysql::db do failed: Duplicate entry 'circulation-ODUE--email-sv-SE' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. DBD::mysql::db do failed: Duplicate entry 'circulation-ODUE--email-en' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 19516] New: can' t save changes on notices if letter is already created
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '17

05 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19516 Bug ID: 19516 Summary: can't save changes on notices if letter is already created Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: hagud(a)orex.es QA Contact: testopia(a)bugs.koha-community.org we have seen a problem modifying notices in koha 17.05.04, the issue is that you can not modify notices if they're already created, when you try to modify you get an error in plack as these one. DBD::mysql::db do failed: Duplicate entry 'circulation-PREDUE--email-ca-ES' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. DBD::mysql::db do failed: Duplicate entry 'circulation-PREDUE--sms-ca-ES' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. DBD::mysql::db do failed: Duplicate entry 'circulation-PREDUE--email-es-ES' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. DBD::mysql::db do failed: Duplicate entry 'circulation-PREDUE--sms-es-ES' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. DBD::mysql::db do failed: Duplicate entry 'circulation-PREDUE--email-default' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. DBD::mysql::db do failed: Duplicate entry 'circulation-PREDUE--sms-default' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 18447] New: Datepicker only shows -10/+10 years
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '17

04 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Bug ID: 18447 Summary: Datepicker only shows -10/+10 years Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When entering patrons they are often more than 10 years old - entering a birth date requires constantly clicking back 10 years on the date picker - we should load a few more years in the past This was fixed in bug 12342 but that code is no longer used -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 58

[Bug 16239] New: Upgrade Bootstrap in the staff client
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '17

04 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Bug ID: 16239 Summary: Upgrade Bootstrap in the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 15883 Blocks: 14546 Now that we are on a path to getting a jQuery upgrade, it's time to start working on an upgrade to Bootstrap in the staff client. I propose that this upgrade be done as a precursor to (rather than simultaneously with) a full conversion of the staff client to a Bootstrap grid (Bug 14546). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client -- You are receiving this mail because: You are watching all bug changes.

1 119

[Bug 18937] New: Limit the number of list entries to print
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '17

04 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18937 Bug ID: 18937 Summary: Limit the number of list entries to print Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl When you have large lists of say 2000 entries, the option Print a list may be very time consuming. Especially when an impatient user hits refresh a couple of times, this might affect your server performance. This patch adds paging to list printing when the number of list entries is over 200 (just a constant). The number of entries to print is now governed by preference OPACnumSearchResults. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 17624] New: OPACXSLTResultsHideNFL
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '17

04 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624 Bug ID: 17624 Summary: OPACXSLTResultsHideNFL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 19555] New: Some changes to records are not reflected in OAI-PMH
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '17

04 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555 Bug ID: 19555 Summary: Some changes to records are not reflected in OAI-PMH Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org The OAI-PMH server can take "from" and "until" dates, in which case it should return records that were added or changed in the given date range: /koha/oai.pl?verb=ListRecords&metadataPrefix=marcxchange&from=2017-10-26&until=2017-10-28 In current master, Koha uses biblioitems.timestamp to figure out which records should be returned for a given timeframe: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/OAI/Server/L… This worked fine when the marcxml column was still in the biblioitems table. Any change to the record would update the timestamp and it would be reflected in OAI-PMH. But then we yanked marcxml out of the biblioitems table, and moved it to biblio_metadata.metadata. This means that biblioitems.timestamp only gets updated when one of the MARC-fields that has its own column in biblioitems gets updated. And this means that some changes are not reflected in OAI-PMH. To verify: - Open a record for editing in Koha - Look at the row in biblioitems that corresponds to the record - Change e.g. one of the subjects -> the timestamp is not updated - Change e.g. the ISBN -> the timestamp IS updated The solution that comes to my mind first is to: - add a timestamp to the biblio_metadata table, and - consider both biblioitems.timestamp and biblio_metadata.timestamp when OAI-PMH decides what records to return Opinions? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 18152] New: UNIMARC bib records imported with invalid 'a' char in label pos.9
by bugzilla-daemon＠bugs.koha-community.org 02 Dec '17

02 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 Bug ID: 18152 Summary: UNIMARC bib records imported with invalid 'a' char in label pos.9 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt(a)gmail.com Reporter: stephane.delaune(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org The standard UNIMARC requires than the 9th character (starting from 0) in labels must be blank (while it may be 'a' in marc21) the problem is that C4::Charset::SetMarcUnicodeFlag (called in particular when we import a record) always add 'a' char in the 9th label'pos whereas it should do it just for MARC21 and NORMARC (not for UNIMARC) : C4::Charset::SetMarcUnicodeFlag add 'a' char in the 9th label character for MARC21 and NORMARC (it's normal), but just before doing this it call "$marc_record->encoding('UTF-8')" which is a MARC::Record function which, when called with 'UTF-8' parameter, do only one thing : add 'a' char in the 9th label character -- You are receiving this mail because: You are watching all bug changes.

1 41