November 2017 - Koha-bugs - lists.koha-community.org

[Bug 19593] New: "Delete vendor" button is always set
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '17

19 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593 Bug ID: 19593 Summary: "Delete vendor" button is always set Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: gwendal.joncour(a)univ-rennes2.fr QA Contact: testopia(a)bugs.koha-community.org On our freshly updated 16.11 instance, we noticed that on pages /cgi-bin/koha/acqui/booksellers.pl and /cgi-bin/koha/acqui/supplier.pl, the acquisition toolbar always shows the "Delete vendor" button instead of the "Receive shipments", no matter the number of baskets attached to the vendor. When I looking on conditions on koha-tmpl/intranet-tmpl/prog/en/include/acquisitions-toolbar.inc, I saw that basketcount variable is not set. acqui/booksellers.pl and acqui/supplier.pl calling $suppliers[0]->{'basketcount'} and $supplier->{'basketcount'} from Koha::Acquisition::Bookseller while Bookseller.pm has a basket_count method to return it, explaining why the "Delete vendor" button is always shown. The problem is mainly cosmetic but with it, the test on vendor deletion in supplier.pl line 95... if ( $supplier->{'basketcount'} == 0 ) { ...always returns true so the only thing preventing deletion of vendor with baskets attached on is the database foreign key contraint. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 18679] New: Patron Attributed in Self Registration
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '17

19 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18679 Bug ID: 18679 Summary: Patron Attributed in Self Registration Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: apurbajyoti(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The patron attribute options are not visible or editable in OPAC Patron Self Registration page.The attributed can to be updated by Library Staffs only under staff portal by editing patron details. May be added so that users can themselves update. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 19229] New: Clicking Cancel when editing course doesn' t take you back to the course
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '17

19 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19229 Bug ID: 19229 Summary: Clicking Cancel when editing course doesn't take you back to the course Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Instead it takes you back to the courses home page, which feels like the unexpected behaviour. I would expect to click on a course, click Edit, then click Cancel and be returned to the course. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 19714] New: 2 occurrences of memberofinstitution have not been removed
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '17

19 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 Bug ID: 19714 Summary: 2 occurrences of memberofinstitution have not been removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 11751 C4/UsageStats.pm: memberofinstitution t/db_dependent/UsageStats.t: memberofinstitution Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11751 [Bug 11751] Some code related to "institution" is unused and obsolete -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 17584] New: Add the Koha::Patron->get_issues method
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '17

18 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Bug ID: 17584 Summary: Add the Koha::Patron->get_issues method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 16909] New: Koha::Patrons - Remove checkuniquemember
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '17

18 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16909 Bug ID: 16909 Summary: Koha::Patrons - Remove checkuniquemember Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org C4::Members::checkuniquemember was not really nicely written, was only used once and was not covered by tests. I think it does not make sense to keep such complexity and have this code in the subroutine/method. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 19710] New: Move plugins templates to the footer
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '17

14 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710 Bug ID: 19710 Summary: Move plugins templates to the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 19647 Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for plugins templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 [Bug 19647] Move patron lists templates JS to the footer -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 19697] New: Move template JavaScript to the footer: Search results
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '17

14 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19697 Bug ID: 19697 Summary: Move template JavaScript to the footer: Search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for the catalog search results page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 19680] New: Move JS to the footer: Patron and circulation tools
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '17

14 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680 Bug ID: 19680 Summary: Move JS to the footer: Patron and circulation tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 19647 Blocks: 17858 In order to conform to best practices for performance, staff client template JavaScript should be in the footer instead of the header. This patch will do so for some patron and circulation-related tools. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 [Bug 19647] Move patron lists templates JS to the footer -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 19679] New: Move tools templates JavaScript to the footer: More MARC tools
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '17

14 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679 Bug ID: 19679 Summary: Move tools templates JavaScript to the footer: More MARC tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 19647 Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for more Tools features. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 [Bug 19647] Move patron lists templates JS to the footer -- You are receiving this mail because: You are watching all bug changes.

1 12