November 2017 - Koha-bugs - lists.koha-community.org

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #15 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment Interesting feature! Limited testing did not reveal problems. Functionality issue: In Administration, smart-rules, the section "Default checkout limit by patron category" contains the item "Maximum total holds allowed (count)". Not sure if the label should contain total and count btw. But the section should be renamed. This does not pertain any longer to checkout limits only. Furthermore I would expect to have max_holds also under Default checkout, hold and return policy. It seems consistent to add it also without a patron category restriction. Same as current checkouts etc. Hard to move it to FQA for that reason. At least I want to have some additional opinions. Setting to In Discussion. Please ask for feedback via IRC or ML. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15503] Grab Item Information from Order Files
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha(a)univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14413] map internalnotes to MarcFieldsToOrder
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14413 --- Comment #2 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- It's perhaps fixed bt BZ15503 but it seems that it needs follow-up ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14413] map internalnotes to MarcFieldsToOrder
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14413 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha(a)univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- I agree with Nicole, it would be usefull have the possibility to get order_internalnote thanks to MarcFieldsToOrder syspref, while we download iso2709 files for order. Sonia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12027] Shibboleth authentication for staff client
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 --- Comment #28 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Zeno asked me: === I think that Matthias on commen7 #26 is quite clear It is not enough a rebase for this patch ? === Yeah I focused on a reply from Martin. So probably true. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12027] Shibboleth authentication for staff client
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #27 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Also please add feedback for comment 25. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10748] Add option to block return of lost items
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Please add a test case for AddReturn. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #32 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: GetOverduesForBranch Please add a test. You make some fundamental changes here. koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt - <input type="hidden" name="totals[% line.accountlines_id %]" value="[% line.totals %]" /> Not sure. Why do yo remove this line ? New code: + my $accounts = Koha::Account::Lines->search({ borrowernumber => $borrowernumber, }, { order_by => ['accounttype'] }); + my @accounts; + while ( my $account = $accounts->next ) { This does not look very nice. Can we get more confusion on $account, @accounts or $accounts ? Renaming @accounts here might be the least we can do? No blocker on itself. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #31 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8) > Created attachment 68263 [details] [review] > Bug 10021: Drop columns notify_id and notify_level from accountlines > > It appears that has never worked. > Could someone confirm? Did you have any response whatsoever ? -- You are receiving this mail because: You are watching all bug changes.

1 0