November 2017 - Koha-bugs - lists.koha-community.org

[Bug 12027] Shibboleth authentication for staff client
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 --- Comment #28 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Zeno asked me: === I think that Matthias on commen7 #26 is quite clear It is not enough a rebase for this patch ? === Yeah I focused on a reply from Martin. So probably true. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12027] Shibboleth authentication for staff client
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #27 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Also please add feedback for comment 25. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10748] Add option to block return of lost items
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Please add a test case for AddReturn. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #32 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: GetOverduesForBranch Please add a test. You make some fundamental changes here. koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt - <input type="hidden" name="totals[% line.accountlines_id %]" value="[% line.totals %]" /> Not sure. Why do yo remove this line ? New code: + my $accounts = Koha::Account::Lines->search({ borrowernumber => $borrowernumber, }, { order_by => ['accounttype'] }); + my @accounts; + while ( my $account = $accounts->next ) { This does not look very nice. Can we get more confusion on $account, @accounts or $accounts ? Renaming @accounts here might be the least we can do? No blocker on itself. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #31 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8) > Created attachment 68263 [details] [review] > Bug 10021: Drop columns notify_id and notify_level from accountlines > > It appears that has never worked. > Could someone confirm? Did you have any response whatsoever ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #30 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- FAIL C4/Members.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL C4/Overdues.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 No reason to immediately move this to FQA ! When you remove a sub from a module without full coverage, this is the result. Something for QA tools ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl Severity|normal |enhancement --- Comment #29 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Moving this to enh -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '17

02 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 John DeLooper <jdelooper(a)hccc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdelooper(a)hccc.edu --- Comment #12 from John DeLooper <jdelooper(a)hccc.edu> --- I too would love to see this kind of feature added, and am glad to see patches in progress. I think a process for merging creates a smoother experience than the current looking up duplicates and choosing which one to delete. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '17

02 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Patch rebased and rewritten, please test. Srdjan's concern is not valid IMO. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0