November 2017 - Koha-bugs - lists.koha-community.org

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #32 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: GetOverduesForBranch Please add a test. You make some fundamental changes here. koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt - <input type="hidden" name="totals[% line.accountlines_id %]" value="[% line.totals %]" /> Not sure. Why do yo remove this line ? New code: + my $accounts = Koha::Account::Lines->search({ borrowernumber => $borrowernumber, }, { order_by => ['accounttype'] }); + my @accounts; + while ( my $account = $accounts->next ) { This does not look very nice. Can we get more confusion on $account, @accounts or $accounts ? Renaming @accounts here might be the least we can do? No blocker on itself. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #31 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8) > Created attachment 68263 [details] [review] > Bug 10021: Drop columns notify_id and notify_level from accountlines > > It appears that has never worked. > Could someone confirm? Did you have any response whatsoever ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #30 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- FAIL C4/Members.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL C4/Overdues.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 No reason to immediately move this to FQA ! When you remove a sub from a module without full coverage, this is the result. Something for QA tools ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl Severity|normal |enhancement --- Comment #29 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Moving this to enh -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '17

02 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 John DeLooper <jdelooper(a)hccc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdelooper(a)hccc.edu --- Comment #12 from John DeLooper <jdelooper(a)hccc.edu> --- I too would love to see this kind of feature added, and am glad to see patches in progress. I think a process for merging creates a smoother experience than the current looking up duplicates and choosing which one to delete. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '17

02 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Patch rebased and rewritten, please test. Srdjan's concern is not valid IMO. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '17

02 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19087|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 68898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68898&action=ed… Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off Test Plan: 1) Apply patch 2) Turn off AllowOnShelfHolds 3) Create a bib with one item, mark the item as 'on order' 4) Attempt to place a hold on the item, you should now be able to do so -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '17

02 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 18321] New: One more checkouts possible than allowed by rules
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '17

02 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 Bug ID: 18321 Summary: One more checkouts possible than allowed by rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com It is possible to have one more checkouts than allowed by rules. To recreate: - Delete all rules in 'Circulation rules and fines'. - Set a Default limit by patron category, e.g. Student 2 current checkouts , 2 on-site-chekouts. - Checkout to a student until the limit is reached (in this case: 2) - Try a 3rd checkout; it is possible (should not) - Try a 4th checkout: No longer possible. Message says: "Too many checked out. 3 checked out, only 2 are allowed." Expected: Message should trigger with 3rd checkout, saying: "Too many checked out. 2 checked out, only 2 are allowed." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 33

[Bug 14045] Add specific quotas to on-site checkout
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '17

02 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18357 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 [Bug 18357] On-site checkouts issues with 'Unlimited' -- You are receiving this mail because: You are watching all bug changes.

1 0