November 2017 - Koha-bugs - lists.koha-community.org

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '17

01 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #172 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 68886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68886&action=ed… Bug 7317: (QA followup) Get rid of warnings from the tests Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '17

01 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68878|0 |1 is obsolete| | --- Comment #171 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 68885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68885&action=ed… Bug 7317: Handle backend absense more gracefuly 5/ This patch is WIP, it makes Koha::Illrequest->load_backend raise an exception if the passed backend is invalid. This way we will catch more errors introduced. The patch also disables the 'New Ill request' when no backends are available. Gets rid of a related warning. TODO: Should add a noticeable warning on the UI, or a tooltip on the button. TODO: add a couple tests for the exception 4/ This patch fixes the path for the checkboxes jquery plugin, and removes the include for tablesorter, as this implementation uses Datatables. This is obviously code for older Koha, ported to master. 3/ I know it doesn't look right, but am not sure how to display. This is the usual empty datatable display we have everywhere in Koha. 2/ We could fix it with a proper IDE, I use Komodo and refactoring code is pretty straigh-forward. Worth a separate bug report. 1/ That TODO is misleading. It refers to their own migration from a different design. I checked this code and cannot find occurences of ->status with that annotation. I think this relates to backends code. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16746] New: Can not find duplicated authorities cataloguing a new one
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '17

01 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 Bug ID: 16746 Summary: Can not find duplicated authorities cataloguing a new one Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: juan.sieira(a)xercode.es QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Can not find duplicated authorities cataloguing a new one, due to the new version of SimpleSearch -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 19123] New: Remove/fix reference to latest release
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '17

01 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19123 Bug ID: 19123 Summary: Remove/fix reference to latest release Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Release tools Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de The current template of the release notes includes: http://git.koha-community.org/gitweb/?p=release-tools.git;a=blob;f=template… The last Koha release was [% lastrelease %], which was released on [% lastreleasedate %]. [% END %] This has never appeared to work correctly for me, but maybe I am not understanding how this should work. I think maybe it should show: - the last release of the branch the release notes are for - the last release of latest release (to maybe show the user that he is running an old version?) But it appears to do neither. -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '17

01 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #377 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 18374] New: Respect QueryAutoTruncate syspref in Elasticsearch
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '17

01 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Bug ID: 18374 Summary: Respect QueryAutoTruncate syspref in Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Currently in Elasticsearch a search for 'shakes' will not match 'shakespeare' but you cna force it with 'shakes*' This patchset will obey the QueryAutoTruncate to add '*' to all search terms -- You are receiving this mail because: You are watching all bug changes.

1 40

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '17

01 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19284] New: Correct version numbering by adding missing zeros
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '17

01 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19284 Bug ID: 19284 Summary: Correct version numbering by adding missing zeros Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Release tools Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de The release notes will generate the versions as - 16.11.1 - 16.11.2 ... Release maintainers have fixed those manually, but it would be nice if the release notes generated them correctly according to our used schema as: - 16.11.01 - 16.11.02 ... -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '17

01 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #170 from Magnus Enger <magnus(a)libriotech.no> --- Trying to summarize the status of this bug now. *** QA script ** POD coverage Some FAILS are "POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666". It sounds like these can be ignored. ** Atomicupdate FAIL installer/data/mysql/atomicupdate/ill_tables.sql FAIL git manipulation The file has been added and deleted in the same patchset Alex provided ill_tables.sql. Tomas rewrote it as bug_7317_ill.perl. Not sure there is anything to fix here? ** tt_valid FAIL koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt OK forbidden patterns OK git manipulation OK spelling FAIL tt_valid lines 665 FAIL valid_template : not found TT is used to set some HTML attributes. Not sure if this can be fixed. Tomas? *** (In reply to Jonathan Druart from comment #164) > 1/ > +TODO: > + > +- Anything invoking the ->status method; annotated with: > + + # Old use of ->status ! > > What do it mean? OK, according to Tomas. > 2/ I will not make you rewrite everything, but it would have been better to > stay consistent and not mix snake_case and camelCase for method names. OK > First steps with the GUI: > 3/ This is what I see when I enable the module: > https://screenshots.firefox.com/z9dNoRL91NQ5F3cD/pro.kohadev.org > Looks wrong. Not sure if this can be fixed? > 4/ Hit /cgi-bin/koha/ill/ill-requests.pl and got: > Loading failed for the <script> with source > “http://pro.kohadev.org/intranet-tmpl/prog/en/lib/jquery/plugins/jquery. > tablesorter.min.js”. ill-requests.pl:151 > Loading failed for the <script> with source > “http://pro.kohadev.org/intranet-tmpl/prog/en/lib/jquery/plugins/jquery. > checkboxes.min.js”. ill-requests.pl:152 OK. Fixed by Tomas > 5/ Clicked "New ILL request" button and got: > Can't locate Koha/Illbackends//Base.pm OK. Fixed by Tomas. But it sounds like Tomas will be working a bit more on related things. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '17

01 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68874|0 |1 is obsolete| | --- Comment #169 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68878&action=ed… Bug 7317: Handle backend absense more gracefuly 5/ This patch is WIP, it makes Koha::Illrequest->load_backend raise an exception if the passed backend is invalid. This way we will catch more errors introduced. The patch also disables the 'New Ill request' when no backends are available. Gets rid of a related warning. TODO: Should add a noticeable warning on the UI, or a tooltip on the button. TODO: add a couple tests for the exception 4/ This patch fixes the path for the checkboxes jquery plugin, and removes the include for tablesorter, as this implementation uses Datatables. This is obviously code for older Koha, ported to master. 3/ I know it doesn't look right, but am not sure how to display. This is the usual empty datatable display we have everywhere in Koha. 2/ We could fix it with a proper IDE, I use Komodo and refactoring code is pretty straigh-forward. Worth a separate bug report. 1/ That TODO is misleading. It refers to their own migration from a different design. I checked this code and cannot find occurences of ->status with that annotation. I think this relates to backends code. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0