February 2017 - Koha-bugs - lists.koha-community.org

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #23 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60604&action=ed… Bug 9988: Refactor the cron script The cron job is moved from migration tools to cronjobs. And renamed to a plural form. The script is now based on Koha objects. It does no longer include the code to merge one record. This can be done via the interface, and will be added to a maintenance script on bug 18071. Should not be part of this cron job. Adding a cron_cleanup method to MergeRequests; this method is called from the cron script to reset older entries still marked in progress and to also remove old processed entries. Tested in a separate unit test. Test plan: [1] Run t/db_dependent/Authorities/MergeRequests.t [2] Set AuthorityMergeLimit to 0. (All merges are postponed.) [3] Modify an authority linked to a few records. [4] Delete an authority linked to a few records with batch delete tool. [5] And select two auth records with linked records. Merge these two records with authority/merge.pl. Note: Do not select Default. See also bug 17380. [6] Check the need_merge_authorities table for inserted records. [7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked records and the record status in need_merge_authorities. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #22 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60603&action=ed… Bug 9988: Remove further references to dontmerge [1] The preference was sent to HEA. We can now send both AuthorityMergeMode as well as AuthorityMergeLimit. [2] A comment in authorities/merge.pl is removed. Note that a subsequent patch will modify and test the cron job. [3] Script misc/batchRebuildItemsTables.pl temporarily enabled dontmerge. This is equivalent to setting the mergelimit to zero. The function defnonull is no longer needed. (If the pref was NULL, we restore that value. Sub merge won't mind.) Test plan: [1] Run t/db_dependent/UsageStats.t [2] Run misc/batchRebuildItemsTables.pl -t This just ensures you it still compiles; the changes speak for itself. [3] Now git grep on dontmerge. You should only find hits in atomicupdate and misc/translator/po. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #21 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60602&action=ed… Bug 9988: Check the merge limit in sub merge At this point, we are replacing dontmerge functionality by the new AuthorityMergeLimit logic. Instead of doing this check before calling merge, we just call merge and check it there. In order to let the cron job do the larger (postponed) merges, we add a parameter override_limit. A subtest is added in Merge.t to test the 'postponed merge' feature. Since merge now also calls get_usage_count, an additional mock is added. All references to dontmerge are removed. In merge two lines, initializing $dbh and $counteditbiblios, are moved. The dontmerge test in DelAuthority and ModAuthority is removed. Since this did not leave much in ModAuthority, I fixed the whitespace on the remaining lines rightaway (yes, I know). A minimal set of changes is applied to the cron script; it will get further attention on a next patch. Test plan: [1] Run Merge.t [2] Set AuthorityMergeLimit to 2. Modify an authority with two linked biblios. Check that the merge was done immediately. [3] Now modify an authority with more than 2 linked records. Verify that the merge was postponed; a record must be inserted in the need_merge_authorities table. [4] Testing of the merge cron job is *postponed* to a next patch. Note: I tested a modification, but the script just needs more attention. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #20 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60601&action=ed… Bug 9988: Remove the Zebra code from sub merge Since we can now call linked_biblionumbers, we can now remove all Zebra related code from merge. We also add a parameter biblionumbers; we use it in the test now, but it may be handy too later in the maintenance script when we want to trigger a merge for specific biblionumber(s). See bug report 18071. All mocks for ZOOM, Context::Zconn, Search::new_record_for_zebra in the merge test can now be replaced by one mock for linked_biblionumbers. Note that we test the biblionumbers parameter in the last subtest without that mock. Remove unused vars $countunmodifiedbiblio, $counterrors from merge. Renamed zebrarecords to linkedrecords in the Merge test. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Modify an authority record. Check the linked biblio records. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #19 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60600&action=ed… Bug 9988: Merge should have a parameter hash We will need a few additional parameters for merge later on. This patch puts the original parameters in a parameter hash. Test plan: [1] Run Merge.t [2] Merge two authorities in the Authorities module Note: I also tested script merge_authority.pl with -b parameter. This script will still need further attention. I manually deleted an authority record, inserted a record in need_merge_authorities, and ran the script with -b while adding -f and -t with an existing authority number. This record number is ignored in batch mode. The biblio record with the deleted authority was correctly cleaned up. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60599&action=ed… Bug 9988: Add get_usage_count and linked_biblionumbers to Koha::Authority When replacing the Zebra code in sub merge, we actually need CountUsage as well as the results it gets from SearchEngine. In order to get count and/or results, we now create: [1] instance methods get_usage_count and linked_biblionumbers in Koha::Authority, [2] class methods of the same name in Koha::Authorities. The instance method calls the class method. The class method can be used for deleted authority records, and in 'legacy calls' before refactoring. Note: On BZ 18149 we will replace all CountUsage calls. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #17 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60598&action=ed… Bug 9988: Add extract_biblionumber to Koha/SearchEngine When we will replace the Zebra code in sub merge, we will call SearchEngine to pass records and we need a routine to extract a biblionumber from a search result record. A record from Zebra still must be converted to MARC::Record. This is no longer needed for a ElasticSearch record. Test plan: Run t/db_dependent/Koha/SearchEngine/Search.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #16 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60597&action=ed… Bug 9988: Add Koha objects for table need_merge_authorities This patch adds two Koha objects: MergeRequest(s). MergeRequest has a new method and an oldmarc method. A class method reporting_tag_xml is added to MergeRequests.pm. All new routines are tested in Authorities.t. Removes a few unneeded modules from Koha::Authority. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #15 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60596&action=ed… Bug 9988: DBIx schema changes for need_merge_authorities As generated by misc/devel/update_dbix_class_files.pl. No test plan. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60595&action=ed… Bug 9988: Table revision for need_merge_authorities In order to let merge do exactly the same when called from the merge cron job, we need three additional fields in the table. The use of these fields will be explained in a follow-up. Test plan: Run the dbrev (updatestructure step in webinstaller). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Also tested running kohastructure.sql for this table. -- You are receiving this mail because: You are watching all bug changes.

1 0