February 2017 - Koha-bugs - lists.koha-community.org

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #59 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Thanks! That helps a lot! (In reply to Jonathan Druart from comment #57) > Kyle, > > I did not write the different failures because most of them are obvious: > > 1. There are no tests > 2. CamelCase instead of snake_case for methods of Koha::Clubs and > Koha::Patron > 3. GetClubEnrollmentsCount and GetEnrollableClubsCount are not needed, just > call ->count > 4. You should not need to add GetBranches to the Branches TT plugin. Take a > look at options_for_libraries > 5. Subroutine added to Koha TT plugin (UserEnv), but not used. > 6. Changes to circ/circulation.pl are not needed. A variable 'patron' is > already passed to the template. > 7. All the labels of the form has the same value for the "for" attribute. > 8. Tables on clubs/clubs.pl are ugly (missing datatables.css?) > 9. On /clubs/clubs-add-modify.pl?club_template_id=1, there is an empty input > at the end of the form. > 8. CGI->param must not be called in scalar context > 9. When I save a form, I get "Your club was created" with a link to "Return > to patron clubs". That sounds weird. Especially because the box is yellow. > I'd suggest to behave as everywhere else in Koha: Save and get the list. > I guess it's because there are too many small scripts, maybe it would have > been easier to have a bigger one and have the different action handled in it > (as everywhere else in admin scripts). > 10. INSERT statements should have IGNORE in update db process > 11. + `branchcode` varchar(10) COLLATE utf8_unicode_ci NULL DEFAULT NULL, > you should not need to specify the COLLATE here. > 12. QA tests do not pass > FAIL Koha/Patron.pm > FAIL forbidden patterns > forbidden pattern: merge marker (>>>>>>>) (line 647) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #42 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Owen Leonard from comment #39) > Does this feature make it inaccurate to label the "Relatives' checkouts" tab > as such? "Guarantees' checkouts" perhaps? I think we us the term colloquially but I've not problem switching our language to guarantees to be technically correct :) I think we should do that on a separate bug since it affects other parts of Koha not in the purview of this bug patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14695] Add ability to place multiple item holds on a given record per patron
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #240 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #235) > Messages: If you go over the number of holds per record, the message is: No > items available. Which is/may be untrue. Why not: you reached the max ? Good thought Marcel. File a bug report for that and ping me about it :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11580] returnBeforeExpiry and closed day
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Baptiste, I think all three options should have a specific behaviour for calculating due dates when the patron _doesn't_ expire before the calculated due date: - ... the calendar to push the due date to the next open day - ... the calendar to sktip all closed days - ... circulation rules only (ignore the calendar altogether) But when you use ReturnExpiry to shorten the due date and it's before the calculated due date I think you are right that the behaviour of the first 2 will be the same. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11580] returnBeforeExpiry and closed day
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Baptiste <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #5 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- I take it to add the tests, but I don't understand why there are 3 options for UseDaysModes despite 2 of them have exactly the same behaviour in all function in which they are called, shouldn't we delete the "caleandar", which doesn't have the specified behaviour ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Pasi, is this still on your todo list or would it be ok to reset the Assignee? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Baptiste <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #58 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- When I hit /circ/circulation.pl?borrowernumber=42, I get a software error: Template process failed: undef error - The method category_type is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. Yes I think another signoff is needed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15108] OAI-PMH provider improvements
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com Status|Signed Off |Failed QA --- Comment #82 from Julian Maurice <julian.maurice(a)biblibre.com> --- The tests fail for me: 1. If I have data in the issues table I get an error : > DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key > constraint fails (`koha`.`issues`, CONSTRAINT `issues_ib fk_2` FOREIGN KEY > (`itemnumber`) REFERENCES `items` (`itemnumber`) ON UPDATE CASCADE) [for > Statement "DELETE FROM biblio"] at t/db_dependent/OAI/Server.t line 62. This can be easily fixed by deleting all issues before deleting all biblios 2. Biblio records are MARC21 (245$a for the title), so, as a UNIMARC user I get nothing in dc:title (tests "ListRecords oai_dc ..."). 3. I don't know if this one is related to MARC21/UNIMARC but I also get nothing in dc:language (hashref expected) (tests "ListRecords oai_dc ...") Result of prove here: http://paste.koha-community.org/325 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #57 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Kyle, I did not write the different failures because most of them are obvious: 1. There are no tests 2. CamelCase instead of snake_case for methods of Koha::Clubs and Koha::Patron 3. GetClubEnrollmentsCount and GetEnrollableClubsCount are not needed, just call ->count 4. You should not need to add GetBranches to the Branches TT plugin. Take a look at options_for_libraries 5. Subroutine added to Koha TT plugin (UserEnv), but not used. 6. Changes to circ/circulation.pl are not needed. A variable 'patron' is already passed to the template. 7. All the labels of the form has the same value for the "for" attribute. 8. Tables on clubs/clubs.pl are ugly (missing datatables.css?) 9. On /clubs/clubs-add-modify.pl?club_template_id=1, there is an empty input at the end of the form. 8. CGI->param must not be called in scalar context 9. When I save a form, I get "Your club was created" with a link to "Return to patron clubs". That sounds weird. Especially because the box is yellow. I'd suggest to behave as everywhere else in Koha: Save and get the list. I guess it's because there are too many small scripts, maybe it would have been easier to have a bigger one and have the different action handled in it (as everywhere else in admin scripts). 10. INSERT statements should have IGNORE in update db process 11. + `branchcode` varchar(10) COLLATE utf8_unicode_ci NULL DEFAULT NULL, you should not need to specify the COLLATE here. 12. QA tests do not pass FAIL Koha/Patron.pm FAIL forbidden patterns forbidden pattern: merge marker (>>>>>>>) (line 647) -- You are receiving this mail because: You are watching all bug changes.

1 0