February 2017 - Koha-bugs - lists.koha-community.org

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #13 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60594&action=ed… Bug 9988: Database revision for AuthorityMergeLimit Introduce the new preference and remove dontmerge. If dontmerge was enabled, the new pref will be set to zero and we will print a message about raising this value now. Test plan: Run the database revision or a new install. In case of an upgrade, check the new pref value. Should be 0 when dontmerge was enabled, otherwise 50. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Also tested sysprefs.sql on a new database. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15108] OAI-PMH provider improvements
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #84 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Ere Maijala from comment #83) > Marcel: Was there a reason for removing the deletion of issues in your patch > in Bug 17493? > > I suppose the issue with UNIMARC is that the OAI-PMH provider does take it > into account while the test doesn't. > > I'll see if I can fix these issues with a follow-up patch to the test. Not sure anymore (seen too much code in the meantime). Guess it was not needed.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60259|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60258|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60257|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60256|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15108] OAI-PMH provider improvements
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #83 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Marcel: Was there a reason for removing the deletion of issues in your patch in Bug 17493? I suppose the issue with UNIMARC is that the OAI-PMH provider does take it into account while the test doesn't. I'll see if I can fix these issues with a follow-up patch to the test. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #59 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Thanks! That helps a lot! (In reply to Jonathan Druart from comment #57) > Kyle, > > I did not write the different failures because most of them are obvious: > > 1. There are no tests > 2. CamelCase instead of snake_case for methods of Koha::Clubs and > Koha::Patron > 3. GetClubEnrollmentsCount and GetEnrollableClubsCount are not needed, just > call ->count > 4. You should not need to add GetBranches to the Branches TT plugin. Take a > look at options_for_libraries > 5. Subroutine added to Koha TT plugin (UserEnv), but not used. > 6. Changes to circ/circulation.pl are not needed. A variable 'patron' is > already passed to the template. > 7. All the labels of the form has the same value for the "for" attribute. > 8. Tables on clubs/clubs.pl are ugly (missing datatables.css?) > 9. On /clubs/clubs-add-modify.pl?club_template_id=1, there is an empty input > at the end of the form. > 8. CGI->param must not be called in scalar context > 9. When I save a form, I get "Your club was created" with a link to "Return > to patron clubs". That sounds weird. Especially because the box is yellow. > I'd suggest to behave as everywhere else in Koha: Save and get the list. > I guess it's because there are too many small scripts, maybe it would have > been easier to have a bigger one and have the different action handled in it > (as everywhere else in admin scripts). > 10. INSERT statements should have IGNORE in update db process > 11. + `branchcode` varchar(10) COLLATE utf8_unicode_ci NULL DEFAULT NULL, > you should not need to specify the COLLATE here. > 12. QA tests do not pass > FAIL Koha/Patron.pm > FAIL forbidden patterns > forbidden pattern: merge marker (>>>>>>>) (line 647) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #42 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Owen Leonard from comment #39) > Does this feature make it inaccurate to label the "Relatives' checkouts" tab > as such? "Guarantees' checkouts" perhaps? I think we us the term colloquially but I've not problem switching our language to guarantees to be technically correct :) I think we should do that on a separate bug since it affects other parts of Koha not in the purview of this bug patch. -- You are receiving this mail because: You are watching all bug changes.

1 0