February 2017 - Koha-bugs - lists.koha-community.org

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60386|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60412&action=ed… Bug 15498: Add ExportCircHistory and remove ExportWithCsvProfile Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60385|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60411&action=ed… Bug 15498: Let the user choose the CSV profile to export circ history The way the export options are displayed at the bottom of the checkouts table was not consistent. Prior to this patch set, they are display if ExportRemoveFields or ExportWithCsvProfile is set. It does not make any sense, the user could want to export the checkouts in iso2709 format without having to define a csv profile and fill the pref. Moreover the behavior of this pref did not match its description: it's used as a default CSV profile when exporting records from the export tools or the command line. This patch set adds a new pref ExportCircHistory and remove ExportWithCsvProfile. The new pref is set if ExportWithCsvProfile or ExportRemoveFields were set. A new dropdown list with the CSV profile list will be displayed in the export area, at the bottom of the checkouts table. Note that now --csv_profile_id is mandatory for the export command line (misc/export_records.pl) if the export format is csv. Test plan: 0/ Do not execute the DB entry 1/ Clear both ExportWithCsvProfile and ExportRemoveFields prefs 2/ Execute the DB entry 3/ ExportCircHistory should not be set and the export options should not be displayed at the bottom of the checkouts table. 4/ Remove the pref DELETE FROM systempreferences WHERE variable='ExportCircHistory'; and reinsert the previous one, with a value: INSERT INTO systempreferences (variable, value) VALUES ('ExportWithCsvProfile', 'something'); Execute the DB entry again => The now pref should be now set 5/ Export some checkouts using the CSV entry 6/ Note that the export tool and commandline script still work using the csv format. You have to provide a --csv_profile_id option to make it work. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5784] link to acq from budgets & funds
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 --- Comment #14 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 60410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60410&action=ed… Bug 5784 - Undo link in breadcrumbs Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5784] link to acq from budgets & funds
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5784] link to acq from budgets & funds
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA Blocks| |17972 --- Comment #13 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Issue resolved by 17972. Pushing followup to remove link from breadcrumbs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17972 [Bug 17972] Reformat acquisitions sidebar menu with acquisitions and administration sections -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58149|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60409&action=ed… Bug 14146: Add the new pref CumulativeRestrictionPeriods Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58131|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60408&action=ed… Bug 14146: Clean a bit and make the code understandable The code was a bit weird and this patch cleans it a bit by renaming variables and adding a variable. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58130|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60407&action=ed… Bug 14146: Add the ability to cumulate restriction periods At the moment the default behaviour is not to cumulate the restriction periods but to apply the longest one. This patch set creates a new syspref CumulativeRestrictionPeriods. If on, the behaviour changes and the restriction periods are cumulated: the days of the second restriction are added to the actual restriction period. We could add a new circulation rule instead of a syspref, but I am not sure it's very useful to have such granularity for this behaviour (can be changed if needed). How it works: Let's take 2 items, A and B. A is returned with Na days late, and B Nb days late The grace period is Ng and there is 1 day of suspension charge per day of overdue The suspension period is until day D = Na - Ng + Nb - Ng I would have expected D = Na + Nb - Ng but it's how it worked before this patch. Test plan: Create several overdue for a given patron Do the checkins and confirm that the period are added if the pref is on. If the pref is off, you should not get any changes in the existing behaviour. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

1 0