February 2017 - Koha-bugs - lists.koha-community.org

[Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58129|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60406&action=ed… Bug 14146: Add tests for AddReturn + CumulativeRestrictionPeriods Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14854] Add DataTables on upload results table
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14854 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |nick(a)bywatersolutions.com --- Comment #9 from Nick Clemens <nick(a)bywatersolutions.com> --- Conflict in the tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60389|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Comment on attachment 60389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60389 Bug 15498: [QA Follow-up] Somehow this is useless. Space gets away when committing.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10679] Lists interface offers delete option when user doesn' t have permission
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Instead of looping through the search results of Koha::Virtualshelfcontents->search({ shelfnumber => $self->shelfnumber }) please search for the column borrowernumber too. The algorithm should be something as: if list->count==0 return false if owner return true if delete_own AND delete_other return true (in that case you could delete all) if delete_own AND there are 'own' entries return true (so search here!) if delete_other AND there are 'other' entries (count - countown > 0) then return true Maybe you understand now why I did not write that code :) We should perhaps consider: show the button Remove selected only if you are the owner or allowed to delete all entries. And show a link on the individual entries if this is not the case but you can delete an individual one. Because if you see the button, it could well be that you are only allowed to delete one record out of 20. Which one? So you would need a routine can_biblio_be_removed (singular) Or simplify the permissions: Add/Delete on owner level (or staff member, moderator?) and Add/Delete for other users. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14764] Add OPAC News branch selector
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Baptiste <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14764] Add OPAC News branch selector
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #43 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 60396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60396&action=ed… [SIGNED OFF] Bug 14764 - [followup] Addressing QA concerns * removed Policy: * put the syspref in alpha order with the others * added els to the if. Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #18) > QA Comment: > It would have been helpful if I had a more clear description of what this > patch set wants to accomplish. Sorry, I thought everything was clear enough. > [1] Going through the code changes, you remove ExportWithCsvProfile and you > add ExportCircHistory. You also touch ExportRemoveFields. ExportRemoveFields > is still found in > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref. > But it is not in sysprefs.sql. Still in use in tools/export.pl. But I would > also expect these fields to pop up at the circulation screen in the Dont > export fields box. It's a bug from master, opened bug 18136. > [2] I do not see the combo (select name="csv_profile_id"). I guess it is > hidden by js in checkouts.js. But also if I select csv, it does not show up. > Refreshed, restarted, flushed, etc. No results. (I expected a combo with two > csv profiles.) Caused by a changed of the element's id by bug 17394. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #30 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60390&action=ed… Bug 15498: Fix conflict with bug 17394 -- You are receiving this mail because: You are watching all bug changes.

1 0