February 2017 - Koha-bugs - lists.koha-community.org

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #23 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60376&action=ed… Bug 15498: [QA Follow-up] Resolves: forbidden pattern: trailing space char (line 334) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #22 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60375&action=ed… Bug 15498: Fix show/hide csv profile list Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #21 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60374&action=ed… Bug 15498: Do not display sql csv profiles Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #20 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60373&action=ed… Bug 15498: Add ExportCircHistory and remove ExportWithCsvProfile Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #19 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60372&action=ed… Bug 15498: Let the user choose the CSV profile to export circ history The way the export options are displayed at the bottom of the checkouts table was not consistent. Prior to this patch set, they are display if ExportRemoveFields or ExportWithCsvProfile is set. It does not make any sense, the user could want to export the checkouts in iso2709 format without having to define a csv profile and fill the pref. Moreover the behavior of this pref did not match its description: it's used as a default CSV profile when exporting records from the export tools or the command line. This patch set adds a new pref ExportCircHistory and remove ExportWithCsvProfile. The new pref is set if ExportWithCsvProfile or ExportRemoveFields were set. A new dropdown list with the CSV profile list will be displayed in the export area, at the bottom of the checkouts table. Note that now --csv_profile_id is mandatory for the export command line (misc/export_records.pl) if the export format is csv. Test plan: 0/ Do not execute the DB entry 1/ Clear both ExportWithCsvProfile and ExportRemoveFields prefs 2/ Execute the DB entry 3/ ExportCircHistory should not be set and the export options should not be displayed at the bottom of the checkouts table. 4/ Remove the pref DELETE FROM systempreferences WHERE variable='ExportCircHistory'; and reinsert the previous one, with a value: INSERT INTO systempreferences (variable, value) VALUES ('ExportWithCsvProfile', 'something'); Execute the DB entry again => The now pref should be now set 5/ Export some checkouts using the CSV entry 6/ Note that the export tool and commandline script still work using the csv format. You have to provide a --csv_profile_id option to make it work. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: It would have been helpful if I had a more clear description of what this patch set wants to accomplish. [1] Going through the code changes, you remove ExportWithCsvProfile and you add ExportCircHistory. You also touch ExportRemoveFields. ExportRemoveFields is still found in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref. But it is not in sysprefs.sql. Still in use in tools/export.pl. But I would also expect these fields to pop up at the circulation screen in the Dont export fields box. [2] I do not see the combo (select name="csv_profile_id"). I guess it is hidden by js in checkouts.js. But also if I select csv, it does not show up. Refreshed, restarted, flushed, etc. No results. (I expected a combo with two csv profiles.) Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10679] Lists interface offers delete option when user doesn' t have permission
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679 --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- We're not there yet. But we will! Will submit a more detailed comment later. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10978] redirect to basket list of a supplier after deleting a basket
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10978] redirect to basket list of a supplier after deleting a basket
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60365|0 |1 is obsolete| | --- Comment #8 from Marc Véron <veron(a)veron.ch> --- Created attachment 60371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60371&action=ed… Bug 10978: Redirect to basket list of a supplier after deleting a basket This patch redirects to the vendor's list of baskets after deleting a basket, fixes breadcrumbs after deletion and also hides the toolbar actions after deletion (seeing as you can't edit/export etc a basket that no longer exists). To test: 1) Go to Acquisitions -> find a vendor -> view a basket or create a new basket 2) Delete the basket. Notice you are taken to a list of all vendors and baskets 3) Apply patch and do step 1 again 4) Delete the basket. Notice appropriate breadcrumbs, no toolbar, and confirm link to return to baskets for the vendor works. Sponsored-by: Catalyst IT Followed test plan, works as expected (links to vendor's baskets and all baskets) Signed-off-by: Marc Véron <veron(a)veron.ch> Re-tested. Wording of buttons "Show baskets for vendor..." and "Show all active baskets" makes sense. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0