February 2017 - Koha-bugs - lists.koha-community.org

[Bug 14764] Add OPAC News branch selector
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #43 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 60396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60396&action=ed… [SIGNED OFF] Bug 14764 - [followup] Addressing QA concerns * removed Policy: * put the syspref in alpha order with the others * added els to the if. Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #18) > QA Comment: > It would have been helpful if I had a more clear description of what this > patch set wants to accomplish. Sorry, I thought everything was clear enough. > [1] Going through the code changes, you remove ExportWithCsvProfile and you > add ExportCircHistory. You also touch ExportRemoveFields. ExportRemoveFields > is still found in > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref. > But it is not in sysprefs.sql. Still in use in tools/export.pl. But I would > also expect these fields to pop up at the circulation screen in the Dont > export fields box. It's a bug from master, opened bug 18136. > [2] I do not see the combo (select name="csv_profile_id"). I guess it is > hidden by js in checkouts.js. But also if I select csv, it does not show up. > Refreshed, restarted, flushed, etc. No results. (I expected a combo with two > csv profiles.) Caused by a changed of the element's id by bug 17394. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #30 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60390&action=ed… Bug 15498: Fix conflict with bug 17394 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #29 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60389&action=ed… Bug 15498: [QA Follow-up] Resolves: forbidden pattern: trailing space char (line 334) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #28 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60388&action=ed… Bug 15498: Fix show/hide csv profile list Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60387&action=ed… Bug 15498: Do not display sql csv profiles Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60386&action=ed… Bug 15498: Add ExportCircHistory and remove ExportWithCsvProfile Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57072|0 |1 is obsolete| | Attachment #57073|0 |1 is obsolete| | Attachment #57074|0 |1 is obsolete| | Attachment #57075|0 |1 is obsolete| | Attachment #60372|0 |1 is obsolete| | Attachment #60373|0 |1 is obsolete| | Attachment #60374|0 |1 is obsolete| | Attachment #60375|0 |1 is obsolete| | Attachment #60376|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60385&action=ed… Bug 15498: Let the user choose the CSV profile to export circ history The way the export options are displayed at the bottom of the checkouts table was not consistent. Prior to this patch set, they are display if ExportRemoveFields or ExportWithCsvProfile is set. It does not make any sense, the user could want to export the checkouts in iso2709 format without having to define a csv profile and fill the pref. Moreover the behavior of this pref did not match its description: it's used as a default CSV profile when exporting records from the export tools or the command line. This patch set adds a new pref ExportCircHistory and remove ExportWithCsvProfile. The new pref is set if ExportWithCsvProfile or ExportRemoveFields were set. A new dropdown list with the CSV profile list will be displayed in the export area, at the bottom of the checkouts table. Note that now --csv_profile_id is mandatory for the export command line (misc/export_records.pl) if the export format is csv. Test plan: 0/ Do not execute the DB entry 1/ Clear both ExportWithCsvProfile and ExportRemoveFields prefs 2/ Execute the DB entry 3/ ExportCircHistory should not be set and the export options should not be displayed at the bottom of the checkouts table. 4/ Remove the pref DELETE FROM systempreferences WHERE variable='ExportCircHistory'; and reinsert the previous one, with a value: INSERT INTO systempreferences (variable, value) VALUES ('ExportWithCsvProfile', 'something'); Execute the DB entry again => The now pref should be now set 5/ Export some checkouts using the CSV entry 6/ Note that the export tool and commandline script still work using the csv format. You have to provide a --csv_profile_id option to make it work. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '17

17 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0