February 2017 - Koha-bugs - lists.koha-community.org

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59783|0 |1 is obsolete| | --- Comment #72 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 59800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59800&action=ed… Bug 14224: Remove SQL query in svc script Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59782|0 |1 is obsolete| | --- Comment #71 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 59799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59799&action=ed… Bug 14224: Reintroduce previous copyright Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59781|0 |1 is obsolete| | --- Comment #70 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 59798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59798&action=ed… Bug 14224: Do not reintroduce GetItemIssue, it's dying Bug 17680 is removing it. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #69 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Josef Moravec from comment #66) > (In reply to Jonathan Druart from comment #55) > > Created attachment 59780 [details] [review] [review] > > Bug 14224: Check if the columns do not exist before creating them > > > > Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> > > Probably better to ommit "IGNORE" when using column_exists function, what do > you think? Yes definitely, especially because bug 17234. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59780|0 |1 is obsolete| | --- Comment #68 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 59796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59796&action=ed… Bug 14224: Check if the columns do not exist before creating them Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #50 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 59795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59795&action=ed… Bug 15030: Add tests This test will prevent regression on the lost of data when items.itemcallnumber is linked with a plugin. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #49 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 59794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59794&action=ed… Bug 15030 - continue. The enumchron value was overwritten by 'header' even when value supplied Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #48 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 59793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59793&action=ed… Bug 15030 - Fixes the serials fields associated with a plugin, to not overwrite the previously saved value This fixes the remaining fields from serials-edit.pl that were seeing their previously entered values be oblitarated with each new edit. The fields associated to a plugin (dateaccessioned and barcode) were always displaying <empty> with each new edit, losing the previous effort. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #47 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 59792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59792&action=ed… Bug 15030 - Certain values in serials' items are lost on next edit When editing serials subscription, we can edit them but some values are not pulled from the DB correctly to be put in the edit box. If not noticed, the value will be overwritten on the next save. Test: - Create a subscription - Edit itemcallnumber (952o?) and make sure to have a different value than the default one. - Save. - Edit it again - The saved value is not there. This is true for itemcallnumber and a few other fields. This was caused by calls to ->field($subfield). This would always fail, of course. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0