May 2017 - Koha-bugs - lists.koha-community.org

[Bug 15246] Adding new patron triggers foreign key error if branchcode is hidden
by bugzilla-daemon＠bugs.koha-community.org 09 May '17

09 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15246 Michael Kuhn <mik(a)adminkuhn.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik(a)adminkuhn.ch --- Comment #3 from Michael Kuhn <mik(a)adminkuhn.ch> --- Under the described circumstances (Koha system preference "BorrowerUnwantedField" containing "branchcode") almost the same problem occurrs when trying to add new patrons. In this case: 1. Environment: Debian GNU/Linux 8 with Koha 16.11.04 and Plack activated. 2. Trying to add a new patron using the staff client will result in the URL ".../cgi-bin/koha/members/memberentry.pl" showing just a white page saying "Internal Server error". 3. The log file "plack-error.log" will show the following error (just as an example): DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_phsh`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "INSERT INTO `borrowers` ( `address`, `address2`, `altcontactaddress1`, `altcontactaddress2`, `altcontactaddress3`, `altcontactcountry`, `altcontactfirstname`, `altcontactphone`, `altcontactstate`, `altcontactsurname`, `altcontactzipcode`, `borrowernotes`, `cardnumber`, `categorycode`, `city`, `contactnote`, `country`, `dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `email`, `emailpro`, `firstname`, `mobile`, `opacnote`, `othernames`, `password`, `phone`, `phonepro`, `privacy`, `privacy_guarantor_checkouts`, `sex`, `sms_provider_id`, `sort1`, `sort2`, `state`, `streetnumber`, `surname`, `title`, `userid`, `zipcode`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="", 1="", 2="", 3="", 4="", 5="", 6="", 7="", 8="", 9="", 10="", 11="", 12="11111111111", 13="13", 14="", 15="", 16="", 17='2017-05-09', 18='2100-08-09T00:00:00', 19=undef, 20=undef, 21="", 22="", 23="", 24="", 25="", 26="", 27='!', 28="", 29="", 30=0, 31=0, 32="", 33=undef, 34="", 35="", 36="", 37="", 38="XXXX", 39="", 40='xxxx', 41=""] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a foreign key constraint fails (`koha_phsh`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) at /usr/share/koha/lib/Koha/Object.pm line 120 4. The problem can be solved by removing "branchcode" from Koha system preference "BorrowerUnwantedField". 5. As Laura has suggested it may be a good idea to add a hint to the preference "BorrowerUnwantedField" concerning field "branchcode" - so most people wouldn't even try to include it. Or, as Owen Leonard has suggested, to automatically select the logged-in branch for new patrons; even if the field "branchcode" is hidden; although this may not always be the correct choice, if the library has more than one branch. So maybe it would be safest to just forbid adding the mandatory field "branchcode" to Koha system preference "BorrowerUnwantedField". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14803] Rental and fine fees are not updating on circulation screen
by bugzilla-daemon＠bugs.koha-community.org 09 May '17

09 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #32 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Srdjan Jankovic from comment #31) > (In reply to Josef Moravec from comment #29) > > Hi Josef, thanks for testing this. > > > I have to more concerns about it: > > 1) The barcode field doesn't have focus after page is loaded - probably easy > > to fix, but important > > 2) Looks like it waits than issues are loaded and then show the barcode > > input field, maybe I am wrong and it just looks like, but in any case it is > > much slower then current master... > > Ok, now it should be behaving like master. I tried to add some accuracy, but > drawbacks are obviously too big... It is Ok now, thanks > > 3) Message "loading, you can continue scanning" is badly placed (in the left > > top corner) > > For me it is placed center of the table. At any rate I believe my patch did > not change the table, it just makes a issuesTable.api().ajax.reload() call. > Could you please a) check it in another browser b) compare to master. Thanks > a lot. Hm, strange... On master it's ok for me, on this patchset still bad... but I can't find out where's the problem... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 09 May '17

09 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com Status|Needs Signoff |Failed QA --- Comment #88 from Josef Moravec <josef.moravec(a)gmail.com> --- I found some issues with this patchset: 1) It removes field overdrive_auth_token field from tables borrowers and deletedborrowers 2) Automic update and kohastructure has to be consistent in field order, in atomic, the new field is added after 'privacy', in kohastructure at the end - it is bad -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.
by bugzilla-daemon＠bugs.koha-community.org 09 May '17

09 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #24 from Peggy Thrasher <p.thrasher(a)dover.nh.gov> --- I would certainly support a patch that solves the semi-colon problem even if the other issues are not resolved. If we could make the system work correctly when the MARC record follows the standard that would be a big improvement. Thanks Peggy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 09 May '17

09 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle(a)bywatersolutions.com --- Comment #87 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 17.05, thanks Alex, Marcel! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable.
by bugzilla-daemon＠bugs.koha-community.org 09 May '17

09 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 --- Comment #16 from alfre69 <alfre(a)ibdinternet.com> --- (In reply to Barton Chittenden from comment #13) > (In reply to alfre69 from comment #9) > > If you increase $max_record_size too much it breaks the Z39.50 server. > > > > A yaz-client search report this: > > > > Target has closed the association. > > Reason: protocolError, message: Incoming package too large > > Does this error occur on *all* searches, or simply searches whose results > are greater than 1 MB? It occurs on all searches, so the Z39.50 server is not usable when increasing $max_record_size. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13995] Proper Exception handling
by bugzilla-daemon＠bugs.koha-community.org 09 May '17

09 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #24 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Olli-Antti Kivilahti from comment #23) > Created attachment 60963 [details] [review] > Bug 13995 - Proper Exception handling Is it ready for testing again? What is the test plan? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 09 May '17

09 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 09 May '17

09 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #101 from Josef Moravec <josef.moravec(a)gmail.com> --- Ok, it was not good solution, now should be better ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 09 May '17

09 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63158|0 |1 is obsolete| | --- Comment #100 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 63279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63279&action=ed… Bug 8612: QA followup - strip white chars from csv profile definition, expand test -- You are receiving this mail because: You are watching all bug changes.

1 0