May 2017 - Koha-bugs - lists.koha-community.org

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Benjamin Daeuber <bdaeuber(a)cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber(a)cityoffargo.com --- Comment #5 from Benjamin Daeuber <bdaeuber(a)cityoffargo.com> --- (In reply to Christopher Brannon from comment #2) > How are fines/fees taken into account with this action? Will associated > fines be removed if claimed returned? Or will they be removed if marked as > found? Will there be a preference for this? I think this covers your first questions: >Add system preference to ask ‘charge’, ‘don’t charge’, or ‘ask for confirmation’ when marking an item claimed returned As to your second, I think we ought to treat it like we do lost items via the system preference RefundLostItemFeeOnReturn Perhaps a system pref: RefundClaimReturnonLocate? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Took a quick look at the code of the patches too: 1) There is an atomicupdate for adding a new permission edit_digital_signs, but no corresponding change to koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc 2) Maybe a merge issue, but sysprefs.sql removes 2 existing system preferences and doesn't add the new ones? 3) There is a comment about YUI - maybe that can just be thrown out? + // prepare DOM for YUI Toolbar 4) the borrow permission is used in opac-signs.pl but has since been removed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer(a)bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- The QA scripts are pointing out some issues with these patches: FAIL installer/data/mysql/atomicupdate/bug_8628-digital-signs-sysprefs.sql OK git manipulation FAIL semicolon simicolon found instead of comma at line 1 simicolon found instead of comma at line 3 simicolon found instead of comma at line 2 OK sysprefs_order FAIL installer/data/mysql/kohastructure.sql FAIL charset_collate The table sign_streams does not have the current charset collate (see bug 11944) The table signs_to_streams does not have the current charset collate (see bug 11944) The table signs does not have the current charset collate (see bug 11944) OK git manipulation OK installer/data/mysql/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order OK koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 407) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 441) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 227) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 86) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 87) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 226) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 442) OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-signs.tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 468) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 561) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 67) forbidden pattern: simple-quote string (line 464) forbidden pattern: simple-quote string (line 448) forbidden pattern: simple-quote string (line 450) forbidden pattern: simple-quote string (line 465) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 462) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 70) forbidden pattern: simple-quote string (line 478) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 69) OK git manipulation FAIL spelling initilize ==> initialize OK tt_valid OK valid_template FAIL opac/opac-signs.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK git manipulation OK pod OK spelling OK valid FAIL tools/signs.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK git manipulation OK pod OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #119 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Katrin Fischer from comment #107) > Looking at this I am wondering if it wouldn't be better to implement the > fallback to the central email address in Koha/Email.pm. It also takes care > of other fallbacks like the reply-to addresses. > It could avoid changes in some of the files and put things in a central spot. I am still confused about having so much duplicated code if we could just override the To => $params->{to} in Koha::Email? What am I missing? Can you please explain why this other approach was taken? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7960] choice to not show the text labels for item types
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Nice one to test! 2 notes: - In order to see some of the changes you need to set item-level_itypes to 'biblio record'. - In the OPAC the 'most popular' page currently displays the biblio level itemtype description. A later patch could make it show the icon and add support for the system preferences. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7960] choice to not show the text labels for item types
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 --- Comment #5 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 62933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62933&action=ed… [SIGNED OFF] Bug 7960: [FOLLOW-UP] Adding to places missed in first patch This patch adds the use of the syspref to: = STAFF CLIENT = - catalogue/advsearch.tt - catalogue/detail.tt - catalogue/results.tt - reserve/request.tt - virtualshelves/shelves.tt = OPAC = - opac-advsearch.tt - opac-detail.tt - opac-readingrecord.tt - opac-reserve.tt - opac-results-grouped.tt - opac-shelves.tt - opac-user.tt Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7960] choice to not show the text labels for item types
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62344|0 |1 is obsolete| | Attachment #62807|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 62932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62932&action=ed… [SIGNED OFF] Bug 7960: Add syspref to hide/show item type text labels in catalog To test: 1) Apply patch and update database 2) Go to Admin -> Sysprefs -> Find system preference 'ItemTypeText' 3) Should have default value 'Show'. Change to 'Don't show'. 4) Make sure 'noItemTypeImages' is enabled. 5) Search for a record in catalog on staff client. Go to detail page. 6) Confirm the text label for the item type is hidden, but the item type image still shows. 7) Search for a record in catalog on OPAC. Go to detail page. 8) Confirm the text label for the item type is hidden, but the item type image still shows. 9) Go back to sysprefs and set 'ItemTypeText' to 'Show'. 10) Confirm text labels now show on detail pages. Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7960] choice to not show the text labels for item types
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 62931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62931&action=ed… Screenshot of current display Current display for comparison (note: my items didn't have callnumbers) -- You are receiving this mail because: You are watching all bug changes.

1 0