January 2018 - Koha-bugs - lists.koha-community.org

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 23 Jan '18

23 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #81 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #78) > > >For non-package installations, the following rewrite rules will need to be >added to the apache config file: > >RewriteRule ^(.*)_(.*).js$ $1.js [R=301,N,L] > >RewriteRule ^(.*)_(.*).css$ $1.css [R=301,N,L] > > Wonder if this might not get lost - would there be a way to automate it? > What happens if you don't? We will have to highlight that in the release notes. People will quickly now that something is wrong if all JS and CSS files return 404 (In reply to Fridolin SOMERS from comment #79) > > RewriteRule ^(.*)_(.*).js$ $1.js [R=301,N,L] > This rewrite rules are quite large, what about files that already contain an > underscore ? > I think we should use a more explicit separator like "_kohav" with rewrite : > RewriteRule ^(.*)_kohav(.*).js. > > > +<script type="text/javascript" src="[% interface %]/[% theme %]/js/datatables_[% KOHA_VERSION %].js"></script> > The syspref "Version" contains a dot (ie 16.1200037) meaning that files will > have 2 dots, ie : > ../datatables_16.1200037.js > This may be a problem for some web-browsers like IE ? I am going to push these patches soon. Developers will have time to catch the issues before 18.05. If someone disagrees with these patches, tell us why. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 23 Jan '18

23 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63692|0 |1 is obsolete| | Attachment #63693|0 |1 is obsolete| | Attachment #63694|0 |1 is obsolete| | Attachment #63695|0 |1 is obsolete| | Attachment #63696|0 |1 is obsolete| | --- Comment #80 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 70830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70830&action=ed… Bug 12904: Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 23 Jan '18

23 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 23 Jan '18

23 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 23 Jan '18

23 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #43 from Nicholas van Oudtshoorn <vanoudt(a)gmail.com> --- Thanks for fixing that - my bad :-( -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20063] New: $9 is lost when cataloguing authority records
by bugzilla-daemon＠bugs.koha-community.org 23 Jan '18

23 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20063 Bug ID: 20063 Summary: $9 is lost when cataloguing authority records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Cataloging Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Depends on: 18811 Bug 18811 has terrible side-effects: commit 7e222bb0796196f1e466b73d909fd28d529cab75 Bug 18811: Change visibility checks in authorities.pl next if $tagslib->{$tag}->{$subfield}->{hidden}; I was trying to test the AuthDisplayHierarchy behaviour and notice that the $9 was not filled with the related (broader) authority id. Indeed it is hidden. See bug 18811 comment 33 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 [Bug 18811] Visibility settings inconsistent between framework and authority editor -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 19831] New: Turn on EnhancedMessagingPreferences by default for new installations
by bugzilla-daemon＠bugs.koha-community.org 23 Jan '18

23 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Bug ID: 19831 Summary: Turn on EnhancedMessagingPreferences by default for new installations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com I think we should not hide the different messaging options for new installations and turn on EnhancedMessagingPreferences by default on installation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 19988] New: Change 'sex' to 'gender'
by bugzilla-daemon＠bugs.koha-community.org 23 Jan '18

23 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19988 Bug ID: 19988 Summary: Change 'sex' to 'gender' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com By Koha terminology guidelines, we should use gender instead of sex. Most cases have been fixed but I found one missed case: /koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.pl - Reproduce by changing gender for a user in OPAC, then viewing the patron modification request in the staff client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 18083] New: Don't show 'library' selection on popular titles page for single-branch libraries
by bugzilla-daemon＠bugs.koha-community.org 23 Jan '18

23 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Bug ID: 18083 Summary: Don't show 'library' selection on popular titles page for single-branch libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org On the 'popular titles' page in the OPAC there is a search filter labelled "From" that offers you to select a library branch. For a library with only one branch this makes no sense and it would be nice if it was automatically hidden for single-branch libraries. Note: Currently not possible to hide with CSS only either. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 2093] Add OPAC dashboard for logged-in users
by bugzilla-daemon＠bugs.koha-community.org 23 Jan '18

23 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 [Bug 20068] Warn on OPAC homepage if not logged in due to OPAC dashboard -- You are receiving this mail because: You are watching all bug changes.

1 0