January 2018 - Koha-bugs - lists.koha-community.org

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #396 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Last 4 patches pushed to master for 18.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #395 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 70775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70775&action=ed… Bug 7143: Update about page for new dev - Zoe Bennett Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #394 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 70774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70774&action=ed… Bug 7143: Update about page for new dev - Te Rauhina Jackson Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #393 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 70773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70773&action=ed… Bug 7143: Update about page for new dev - Charlotte Cordwell Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #392 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 70772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70772&action=ed… Bug 7143: Update about page for new dev - Grace Smyth Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13995] Proper Exception handling
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #27 from M. Tompsett <mtompset(a)hotmail.com> --- I understand the desire to single file each exception. That makes sense. We can use directory structure to sort them if needed. git bz apply 13995 git diff origin/master | grep "package Koha::Exception::" | sed -e "s#\+package ##g" | sed -e "s#;##g" > ~/new_exceptions git grep "'Koha::Exceptions::" | grep -v "isa\W*=" | grep ^Koha/Exceptions | cut -f2- -d: | sed -e "s#[=>{ ']*##g" > ~/existing_exceptions Looking at new and existing exceptions, we see that there may be some overlap and as Tomás Cohen Arazi pointed out in comment #26, there is likely a need for better consolidation and sorting. So even if I wanted to sign this off, there is still clean up to do here. For this reason, I am leaving it Failed QA. I would be willing to sign off if this: 1) duplicates all the exceptions in Koha/Exceptions 2) would refactor nicely such another bug would merely remove the 's' from Exceptions 3) has test coverage for all the exception files -- if 1 & 2 are met, I'd be happy to write the test coverage just to get sign offs moved forward. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20021] New: Shelving location labelled Home library in Staff interface and OPAC with Branches
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20021 Bug ID: 20021 Summary: Shelving location labelled Home library in Staff interface and OPAC with Branches Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: eb(a)efdss.org QA Contact: testopia(a)bugs.koha-community.org Created attachment 70640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70640&action=ed… Incorrect label in staff interface. Home library is $c Shelving location We have a test system with branches enabled. The 952 $c (Shelving location) is consistently displaying as "Home Library" in both the staff interface and OPAC. The production system doesn't have branches enabled and 952$c displays correctly. -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 5062] Acq terminology: list price, ordering price, vendor price, RRP
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5062 Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> --- It may have changed since 2010, but my tests show me that RRP is not the replacement price. At least, not in the "Orders by fund" report. Here's what I entered in my order - Qty : 2 - Vendor Price : 10 $ - Tax : 9,5 % - Discount : 10 % - Replacement cost : 9 $ - Budgeted cost : 9 $ - Total : 18 $ Here's what the report gave me - Qty : 2 - List Price : 10 $ - RRP : 10 $ - Budgeted cost : 9 $ - Total RRP : 20 $ - Total cost : 18 $ So Vendor Price = List Price = RRP Also, see https://en.wikipedia.org/wiki/List_price it says List Price may also be known as RRP Unless there's a sys pref I didn't see that influences how the is calculated RRP... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #98 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 69050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69050 Bug 11879: Follow-up - Streamline markup and make label corrections Review of attachment 69050: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=118…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ +293,5 @@ > + Secondary email > + [% CASE 'fax' %] > + Fax > + [% END %] > + </li> This is nicer and friendlier on the po files, I'm sure. I believe it was done the other way because of a misunderstanding of HTML 1 (https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML_Templates) The SWITCH isn't allowed inside HTML tags, that is <tag [% SWITCH ... %]> is really bad. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #97 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 69029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69029 Bug 11879: Changes to Koha's schemas Review of attachment 69029: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=118…) ----------------------------------------------------------------- None of these have lastseen, as mentioned in the other patch. -- You are receiving this mail because: You are watching all bug changes.

1 0