January 2018 - Koha-bugs - lists.koha-community.org

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '18

20 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #392 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 70772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70772&action=ed… Bug 7143: Update about page for new dev - Grace Smyth Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13995] Proper Exception handling
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #27 from M. Tompsett <mtompset(a)hotmail.com> --- I understand the desire to single file each exception. That makes sense. We can use directory structure to sort them if needed. git bz apply 13995 git diff origin/master | grep "package Koha::Exception::" | sed -e "s#\+package ##g" | sed -e "s#;##g" > ~/new_exceptions git grep "'Koha::Exceptions::" | grep -v "isa\W*=" | grep ^Koha/Exceptions | cut -f2- -d: | sed -e "s#[=>{ ']*##g" > ~/existing_exceptions Looking at new and existing exceptions, we see that there may be some overlap and as Tomás Cohen Arazi pointed out in comment #26, there is likely a need for better consolidation and sorting. So even if I wanted to sign this off, there is still clean up to do here. For this reason, I am leaving it Failed QA. I would be willing to sign off if this: 1) duplicates all the exceptions in Koha/Exceptions 2) would refactor nicely such another bug would merely remove the 's' from Exceptions 3) has test coverage for all the exception files -- if 1 & 2 are met, I'd be happy to write the test coverage just to get sign offs moved forward. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20021] New: Shelving location labelled Home library in Staff interface and OPAC with Branches
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20021 Bug ID: 20021 Summary: Shelving location labelled Home library in Staff interface and OPAC with Branches Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: eb(a)efdss.org QA Contact: testopia(a)bugs.koha-community.org Created attachment 70640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70640&action=ed… Incorrect label in staff interface. Home library is $c Shelving location We have a test system with branches enabled. The 952 $c (Shelving location) is consistently displaying as "Home Library" in both the staff interface and OPAC. The production system doesn't have branches enabled and 952$c displays correctly. -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 5062] Acq terminology: list price, ordering price, vendor price, RRP
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5062 Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> --- It may have changed since 2010, but my tests show me that RRP is not the replacement price. At least, not in the "Orders by fund" report. Here's what I entered in my order - Qty : 2 - Vendor Price : 10 $ - Tax : 9,5 % - Discount : 10 % - Replacement cost : 9 $ - Budgeted cost : 9 $ - Total : 18 $ Here's what the report gave me - Qty : 2 - List Price : 10 $ - RRP : 10 $ - Budgeted cost : 9 $ - Total RRP : 20 $ - Total cost : 18 $ So Vendor Price = List Price = RRP Also, see https://en.wikipedia.org/wiki/List_price it says List Price may also be known as RRP Unless there's a sys pref I didn't see that influences how the is calculated RRP... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #98 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 69050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69050 Bug 11879: Follow-up - Streamline markup and make label corrections Review of attachment 69050: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=118…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ +293,5 @@ > + Secondary email > + [% CASE 'fax' %] > + Fax > + [% END %] > + </li> This is nicer and friendlier on the po files, I'm sure. I believe it was done the other way because of a misunderstanding of HTML 1 (https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML_Templates) The SWITCH isn't allowed inside HTML tags, that is <tag [% SWITCH ... %]> is really bad. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #97 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 69029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69029 Bug 11879: Changes to Koha's schemas Review of attachment 69029: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=118…) ----------------------------------------------------------------- None of these have lastseen, as mentioned in the other patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #96 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 69028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69028 Bug 11879: Add the "Main contact method" field in borrower informations. Review of attachment 69028: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=118…) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/borrowers_primary_contact_method.sql @@ +1,2 @@ > +ALTER TABLE `borrowers` ADD COLUMN `primary_contact_method` VARCHAR(45) NULL DEFAULT NULL AFTER `lastseen`; > +ALTER TABLE `deletedborrowers` ADD COLUMN `primary_contact_method` VARCHAR(45) NULL DEFAULT NULL AFTER `overdrive_auth_token`; deletedborrowers and borrowers should maintain the same field order. ::: installer/data/mysql/kohastructure.sql @@ +1682,4 @@ > `lang` varchar(25) NOT NULL default 'default', -- lang to use to send notices to this patron > `login_attempts` int(4) default 0, -- number of failed login attemps > `overdrive_auth_token` text default NULL, -- persist OverDrive auth token > + `lastseen` datetime default NULL, -- last time a patron has been seed (connected at the OPAC or staff interface) This adds lastseen, but the borrowers_primary_contact_method did not add it at all. ::: installer/data/mysql/updatedatabase.pl @@ +14968,4 @@ > } > } > > + Totally not necessary to touch this. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ +538,5 @@ > > [% UNLESS nophone && nophonepro && nomobile && noemail && noemailpro && nofax %] > <fieldset class="rows" id="memberentry_contact"> > + <legend id="contact_lgd">Contact</legend> > +<ol> Keep whitespace changes separate. @@ +602,4 @@ > [% IF ( mandatoryemailpro ) %]<span class="required">Required</span>[% END %] > </li> > [% END %] > + [% UNLESS nofax %] Keep whitespace changes separate. @@ +664,5 @@ > + [% END %] > + [% END %] > + </select> > + </li> > + </ol> This is the only place where you can really get away with these minor whitespace changes on the END and /ol. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ +275,5 @@ > + [% ELSE %] > + [% guarantor.firstname | html %] [% guarantor.surname | html %] > + [% END %] > + </li> > + [% END %] Where did this ELSIF clause come from?! This has nothing to do with primary_contact_method. ::: opac/opac-memberentry.pl @@ +93,5 @@ > libraries => \@libraries, > OPACPatronDetails => C4::Context->preference('OPACPatronDetails'), > ); > +my $check_BorrowerMandatoryField=C4::Context->preference("BorrowerMandatoryField"); > + my @field_check=split(/\|/,$check_BorrowerMandatoryField); Something is strange about this indentation. I would expect the same indentation level. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11559] Professional cataloger's interface
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19788] New: Local preference with uppercase
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788 Bug ID: 19788 Summary: Local preference with uppercase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: frederic(a)tamil.fr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In Administration > System preferences, when adding a local preference, the 'variable' name is transformed in lowercase. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 19702] New: Basket not displaying correctly on home page
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702 Bug ID: 19702 Summary: Basket not displaying correctly on home page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: david.bourgault(a)inlibro.com Reporter: david.bourgault(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: philippe.blouin(a)inlibro.com When viewing the "base url" of the OPAC catalog, the basket is not displayed correctly: Say your website is `opac.books.com`, the basket will be displayed correctly for all page under `opac.books.com/cgi-bin/koha/` but not on `opac.books.com/` -- You are receiving this mail because: You are watching all bug changes.

1 11