January 2018 - Koha-bugs - lists.koha-community.org

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '18

22 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67610|0 |1 is obsolete| | Attachment #67611|0 |1 is obsolete| | Attachment #68297|0 |1 is obsolete| | --- Comment #75 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 70795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70795&action=ed… Bug 14576 - Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '18

22 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19542] New: Koha should display Elasticsearch information in the about page
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '18

22 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542 Bug ID: 19542 Summary: Koha should display Elasticsearch information in the about page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 18754] New: Translatability: Get rid of exposed tt directives in opac-detail.tt
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '18

22 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18754 Bug ID: 18754 Summary: Translatability: Get rid of exposed tt directives in opac-detail.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr The file opac-detail.tt exposes a lot of template directives to translation where translators should not be confronted with. Some examples from po file are: $[% SUBFIELD.code %] [% SUBFIELD.value %] %s [%% INCLUDE \"openlibrary-readapi.inc\" bib = { normalized_isbn => " "normalized_isbn, lccn => lccn, normalized_oclc => normalized_oclc } %%] See: [% IF ( nextTitle ) %][% nextTitle |html %][% ELSE %]next biblio[% END " "%] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 19899] New: Software error while check in, The method noreturn is not covered by tests!
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '18

22 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Bug ID: 19899 Summary: Software error while check in, The method noreturn is not covered by tests! Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: mhby87(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Created attachment 70217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70217&action=ed… The method noreturn is not covered by tests! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 19918] New: span tag not closed in opac-registration-confirmation.tt
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '18

22 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Bug ID: 19918 Summary: span tag not closed in opac-registration-confirmation.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 13599 In opac-registration-confirmation.tt: 43 44 Password: 45 [% password_cleartext %] 46 Introduced by: commit 06f4950aa21ff889cff81f27b2f4e79788db193f Bug 13599 - Add patron cardnumber to self registration confirmation Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 [Bug 13599] Add patron cardnumber to self registration confirmation -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 19807] New: IntranetCatalogSearchPulldown doesn' t honor IntranetNumbersPreferPhrase
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '18

22 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Bug ID: 19807 Summary: IntranetCatalogSearchPulldown doesn't honor IntranetNumbersPreferPhrase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor.grousset(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org With IntranetCatalogSearchPulldown and IntranetNumbersPreferPhrase enabled. Doing a search in the intranet from the search pulldown for the call number searches "callnum,wrdl: foobar". But it should search "callnum,phr: foobar" === Going further === It's very likely to also affect the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 18183] New: jQuery append error related to script tags in cloneItemBlock
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '18

22 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18183 Bug ID: 18183 Summary: jQuery append error related to script tags in cloneItemBlock Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org This is a strange javascript error that I experienced on a 3.22 system and could not reproduce with the current (modified) framework in master. But since the code is essentially the same, it might still be possible. The js error is: TypeError: document.getElementById(...) is null The line in koha-tmpl/intranet-tmpl/prog/js/additem.js that causes this error is: $(clone).append(data); While running append, jQuery seems to call .domManip and .globalEval internally. The result on the interface is that you do not have an item block when receiving an order (AcqCreateItem=receiving). Note that data comes from services/itemrecorddisplay.pl and is a very long string containing all item fields and even script tags for plugins. Between the ACQ framework in 3.22 and in master (copied from Default), I noticed some smaller changes in the lines for plugins. Since the js variable "clone" contains a jQuery object for an element that is not yet added to the page, I could imagine a getElementById error. But it does not always occur, so some other condition must be triggered too. This condition appears to be connected to the script tags, since removing all plugins from the ACQ framework in 3.22 made the error disappear (no solution however). Some interesting comments on jQuery's handling of appending script tags are found in http://stackoverflow.com/questions/610995/cant-append-script-element Triggered by the getElementById error, I rearranged a few lines in cloneItemBlock so that I appended clone (the 'floating' div field for the new item) first to the outeritemblock div on the page and after that I appended the data string (item fields and script tags) to clone. This resolved the js error on 3.22 and did not affect master. Conclusion: We seem to stumble over a problem with our plugin script tags in jQuery's script evaluation when clone is not bound to the page yet. The proposed patch just adds this workaround touching three lines. If we would like to change (again) the way we handle script tags for plugins, we will need much more effort. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 19798] New: Returns.pl doesn't define itemnumber for transfer-slip.
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '18

22 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Bug ID: 19798 Summary: Returns.pl doesn't define itemnumber for transfer-slip. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: bjorn.nylen(a)ub.lu.se QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Marking master as version as 17.11 isn't available to select. It seems the itemnumber isn't set in the link/button that prints transfer-slips. To reproduce: 1. Check in available/not on hold item at a non owning library. 2. Press transfer-button. 3. Resulting slips says "Item not found". "Inspect element" in browser for the button indicates that itemnumber is not set: "transfer-slip.pl?transferitem=&branchcode=CPL&op=slip" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 14546] Make staff client templates responsive
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '18

22 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Bug 14546 depends on bug 19860, which changed state. Bug 19860 Summary: Make staff client home page responsive https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0