October 2018 - Koha-bugs - lists.koha-community.org

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #139 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 81743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81743&action=ed… Bug 15395: Fix QA failure - filter not found Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #138 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 81742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81742&action=ed… Bug 15395: Use POSIX::setlocale To keep compatibility with jessie (that have Message::Locales 1.23, so without setlocale) Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #137 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 81741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81741&action=ed… Bug 15395: Example usage of I18N Template::Toolkit plugin Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #21 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #136 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 81739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81739&action=ed… Bug 15395: Do not process template files that do not use i18n.inc It should make the string extraction process a little faster For the record, I timed some parts of the process to see why it was so slow, and without surprises the most time-consuming task is the Perl code analysis by PPI with an average time of 50ms by "template block" on my machine. Multiply that by the number of template blocks (approximatively 900), that gives us 45 seconds just for this task. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #135 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 81738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81738&action=ed… Bug 15395: Make QA test script happy It is not totally happy because of the template file used in tests. It has line breaks inside TT directives and QA test script complains because line breaks in TT directives confuse the current translatable strings extractor. However this patchset (along with bug 20988) will hopefully make the current extractor obsolete and thus make the 'no-line-breaks' rule useless Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10442] Remove references to non-standard "error" class
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #16 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #134 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 81737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81737&action=ed… Bug 15395: Add unit tests for extract_messages_from_templates Because LangInstaller use FindBin to define some paths, the test produces warnings about a missing directory. I'm not sure how we can avoid that. Test plan: 1. prove t/LangInstaller.t Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #133 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 81736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81736&action=ed… Bug 15395: Do not use nl_putenv, use $ENV instead nl_putenv is only useful on Windows systems Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #132 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 81735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81735&action=ed… Bug 15395: Make msgmerge quiet Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0