October 2018 - Koha-bugs - lists.koha-community.org

[Bug 21660] New: Loans can't be renewed when there are hold, even if Library transfer limits prevents prebents the item from fulfilling a hold
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21660 Bug ID: 21660 Summary: Loans can't be renewed when there are hold, even if Library transfer limits prevents prebents the item from fulfilling a hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: klas.blomberg(a)skovde.se QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Scenario: An item is checked out at library A Another item is checked out from library B, and there is a hold for the title at library B. UseBranchTransferLimits is set to enfarce, so items should not be transferred from library A to library B (yes, settings are correct!) In this case it seems reasonable that we should be able to renew the item at library A, irrespective of the hold, as that item is not supposed to fill the hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #122 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 81700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81700&action=ed… Bug 14957: DO NOT PUSH Schema changes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80972|0 |1 is obsolete| | Attachment #80973|0 |1 is obsolete| | Attachment #80974|0 |1 is obsolete| | Attachment #80975|0 |1 is obsolete| | Attachment #81179|0 |1 is obsolete| | Attachment #81621|0 |1 is obsolete| | --- Comment #121 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 81699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81699&action=ed… Bug 14957 - Rule based permission for MARC fields Add a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245a, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245a rule in step 5 in place, edit a bibliographic record, change 245a (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245a, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenbug University Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #13 from Josef Moravec <josef.moravec(a)gmail.com> --- Comment on attachment 81642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81642 Bug 7046: (follow-up) Tidy up to address test feedback Review of attachment 81642: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=704…) ----------------------------------------------------------------- ::: C4/Serials.pm @@ +1453,4 @@ > return $subscriptionid; > } > > +=head2 getsublength in C4 namespace it should be spelled "GetSubLength" or "GetSubscriptionLength" ::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt @@ +65,5 @@ > [% END %] > </option> > [% END %] > </select> > + <input type="text" name="sublength" id="sublength" value="[% sublength | html %]" size="3" />(enter amount in numerals) The "sublength" param is not passed from perl script, so this input is always empty ::: t/db_dependent/Serials/ReNewSubscription.t @@ +85,5 @@ > # Actual testing starts here! > > +# Calculate the subscription length for the renewal for issues, days and months > +my ($numberlength, $weeklength, $monthlength) = getsublength('issues', 7); > +is ( $numberlength, 7, "Sub length is 7 issues"); You should test other variables too. Also, you should test bad params too - undef, other string, ... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #12 from Josef Moravec <josef.moravec(a)gmail.com> --- When you click on the button "Renew subscription", there is warning: Use of uninitialized value $subtype in string eq at /home/vagrant/kohaclone/C4/Serials.pm line 1468 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #129 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- > I don't love the sound of these patches... (or the implementation of Koha::I18N). What do you mean? > What's performance like for handling all the translations at run time? (Might not be a huge issue with template caching?) See this section and if you can, try on your machine so we have more data about performance impact. https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_co… -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #59 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Thx for your patience and the quick rebase! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81606|0 |1 is obsolete| | --- Comment #58 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81650&action=ed… Bug 12365: (follow-up) Fixing broken circ rules table Adding filters to note to satisfy qa test tools Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81605|0 |1 is obsolete| | --- Comment #57 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81649&action=ed… Bug 12365: (follow-up) Putting backticks in atomicupdate Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0