October 2018 - Koha-bugs - lists.koha-community.org

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81152|0 |1 is obsolete| | Attachment #81153|0 |1 is obsolete| | Attachment #81154|0 |1 is obsolete| | Attachment #81155|0 |1 is obsolete| | Attachment #81156|0 |1 is obsolete| | Attachment #81157|0 |1 is obsolete| | Attachment #81158|0 |1 is obsolete| | Attachment #81159|0 |1 is obsolete| | --- Comment #131 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 81734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81734&action=ed… Bug 15395: Allow correct handling of plural translation Locale::Maketext does not allow correct handling of plural translation for languages that have more than one plural forms. Locale::Messages does. So Koha::I18N is now a wrapper around Locale::Messages, just like Locale::TextDomain, and export the same symbols as Locale::TextDomain. You can refer to documentation of Locale::TextDomain to know how to use exported subroutines. Example usage: __("Hi") __x("Hi {name}", name => 'Bob') __n("item", "items", $num_items) __nx("one item", "{count} items", $num_items, count => $num_items) __p("Bibliographic record", "item") This patch also brings Koha::I18N power to Template::Toolkit templates by adding a TT plugin. This plugin can be used like this: [%# USE the plugin and define some macros %] [% PROCESS 'i18n.inc' %] [%# tn is the equivalent of __n %] [%# macro names can't start with underscore, t is for "translate" %] [% tn('item', 'items', num_items) %] Extraction of strings from templates is a bit complicated and use Template::Parser and PPI. Template is compiled into Perl code and then analyzed by PPI. It is slow, but should be correct even with complex constructions. Remove dependency to Locale::Maketext and Locale::Maketext::Lexicon Add dependency to Locale::Messages and PPI Test plan for translation in Perl code: 1. Open a .pl script or .pm module with your favorite text editor 2. Add 'use Koha::I18N;' in the beginning of file 3. Use one of the subroutines exported by Koha::I18N and be sure to have a way to visualize the result (pass result to the template for example, or simply warn and watch the log file) 4. cd misc/translator && ./translate update fr-FR # try other languages 5. Open misc/translator/po/fr-FR-messages.po and translate your string(s) You may need to change the "Plural-Forms" header. See https://localization-guide.readthedocs.org/en/latest/l10n/pluralforms.html 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct 8. prove t/Koha/I18N.t Test plan for translation in templates: 1. Open a template file (.tt or .inc) with your favorite text editor 2. Add the PROCESS directive mentioned above in the beginning of file 3. Use one of the t* macros defined in i18n.inc. They are used like their "__" equivalent, with one difference: the 'x' variants take a hashref instead of a hash as last parameter 4. cd misc/translator && ./translate update fr-FR 5. Open misc/translator/po/fr-FR-messages.po and translate your string(s) 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #130 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I am in favor of these patches as they will help us to handle plurals much better than we do so far. I have been working (test/review) on these patch for a long time and I think we should include them into 18.11 to make translation improvements backportable. The long term goal (bug 20988) can be discussed later. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8484] Add ability to choose if lost items are removed from a borrowers record.
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Fixed by bug 12363 and bug 19974 *** This bug has been marked as a duplicate of bug 19974 *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14907] Item search: Call Numbers in Item search results are ordered alphabetically
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907 Carl <ctodd(a)hcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ctodd(a)hcc.edu -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8426] Diacritics not being mapped for searching (Non-ICU)
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard(a)myacpl.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8426] Diacritics not being mapped for searching (Non-ICU)
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426 --- Comment #11 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Owen Leonard from comment #9) > Is this patch still relevant? Comments here are contradictory. If this > should still be tested please provide a detailed test plan. Still relevant, plan for Kyle's patch is similar to follow-up: 1 - Import the sample record 2 - Search for Zhar-ptitsa 3 - No result 4 - Apply patch 5 - You may need to cp word-phrase-utf.chr from /home/vagrant/kohaclone/etc/zebradb/etc/word-phrase-utf.chr to /etc/koha/zebradb/etc/word-phrase-utf.chr (backup your original first) 6 - Reindex zebra 7 - Search again, you should get result -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8426] Diacritics not being mapped for searching (Non-ICU)
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426 --- Comment #10 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 81722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81722&action=ed… Bug 8426: (follow-up) Similar changes for Ž and ž To test: 1 - Find or add a record by author Slavoj Žižek 2 - Search for 'Zizek' 3 - No results 4 - Apply patch 5 - Reindex 6 - Search again 7 - Success! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8426] Diacritics not being mapped for searching (Non-ICU)
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8426] Diacritics not being mapped for searching (Non-ICU)
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Diacritics not being mapped |Diacritics not being mapped |for searching |for searching (Non-ICU) CC| |nick(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0