October 2018 - Koha-bugs - lists.koha-community.org

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #110 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 81176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81176&action=ed… Bug 14957: Fix control field rules regression and add rule validation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21664] New: Input not blocked by modal for hold found
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21664 Bug ID: 21664 Summary: Input not blocked by modal for hold found Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To recreate: 1 - Place a few holds in the catalog, one for pickup at current library, one for pickup elsewhere 2 - Checkin the first hold 3 - Click nothing and note that focus is still on the barcode field in the checkin box 4 - Type the next barcode for the hold at another location, note it populates 5 - Hit enter 6 - You get a new modal for transfer 7 - Note the barcode field is not in focus 8 - Note you cannot type until the modal is dismissed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #119 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 81167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81167&action=ed… Screenshot of Pootle with plural translations and context (In reply to Julian Maurice from comment #100) > (In reply to Jonathan Druart from comment #99) > > Did you try if these changes will behave correctly in pootle? > > i.e. Does the pootle's interface will let translators filled these forms > > according to the language, etc.? > I haven't tried but the documentation says that pootle support this feature > http://docs.translatehouse.org/projects/translate-toolkit/en/latest/formats/ > po.html#po > and it's a basic feature of gettext/PO files. I would be very surprised if > Pootle doesn't handle it. And it handle it very well. See screenshot attached -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12648] Link patrons to an order
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21587 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21587 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21587 [Bug 21587] Patrons to notify on receiving doesn't work on new order creation, only on modification -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #118 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Julian Maurice from comment #105) > (In reply to Jonathan Druart from comment #102) > > Code review: > > 1. Not important but the Koha.po file provided for the tests are not taken > > into account. Maybe it could be better to generate the .mo from the tests? > Or maybe we can simply remove the .po file as it can be easily generated from > the .mo file with msgunfmt ? I removed it from the first patch and added a comment in the test script to tell how to modify this MO file -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #117 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Jonathan Druart from comment #104) > (In reply to Julian Maurice from comment #92) > > Extraction of strings from templates is a bit complicated and use > > Template::Parser and PPI. Template is compiled into Perl code and then > > analyzed by PPI. It is slow, but should be correct even with complex > > constructions. > > Indeed, it is super slow compared. I would consider it acceptable compared > to the enhancement it brings. > attachment 81158 should make it a little more acceptable -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #116 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Jonathan Druart from comment #107) > (In reply to Julian Maurice from comment #105) > > > 3. The content from the .inc files are added to the .po because they contain > > > TT blocks on several lines. Maybe we should have a list of files to skip and > > > copy as it (?) > > I don't understand. My .po file is clean after an 'update'. Why would we > > want to skip .inc files ? Can you give an example of what gets wrongly added > > to the .po ? > > #: opac-tmpl/bootstrap/en/includes/i18n.inc:1 > #, c-format > msgid "" > "[%% USE I18N; MACRO t(msgid) BLOCK; I18N.t(msgid); END; MACRO tx(msgid, " > "vars) BLOCK; I18N.tx(msgid, vars); END; MACRO tn(msgid, msgid_plural, > count) " > "BLOCK; I18N.tn(msgid, msgid_plural, count); END; MACRO tnx(msgid, " > "msgid_plural, count, vars) BLOCK; I18N.tnx(msgid, msgid_plural, count, " > "vars); END; MACRO txn(msgid, msgid_plural, count, vars) BLOCK; I18N." > "txn(msgid, msgid_plural, count, vars); END; MACRO tp(msgctxt, msgid) BLOCK; > " > "I18N.tp(msgctxt, msgid); END; MACRO tpx(msgctxt, msgid, vars) BLOCK; I18N." > "tpx(msgctxt, msgid, vars); END; MACRO tnp(msgctxt, msgid, msgid_plural, " > "count) BLOCK; I18N.tnp(msgctxt, msgid, msgid_plural, count); END; MACRO " > "tnpx(msgctxt, msgid, msgid_plural, count, vars) BLOCK; I18N.tnpx(msgctxt, " > "msgid, msgid_plural, count, vars); END; %%] " > msgstr "" > > And there is nothing to translate in this file, there are just TT tags. > It happens when TT tags are split on several lines. Ah I thought you were talking about xx-XX-messages.po but this is in xx-XX-opac-bootstrap.po right ? This should be fixed by attachment 81157 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77476|0 |1 is obsolete| | --- Comment #115 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 81159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81159&action=ed… Bug 15395: Example usage of I18N Template::Toolkit plugin Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #114 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 81158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81158&action=ed… Bug 15395: Do not process template files that do not use i18n.inc It should make the string extraction process a little faster For the record, I timed some parts of the process to see why it was so slow, and without surprises the most time-consuming task is the Perl code analysis by PPI with an average time of 50ms by "template block" on my machine. Multiply that by the number of template blocks (approximatively 900), that gives us 45 seconds just for this task. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #113 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 81157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81157&action=ed… Bug 15395: Make QA test script happy It is not totally happy because of the template file used in tests. It has line breaks inside TT directives and QA test script complains because line breaks in TT directives confuse the current translatable strings extractor. However this patchset (along with bug 20988) will hopefully make the current extractor obsolete and thus make the 'no-line-breaks' rule useless -- You are receiving this mail because: You are watching all bug changes.

1 0