October 2018 - Koha-bugs - lists.koha-community.org

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #112 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 81156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81156&action=ed… Bug 15395: Add unit tests for extract_messages_from_templates Because LangInstaller use FindBin to define some paths, the test produces warnings about a missing directory. I'm not sure how we can avoid that. Test plan: 1. prove t/LangInstaller.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #111 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 81155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81155&action=ed… Bug 15395: Do not use nl_putenv, use $ENV instead nl_putenv is only useful on Windows systems -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #110 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 81154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81154&action=ed… Bug 15395: Make msgmerge quiet -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #109 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 81153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81153&action=ed… Bug 15395: Require Locale::Messages 1.24 1.21 fixes a bug in the way environment variables LANGUAGE and LANG are interpreted https://rt.cpan.org/Public/Bug/Display.html?id=81315 1.24 brings its own setlocale which "does the right thing" https://metacpan.org/pod/release/GUIDO/libintl-perl-1.29/lib/Locale/Message… -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77475|0 |1 is obsolete| | --- Comment #108 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 81152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81152&action=ed… Bug 15395: Allow correct handling of plural translation Locale::Maketext does not allow correct handling of plural translation for languages that have more than one plural forms. Locale::Messages does. So Koha::I18N is now a wrapper around Locale::Messages, just like Locale::TextDomain, and export the same symbols as Locale::TextDomain. You can refer to documentation of Locale::TextDomain to know how to use exported subroutines. Example usage: __("Hi") __x("Hi {name}", name => 'Bob') __n("item", "items", $num_items) __nx("one item", "{count} items", $num_items, count => $num_items) __p("Bibliographic record", "item") This patch also brings Koha::I18N power to Template::Toolkit templates by adding a TT plugin. This plugin can be used like this: [%# USE the plugin and define some macros %] [% PROCESS 'i18n.inc' %] [%# tn is the equivalent of __n %] [%# macro names can't start with underscore, t is for "translate" %] [% tn('item', 'items', num_items) %] Extraction of strings from templates is a bit complicated and use Template::Parser and PPI. Template is compiled into Perl code and then analyzed by PPI. It is slow, but should be correct even with complex constructions. Remove dependency to Locale::Maketext and Locale::Maketext::Lexicon Add dependency to Locale::Messages and PPI Test plan for translation in Perl code: 1. Open a .pl script or .pm module with your favorite text editor 2. Add 'use Koha::I18N;' in the beginning of file 3. Use one of the subroutines exported by Koha::I18N and be sure to have a way to visualize the result (pass result to the template for example, or simply warn and watch the log file) 4. cd misc/translator && ./translate update fr-FR # try other languages 5. Open misc/translator/po/fr-FR-messages.po and translate your string(s) You may need to change the "Plural-Forms" header. See https://localization-guide.readthedocs.org/en/latest/l10n/pluralforms.html 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct 8. prove t/Koha/I18N.t Test plan for translation in templates: 1. Open a template file (.tt or .inc) with your favorite text editor 2. Add the PROCESS directive mentioned above in the beginning of file 3. Use one of the t* macros defined in i18n.inc. They are used like their "__" equivalent, with one difference: the 'x' variants take a hashref instead of a hash as last parameter 4. cd misc/translator && ./translate update fr-FR 5. Open misc/translator/po/fr-FR-messages.po and translate your string(s) 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Add additional template filter methods and a filter presence test to Koha
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21663 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 [Bug 21663] Incorrect filter prevents predefined notes from being added to patron acccounts -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14825] Accounts Rewrite Omnibus
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21641 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21310] New: sdgsdgsdgsdgsdg
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21310 Bug ID: 21310 Summary: sdgsdgsdgsdgsdg Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Continuous Integration Assignee: tomascohen(a)gmail.com Reporter: gludaggaming231(a)gmail.com Created attachment 78361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78361&action=ed… gsdgsdgsdg -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #369 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Update DB is failing with strict_sql_modes ON: DBD::mysql::db do failed: BLOB/TEXT column 'description' can't have a default value [for Statement " [3/26] CREATE TABLE `stockrotationrotas` ( `rota_id` int(11) auto_increment, -- Stockrotation rota ID `title` varchar(100) NOT NULL, -- Title for this rota `description` text NOT NULL default '', -- Description for this rota `cyclical` tinyint(1) NOT NULL default 0, -- Should items on this rota keep cycling? `active` tinyint(1) NOT NULL default 0, -- Is this rota currently active? PRIMARY KEY (`rota_id`), CONSTRAINT `stockrotationrotas_title` UNIQUE (`title`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; "] at installer/data/mysql/updatedatabase.pl line 16568. DBD::mysql::db do failed: Can't create table `koha_kohadev`.`stockrotationstages` (errno: 150 "Foreign key constraint is incorrectly formed") [for Statement " CREATE TABLE `stockrotationstages` ( `stage_id` int(11) auto_increment, -- Unique stage ID `position` int(11) NOT NULL, -- The position of this stage within its rota `rota_id` int(11) NOT NULL, -- The rota this stage belongs to `branchcode_id` varchar(10) NOT NULL, -- Branch this stage relates to `duration` int(11) NOT NULL default 4, -- The number of days items shoud occupy this stage PRIMARY KEY (`stage_id`), CONSTRAINT `stockrotationstages_rifk` FOREIGN KEY (`rota_id`) REFERENCES `stockrotationrotas` (`rota_id`) ON UPDATE CASCADE ON DELETE CASCADE, CONSTRAINT `stockrotationstages_bifk` FOREIGN KEY (`branchcode_id`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE ON DELETE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; "] at installer/data/mysql/updatedatabase.pl line 16583. DBD::mysql::db do failed: Can't create table `koha_kohadev`.`stockrotationitems` (errno: 150 "Foreign key constraint is incorrectly formed") [for Statement " CREATE TABLE `stockrotationitems` ( `itemnumber_id` int(11) NOT NULL, -- Itemnumber to link to a stage & rota `stage_id` int(11) NOT NULL, -- stage ID to link the item to `indemand` tinyint(1) NOT NULL default 0, -- Should this item be skipped for rotation? `fresh` tinyint(1) NOT NULL default 0, -- Flag showing item is only just added to rota PRIMARY KEY (itemnumber_id), CONSTRAINT `stockrotationitems_iifk` FOREIGN KEY (`itemnumber_id`) REFERENCES `items` (`itemnumber`) ON UPDATE CASCADE ON DELETE CASCADE, CONSTRAINT `stockrotationitems_sifk` FOREIGN KEY (`stage_id`) REFERENCES `stockrotationstages` (`stage_id`) ON UPDATE CASCADE ON DELETE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; "] at installer/data/mysql/updatedatabase.pl line 16604. It looks scary but seems easy to fix, `description` text NOT NULL default '' should not have a default value. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #91 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #90) > Created attachment 81087 [details] [review] > Bug 15486: Fix failing test in GetHardDueDate.t Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

1 0