October 2018 - Koha-bugs - lists.koha-community.org

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #106 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Jonathan Druart from comment #104) > BTW do you know what is the ". done." outputted by install? It is a message outputted by msgmerge, I will make it quiet -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #105 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Jonathan Druart from comment #102) > Code review: > 1. Not important but the Koha.po file provided for the tests are not taken > into account. Maybe it could be better to generate the .mo from the tests? Or maybe we can simply remove the .po file as it can be easily generated from the .mo file with msgunfmt ? > 2. No tests provided for misc/translator/LangInstaller.pm - I would not > consider it as blocker as it is the current state. Thanks for not considering it a blocker :) Testing a module that modifies the filesystem can be a huge pain, especially in this case where paths are hardcoded and where it modifies files tracked by git. But I can certainly try to write a test for extract_messages_from_templates since it doesn't have too many external dependencies and is the most complicated thing of the whole patch. > 3. The content from the .inc files are added to the .po because they contain > TT blocks on several lines. Maybe we should have a list of files to skip and > copy as it (?) I don't understand. My .po file is clean after an 'update'. Why would we want to skip .inc files ? Can you give an example of what gets wrongly added to the .po ? > 4. What is done in Koha::I18N::init is weird, but I trust you if you think > everythink is needed. I agree that it's weird but I'm pretty sure everything is needed > However: pod Locale::Messages, nl_putenv: "The sole purpose of this function > is to work around some ideosyncrasies in the environment processing of > Windows systems. If you want to portably set or unset environment variables, > use this function instead of directly manipulating %ENV." > So maybe we should use ENV, it will make the line clear about what it does, > and 'git grep $ENV' will work Ok I'll try without nl_putenv and see if it works -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5198] HOLDPLACED being logged in patron messages
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5198 Sophie MEYNIEUX <sophie.meynieux(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux(a)biblibre.co | |m --- Comment #4 from Sophie MEYNIEUX <sophie.meynieux(a)biblibre.com> --- In message_queue the message is identified with the borrowernumber of the patron who places the holds, that's why it is displaid on patron record. I think it is useful to keep this information. But maybe HOLDPLACED messages should be filtered in patron notifications tab -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #368 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- See multiple dependant bugs for fixes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21620 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21620 [Bug 21620] Errors when using email from stockrotation.pl cronjob -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21656 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 [Bug 21656] Syntax Error in Stock Rotation Default Notice Template -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #10 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 81107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81107&action=ed… Bug 13098: Make _FixAccountForLostAndReturned refund the right thing This patch changes the logic inside the method, to make it match the behaviour described on the tests. It uses the existing offsets on the account_offsets table to gather information about the right things to refund. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests don't pass! - Apply this patch - Run k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! - Sign off :-D Followed test plan, patch works as described. All three patches pass QA test tool Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #9 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 81106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81106&action=ed… Bug 13098: Tests for all _FixAccountForLostAndReturned use cases This patch introduces tests for all the use cases for _FixAccountForLostAndReturned. This includes the following scenarios before _FixAccountForLostAndReturned is called: - Full write off (the original issue) - Full payment - No payment or write off - Partial payment and partial write off Written off debts (L lines) are just skipped, any kind of payment is added and then refund as a single credit (CR). Amount outstanding is set to 0. Offsets need to be generated for paper trail of this decisions. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because _FixAccountForLostAndReturned is not doing the right thing :-D Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #8 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 81105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81105&action=ed… Bug 13098: Add Koha::Account::Offsets->total This patch introduces this trivial method for returning the sum0 result of the amount columns of a Koha::Account::Offsets set. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account/Offsets.t - Sign off :-D Followed test plan, patch worked as described Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0