October 2018 - Koha-bugs - lists.koha-community.org

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #107 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Julian Maurice from comment #105) > > 3. The content from the .inc files are added to the .po because they contain > > TT blocks on several lines. Maybe we should have a list of files to skip and > > copy as it (?) > I don't understand. My .po file is clean after an 'update'. Why would we > want to skip .inc files ? Can you give an example of what gets wrongly added > to the .po ? #: opac-tmpl/bootstrap/en/includes/i18n.inc:1 #, c-format msgid "" "[%% USE I18N; MACRO t(msgid) BLOCK; I18N.t(msgid); END; MACRO tx(msgid, " "vars) BLOCK; I18N.tx(msgid, vars); END; MACRO tn(msgid, msgid_plural, count) " "BLOCK; I18N.tn(msgid, msgid_plural, count); END; MACRO tnx(msgid, " "msgid_plural, count, vars) BLOCK; I18N.tnx(msgid, msgid_plural, count, " "vars); END; MACRO txn(msgid, msgid_plural, count, vars) BLOCK; I18N." "txn(msgid, msgid_plural, count, vars); END; MACRO tp(msgctxt, msgid) BLOCK; " "I18N.tp(msgctxt, msgid); END; MACRO tpx(msgctxt, msgid, vars) BLOCK; I18N." "tpx(msgctxt, msgid, vars); END; MACRO tnp(msgctxt, msgid, msgid_plural, " "count) BLOCK; I18N.tnp(msgctxt, msgid, msgid_plural, count); END; MACRO " "tnpx(msgctxt, msgid, msgid_plural, count, vars) BLOCK; I18N.tnpx(msgctxt, " "msgid, msgid_plural, count, vars); END; %%] " msgstr "" And there is nothing to translate in this file, there are just TT tags. It happens when TT tags are split on several lines. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #26 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #24) > Hmm. Should we reveal that value ? Perhaps not. So have adjusted it too: You entered an incorrect username or password. Please try again! But note that passwords are case sensitive and that your account will be locked out after a fixed number of failed login attempts. Please contact a library staff member if you continue to have problems. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81124|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 81125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81125&action=ed… Bug 21311: (follow-up) Adjust wording of failed login message Based on the feedback of Jonathan, Katrin, Mark and Martin (thx), adding the general remark that if lockout is enabled, an account may be locked out after x attempts. This does not say that the account on hand is locked or not. Adding a <p> tag between 'Log in'-button and 'Forgot your password' for presentation. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #24 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Hmm. Should we reveal that value ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #23 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Obviously the 3 is based on the current value of FailedLoginAttempts. The last part of the line is removed when lockout is not enabled. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #22 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #21) > So the tekst is now: > You entered an incorrect username or password. Please try again! But note > that passwords are case sensitive and that your account will be locked out > after 3 failed attempts. Please contact a library staff member if you > continue to have problems. s/tekst/text/ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #21 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- So the tekst is now: You entered an incorrect username or password. Please try again! But note that passwords are case sensitive and that your account will be locked out after 3 failed attempts. Please contact a library staff member if you continue to have problems. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81123|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 81124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81124&action=ed… Bug 21311: (follow-up) Adjust wording of failed login message Based on the feedback of Jonathan, Katrin, Mark and Martin (thx), adding the general remark that if lockout is enabled, an account may be locked out after x attempts. This does not say that the account on hand is locked or not. Adding a <p> tag between 'Log in'-button and 'Forgot your password' for presentation. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #19 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Thx people for your feedback. Hope that the last follow-up covers it all. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 81123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81123&action=ed… Bug 21311: (follow-up) Adjust wording of failed login message Based on the feedback of Jonathan, Katrin, Mark and Martin (thx), adding the general remark that if lockout is enabled, an account may be locked out after x attempts. This does not say that the account on hand is locked or not. Adding a <p> tag between 'Log in'-button and 'Forgot your password' for presentation. -- You are receiving this mail because: You are watching all bug changes.

1 0