October 2018 - Koha-bugs - lists.koha-community.org

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #368 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- See multiple dependant bugs for fixes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21620 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21620 [Bug 21620] Errors when using email from stockrotation.pl cronjob -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21656 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 [Bug 21656] Syntax Error in Stock Rotation Default Notice Template -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #10 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 81107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81107&action=ed… Bug 13098: Make _FixAccountForLostAndReturned refund the right thing This patch changes the logic inside the method, to make it match the behaviour described on the tests. It uses the existing offsets on the account_offsets table to gather information about the right things to refund. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests don't pass! - Apply this patch - Run k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! - Sign off :-D Followed test plan, patch works as described. All three patches pass QA test tool Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #9 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 81106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81106&action=ed… Bug 13098: Tests for all _FixAccountForLostAndReturned use cases This patch introduces tests for all the use cases for _FixAccountForLostAndReturned. This includes the following scenarios before _FixAccountForLostAndReturned is called: - Full write off (the original issue) - Full payment - No payment or write off - Partial payment and partial write off Written off debts (L lines) are just skipped, any kind of payment is added and then refund as a single credit (CR). Amount outstanding is set to 0. Offsets need to be generated for paper trail of this decisions. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because _FixAccountForLostAndReturned is not doing the right thing :-D Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #8 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 81105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81105&action=ed… Bug 13098: Add Koha::Account::Offsets->total This patch introduces this trivial method for returning the sum0 result of the amount columns of a Koha::Account::Offsets set. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account/Offsets.t - Sign off :-D Followed test plan, patch worked as described Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80862|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80863|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '18

25 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley(a)catalyst.net.nz Attachment #80864|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0