October 2018 - Koha-bugs - lists.koha-community.org

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '18

22 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80698|0 |1 is obsolete| | --- Comment #260 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 80980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80980&action=ed… Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. This patch also adds 3 columns: - No. of ordered titles - No. of received titles - Date closed It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '18

22 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80697|0 |1 is obsolete| | --- Comment #259 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 80979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80979&action=ed… Bug 11708: Change aqbasketgroups.closed to closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13520] add rental to circ matrix
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '18

22 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13520 Sally Healey <sally.healey(a)cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '18

22 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 --- Comment #30 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Katrin Fischer from comment #29) > 2) Search > Searching on the notes column doesn't work. > > 3) Export > The notes are not exported, neither using the "Export as CSV" nor the new > "Excel" export at the bottom of the table. I think using the link + modal model from acqui/basket.pl would work well here. I think it would solve both of these problems, each caused by the fact that the table cell contains an input field instead of text. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '18

22 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #74 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Right now, all the required fields are filled automatically. Moreover, if the change is null (0.00), submitting the form bring users back to the Pay fines page immediately. Users can click a single time to pay the full fine. I agree with the idea that adding a system preference is irrelevant in this context and, therefore, I am going to remove it. I also agree that disabled inputs should be turned into spans to avoid confusion. I think that if the change is null the span should be blank and if not it should be filled in red. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '18

22 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #258 from Owen Leonard <oleonard(a)myacpl.org> --- This patch inadvertently changes the filename of two existing files (which didn't exist when the patch was written): BasketGroup.pm and BasketGroups.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '18

22 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '18

22 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #109 from David Gustafsson <glasklas(a)gmail.com> --- Rebased against master. I think I was responsible for the conflict this time (bug 19687) :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '18

22 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79890|0 |1 is obsolete| | --- Comment #108 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 80975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80975&action=ed… Bug 14957 - Add missing use in Biblio.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '18

22 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79370|0 |1 is obsolete| | --- Comment #107 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 80974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80974&action=ed… Bug 14957 - Remove exports of removed subroutines Remove exports of subroutines previously removed -- You are receiving this mail because: You are watching all bug changes.

1 0