October 2018 - Koha-bugs - lists.koha-community.org

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '18

22 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79369|0 |1 is obsolete| | --- Comment #106 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 80973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80973&action=ed… Bug 14957 - Refactor and fix tests and documentation Change "MARC permissions" to "MARC merge rules" since this is more descriptive of the feature provided. Update help page to reflect changes since large refactorization. Replace outdated tests with up to date tests. Improve rules admin UI adding "preset" setting. Move large part of added C4::Biblio code into Koha:: namespace. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '18

22 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79368|0 |1 is obsolete| | --- Comment #105 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 80972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80972&action=ed… Bug 14957 - Rule based permission for MARC fields Add a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch 2. Run updatedatabase.pl 3. Log in to staff client 4. Enable new syspref MARCPermissions 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". 6. Go to the "MARC field permissions" page 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this for more information about the rule system. 8. Add desired rules to the rule table, press the +-button to add. 9. Clicking the pen-icon (edit) should allow you to edit corresponding rule. 10. Clicking the x-icon should remove corresponding rule after confirmation. 11. Selecting one or more rules followed by clicking the trash-icon should remove all selected rules after confirmation. 12. To test your rules, import or in other way modify a record. 13. Check that the record was modified as defined by your rules. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenbug University Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10304] Add avanced search filter for "not for loan" items
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '18

22 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |oleonard(a)myacpl.org --- Comment #29 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Next time as a separate follow-up patch please! ;) Looking at this again I have some issues, I am sorry to come up with this a little lately :( 1) Usability There is visual indicator to tell apart an already stored from a changed/unsafed note. It's really easy to forget to press the button. If you happen to end your note with pressing "Enter" you trigger the error message "No order selected" It really doen't work well for notes that are longer than the input field is. They don't display in full and it's hard to move around in the input field. I think I'd like this much better following the existing design pattern with links and a modal (see basket summary). I am adding Owen in hope he has time to take a look. 2) Search Searching on the notes column doesn't work. 3) Export The notes are not exported, neither using the "Export as CSV" nor the new "Excel" export at the bottom of the table. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Aleisha, please make sure you always run the latest version of the QA tools from the gitlab repository on your patches: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt FAIL filters missing_filter at line 125 ( <a name="viewnote" data-toggle="popover" title="Note" data-content="[% rule.note %]" data-placement="top" data-trigger="hover">View note</a>) I'd have fixed that, but there is another issue: The layout of the issuing rule table is broken with this patch. The buttons at the end of the table are misaligned. My entered note shows up in the last column labelled "Actions" as well, pushing the buttons into another non-existing column... (looking at it this will hopefully make more sense) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard(a)myacpl.org --- Comment #257 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patches apply, QA script is clean. I am wondering about the changes to koha-tmpl/intranet-tmpl/prog/js/datatables.js as well. Adding Owen, maybe he has a moment to take a look at the datatables question here. Jonathan, could you have another look at Julian's answers in comment#249? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 --- Comment #17 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sorry for all the comments, I am just getting warmed up today it seems. I've decided to pass QA since the behaviour makes sense to me. I've tested an acquisition order. When it's not yet received the amounts show in Ordered and when you receive, the actual cost is shown in Spent. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80704|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 80966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80966&action=ed… Bug 9775: Unitprice should be hidden when creating an order The actual cost box is effectively hidden from the order page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 --- Comment #15 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Jonathan Druart from comment #11) > Do not we want to keep the value from the "last order received" for > subscription? > > - $data->{unitprice} = $lastOrderReceived->{unitprice}; > > > You do not hide it, you removed it. Is it really what we want? Martin, can you check this specific line? I agree with you on the workflow - actual cost is supposed to be set on receiving/processing the invoice. -- You are receiving this mail because: You are watching all bug changes.

1 0