October 2018 - Koha-bugs - lists.koha-community.org

[Bug 14391] Granular permissions for the administration module
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80004|0 |1 is obsolete| | Attachment #80005|0 |1 is obsolete| | Attachment #80006|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 80541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80541&action=ed… Bug 14391: Add granular permissions to the administration module So far the administration module only allowed for 2 permissions: - circulation conditions (manage_circ_rules) - everything else (parameters_remaining_permissions) With this patch almost every section of the administration page will have its own granular permission. To test: - Create different staff users: 1) One with parameters_remaining_permissions 2) One with parameters 3) One with catalogue and no parameters 4) One superlibrarian - Apply the patch - Run the database update - Check the staff users: 1) All subpermissions, but manage_circ_rules should be checked 2) Nothing should have changed 3) manage_item_serach_fields shoudl be checked (page had catalogue permission before) 4) Nothing should have changed - Try different settings of the permissions and verify that - Administration page behaves correctly - Administration menu behaves correctly ! You shoudl only see what you have permission for https://bugs.koha-community.org/show_bug.cgi?id=14391 Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14391] Granular permissions for the administration module
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10708] Make fine receipt customizable
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 --- Comment #9 from Barton Chittenden <barton(a)bywatersolutions.com> --- I can't tell if bug 12285 is simply related, or whether it's a duplicate. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10708] Make fine receipt customizable
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 Barton Chittenden <barton(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12285 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Barton Chittenden <barton(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10708 CC| |barton(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |testopia(a)bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 --- Comment #24 from Blou <philippe.blouin(a)inlibro.com> --- Hi Katrin, are you talking about koha-qa.pl ? I seem to have the latest version, and am not getting those messages. Any parameter I'm missing? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14391] Granular permissions for the administration module
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #18 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc CONFLICT (content): Merge conflict in installer/data/mysql/userpermissions.sql -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #185 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 80467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80467 Bug 14385: (QA follow-up) Additional changes and fixes Review of attachment 80467: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=143…) ----------------------------------------------------------------- Thank you very much for a Passed QA. Just had one question about one optimization you made in opac/opac-search.pl as I eyeball'd through the patch. The other things are just comments as I was looking through it. Regarding the leak via counting being off. This counting problem already leaks and is an issue. Fixing the counting problem is a complex problem, which has had recent comments on the mailing list. Given the size and scope of testing for this patch, I did not want to keep coding for perfection. Perfection is the enemy of good, or some variation thereof. :) ::: C4/Search.pm @@ +2215,5 @@ > else { > $can_place_holds = 1; > $available_count++; > + $available_items->{$prefix}->{count}++ if $item->{$hbranch}; > + foreach (qw(branchname itemcallnumber description)) { White space fix. ::: opac/opac-ISBDdetail.pl @@ +82,3 @@ > my $borcat = q{}; > +if ( $patron && C4::Context->preference('OpacHiddenItemsExceptions') ) { > + $borcat = $patron->categorycode; Nice optimization. ::: opac/opac-basket.pl @@ -59,4 @@ > my $borcat = q{}; > if ( C4::Context->preference('OpacHiddenItemsExceptions') ) { > # we need to fetch the borrower info here, so we can pass the category > - my $borrower = Koha::Patron->find( { borrowernumber -> $borrowernumber } ); Oops... should have been => good catch. ::: opac/opac-detail.pl @@ +85,4 @@ > my @all_items = GetItemsInfo($biblionumber); > my @hiddenitems; > my $patron = Koha::Patrons->find( $borrowernumber ); > +our $borcat= q{}; I would have preferred passing, rather than changing to our. ::: opac/opac-search.pl @@ +125,4 @@ > authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), > } > ); > +my $patron = Koha::Patrons->find( $borrowernumber ); Not an exact copy of 658 during the optimization. Will this affect things? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #2 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 80507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80507&action=ed… Bug 13098: Tests for _FixAccountForLostAndReturned on writeoff When a a write off is done on lost fees, but then the item is returned, the current behaviour is that a credit is added to the patron, for the amount the original lost fee was. This behaviour is wrong and this tests reproduce the situation. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because a credit (CR) is added for the original amount, without taking into account the fact the amount was not payed, but written off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0