December 2018 - Koha-bugs - lists.koha-community.org

[Bug 22026] New: Remove `use Modern::Perl` from Koha::REST::classes
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '19

04 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Bug ID: 22026 Summary: Remove `use Modern::Perl` from Koha::REST::classes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- The REST api is based on Mojolicious and as such the controllers within this namespace are all based upon `Mojo::Base`, `use Mojo::Base 'Mojolicious::Controller';` to be specific. Mojo::Base enables the following, which are the only useful things achieved by Modern::Perl in our case (as we limit ourselves to supporting perl 5.10, so any and all other features past perl 5.10 are unavailable to use anyway). ``` use strict; use warnings; use utf8; use feature ':5.10'; use mro; use IO::Handle (); require SomeBaseClass; push @ISA, 'SomeBaseClass'; sub has { Mojo::Base::attr(__PACKAGE__, @_) } ``` As such, adding the `use Modern::Perl` statement is just noise and needlessly loads a module. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 22016] New: Always send CT field for SIP checkin, even if empty
by bugzilla-daemon＠bugs.koha-community.org 01 Mar '19

01 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22016 Bug ID: 22016 Summary: Always send CT field for SIP checkin, even if empty Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Target Milestone: --- Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a CT field to be sent, even if that field is empty. Koha should be able to support this behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 22014] New: Add ability to send "00" in SIP CV field on checkin success
by bugzilla-daemon＠bugs.koha-community.org 01 Mar '19

01 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22014 Bug ID: 22014 Summary: Add ability to send "00" in SIP CV field on checkin success Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Target Milestone: --- Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a checkin success to return a CV field of the value "00" rather than no CV field at all. Koha should be able to support this behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 21252] New: Koha::Patron->do_check_for_previous_checkout should take Koha::Item as parameter
by bugzilla-daemon＠bugs.koha-community.org 01 Mar '19

01 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21252 Bug ID: 21252 Summary: Koha::Patron->do_check_for_previous_checkout should take Koha::Item as parameter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 21401] New: Account offsets should save the transacting library
by bugzilla-daemon＠bugs.koha-community.org 01 Mar '19

01 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 Bug ID: 21401 Summary: Account offsets should save the transacting library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 39

[Bug 19460] New: Limit total number of checkouts allowed per patron by patron category code
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '19

28 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19460 Bug ID: 19460 Summary: Limit total number of checkouts allowed per patron by patron category code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle(a)bywatersolutions.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Goal of development: Limit total number of checkouts allowed per patron by patron category code Work to be done: 1) Add new circulation rule "Max checkouts ( global, most restrictive )" to circulation rules. 2) Modify C4::Circulation::TooMany to respect this new rule 3) Modify script and template to show errors relating to this new rule -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 21247] New: Cannot add more than one emoji across the entire database as a tag
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '19

27 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21247 Bug ID: 21247 Summary: Cannot add more than one emoji across the entire database as a tag Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: liz(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Well I suppose that's not really fair - you can add them but you can only see the first one in the approval list, and on the detail/results pages. To replicate: Add a tag, such as 😍 to a biblio in the OPAC try to add another emoji, such as 🎶 In my 18.05, this won't work and the second tag is never inserted into tags_approval, though it is inserted into tags_all. It seems to be mysteriously approved as under the first emoji added, as well. I checked the DB encoding, it seemed correct. The database I was testing with was an upgraded one, 3.20 -> 18.05.02 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 21065] New: Data in accountoffsets and accountlines is deleted with the patron leaving gaps in financial reports
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '19

26 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21065 Bug ID: 21065 Summary: Data in accountoffsets and accountlines is deleted with the patron leaving gaps in financial reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The tables accountoffsets and accountlines are both "cleaned up" when a patron is deleted by using FK constraints. This is a problem because 1) The patrons have a "right to be forgotten" with GDPR and you can't refuse to delete them if their fines are paid etc. 2) Especially for partial payments and in other cases the data in accountlines and accountoffsets is neded to create reliable reports for statistics, but also for financial reports. It's not possible to determine from other tables like statistics and action_logs what fines are linked to which payment which doesn't allow to create reports by fine/fee type and similar. Instead of deleting the info, we should really just anonymize it. -- CREATE TABLE `accountoffsets` ( `borrowernumber` int(11) NOT NULL DEFAULT '0', `accountno` smallint(6) NOT NULL DEFAULT '0', `offsetaccount` smallint(6) NOT NULL DEFAULT '0', `offsetamount` decimal(28,6) DEFAULT NULL, `timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, KEY `accountoffsets_ibfk_1` (`borrowernumber`), CONSTRAINT `accountoffsets_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; CREATE TABLE `accountlines` ( `accountlines_id` int(11) NOT NULL AUTO_INCREMENT, `issue_id` int(11) DEFAULT NULL, `borrowernumber` int(11) NOT NULL DEFAULT '0', `accountno` smallint(6) NOT NULL DEFAULT '0', `itemnumber` int(11) DEFAULT NULL, `date` date DEFAULT NULL, `amount` decimal(28,6) DEFAULT NULL, `description` mediumtext COLLATE utf8_unicode_ci, `dispute` mediumtext COLLATE utf8_unicode_ci, `accounttype` varchar(5) COLLATE utf8_unicode_ci DEFAULT NULL, `amountoutstanding` decimal(28,6) DEFAULT NULL, `lastincrement` decimal(28,6) DEFAULT NULL, `timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, `notify_id` int(11) NOT NULL DEFAULT '0', `notify_level` int(2) NOT NULL DEFAULT '0', `note` text COLLATE utf8_unicode_ci, `manager_id` int(11) DEFAULT NULL, PRIMARY KEY (`accountlines_id`), KEY `acctsborridx` (`borrowernumber`), KEY `timeidx` (`timestamp`), KEY `itemnumber` (`itemnumber`), CONSTRAINT `accountlines_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `accountlines_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE SET NULL ON UPDATE SET NULL ) ENGINE=InnoDB AUTO_INCREMENT=4666 DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 41

[Bug 21896] New: Add Koha::Account::normalize_account
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '19

26 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Bug ID: 21896 Summary: Add Koha::Account::normalize_account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We need a method that automatically applies outstanding credits to outstanding debits. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 62

[Bug 22015] New: Move DataTables CSS to global include
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '19

26 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22015 Bug ID: 22015 Summary: Move DataTables CSS to global include Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- We now use DataTables on so many pages in the staff client it doesn't make sense to have to include DataTables CSS on each page where we need it. I propose to move datatables.css and buttons.dataTables.min.css into doc-head-close.inc -- You are receiving this mail because: You are watching all bug changes.

1 12