February 2018 - Koha-bugs - lists.koha-community.org

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #404 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #403) > Created attachment 72008 [details] [review] > Bug 7143: Update about page for new dev - Pongtawat Chippimolchai Pushed to master for 18.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #28 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19806] New: Add class to items.itemnotes_nonpublic
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806 Bug ID: 19806 Summary: Add class to items.itemnotes_nonpublic Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: jzairo(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Bug 13024 - Nonpublic note not appearing in the staff client added the nonpublic note to the 1) Checkouts (circulation.pl) 2) Checkins (returns.pl) 3) Record details ( moredetail.pl ) There is currently no class to hide on of those locations if a library wants to hide a non public note. Can we add a class to items.itemnotes_nonpublic so libraries have the choice to hide one of the locations listed above. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 8137] Checkout limit by patron category for all libraries
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #21 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 64704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64704 Bug 8137 - Add Default checkout limit by patron category with priority. Review of attachment 64704: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=813…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ +548,5 @@ > no limit applies, except possibly for a limit you define for a specific item type. > </p> > + <p> > + <b>Has priority: </b>If checked, the rule will override those for all branches. Else > + it behaves like a default one: used if no rule existe for the coresponding branch. exists, corresponding. -- typos. @@ +559,4 @@ > <th>Patron category</th> > <th>Total current checkouts allowed</th> > <th>Total current on-site checkouts allowed</th> > + [% UNLESS humanbranch %]<th>Has priority</th>[% END %] humanbranch?! I haven't read the code, but this seems strange to read. ::: t/db_dependent/Circulation/Branch.t @@ +201,5 @@ > + (categorycode, maxissueqty, maxonsiteissueqty, has_priority) > + VALUES( ?, ?, ?, ? ) > +|; > +$dbh->do($query, {}, $samplecat->{categorycode}, 3, 3, 0); > + Why is this change so far away from the other? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8137] Checkout limit by patron category for all libraries
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #20 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 64891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64891 Bug 8137 - Add default issuing rule for all branches. Review of attachment 64891: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=813…) ----------------------------------------------------------------- ::: t/db_dependent/Koha/IssuingRules.t @@ +50,5 @@ > + ok(Koha::IssuingRule->new({ > + branchcode => $branchcode, > + categorycode => $categorycode, > + itemtype => $itemtype, > + })->store, "Given I added an issuing rule branchcode => $branchcode,' The wording probably should avoid personal pronouns like "I added". "Issuing rule for ... added as expected." is probably better. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7760] Add ids and classes to every staff page to help with customizaton
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7760 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 [Bug 20268] CSS regression: white gap on the top of the staff pages -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8137] Checkout limit by patron category for all libraries
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #19 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Hello, Is somebody still working on this one ? Sonia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20135] New: Staff client language choose pop-up can appear off-screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 Bug ID: 20135 Summary: Staff client language choose pop-up can appear off-screen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Created attachment 71231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71231&action=ed… Screenshot showing the off-screen menu In the staff client, the language-selection menu pop-up at the bottom of the page can appear off-screen under some circumstances: - StaffLangSelectorMode is set to "only footer" or "both top and footer" - The first language option (from left to right) includes more than one choice (for example: en-US and en-GB). -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #86 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18975] New: Wrong CSRF token when emailing cart contents
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18975 Bug ID: 18975 Summary: Wrong CSRF token when emailing cart contents Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: bc(a)interleaf.ie QA Contact: testopia(a)bugs.koha-community.org When you are not logged into the OPAC and attempt to email the contents of your cart you get the following error : "Wrong CSRF token at /usr/share/koha/opac/cgi-bin/opac/opac-sendbasket.pl line 55" Some testing shows: If you log in before adding items to your cart then send it, it works. If you're not logged in and you log in as part of sending the basket, the error occurs It must be that authenticating in that window doesn't set the session and id / secret aren't being set before submitting If you aren't logged in, click send the basket and log in, refresh the page before sending, then send, it forces it to pick up the session and works -- You are receiving this mail because: You are watching all bug changes.

1 15