February 2018 - Koha-bugs - lists.koha-community.org

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '18

25 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #39 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72181&action=ed… Bug 15492: Make SCI use its own sysprefs and CSS file Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '18

25 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #38 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72180&action=ed… Bug 15492: Make existing code aware of new self_check* permissions This patch makes the existing code for SCO use the new permissions schema for self check modules. Specifically addresses this change: circulate => self_checkout becomes slef_check => self_checkout_module about.pl checks are dejusted too. get_template_and_user gets refactored to avoid code duplication and the conditions are adjusted for the new permissions. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '18

25 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #37 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72179&action=ed… Bug 15492: New sysprefs and permissions In order to make this module unrelated to the SCO module, this patch introduces the following sysprefs: - SelfCheckInMainUserBlock - SelfCheckInModuleUserID - SelfCheckInTimeout - SelfCheckInUserCSS - SelfCheckInUserJS It also adds a new user flag and sub-permission: - self_check => self_checkin_module and moves the circulate => self_checkout permission into - self_check => self_checkout_module Descriptions are adjusted accordingly. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '18

25 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #36 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72178&action=ed… Bug 15492: (QA follow-up) Reset SCI if idle for 30 seconds Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '18

25 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #35 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72177&action=ed… Bug 15492: Add SCI module This patch adds the SCI module, and adapts C4::Auth to know about it. The current behaviour is: - Requires admin user initialization/login - Uses the logged users' library - A form allows to scan multiple barcodes - A button sends the barcode list to the controller to batch perform the checkins - Successful and failed checkins are sent to the template - Results are displayed - Logout link To test: - Apply this patches - Make sure you upgrade: $ kshell k$ perl installer/data/mysql/updatedatabase.pl - Have 'SelfCheckInModule' disabled - Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1] => SUCCESS: You are rejected because the feature is disabled - Enable 'SelfCheckInModule' - Go to the previous URL => SUCCESS: You are required to login - Login with a user WITHOUT self_checkout permissions => SUCCESS: You are not allowed to log into the Self check-in module. - Login with a user WITH self_checkour permissions => SUCCESS: You gain access, and are presented the UI - Go through the several options => SUCCESS: All works as it should - Click the 'Help' link => SUCCESS: A help text is displayed on a modal - Sign off :-D - Bonus points: $ kshell k$ qa -c 2 -v 2 => SUCCESS: All tests green [1] Adjust to your dev's OPAC setup Signed-off-by: David Bourgault <david.bourgault(a)inlibro.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '18

25 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72053|0 |1 is obsolete| | Attachment #72054|0 |1 is obsolete| | Attachment #72055|0 |1 is obsolete| | Attachment #72056|0 |1 is obsolete| | Attachment #72057|0 |1 is obsolete| | Attachment #72058|0 |1 is obsolete| | Attachment #72059|0 |1 is obsolete| | Attachment #72060|0 |1 is obsolete| | --- Comment #34 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72176&action=ed… Bug 15492: Add the SelfCheckInModule syspref Signed-off-by: David Bourgault <david.bourgault(a)inlibro.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '18

25 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '18

25 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #119 from Josef Moravec <josef.moravec(a)gmail.com> --- Sorry, still some issues found with this: 1) Please undo the changes of spaces to tabs in reports-home.tt - there is no reason to touch these lines and tab char is forbidden 2) Move javascript to the end of page - see JS12 rule: https://wiki.koha-community.org/wiki/Coding_Guidelines#JS12:_Include_javasc… 3) Please add _[% KOHA_VERSION %] to css path, see bug 12904 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer(a)inlibro.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 --- Comment #12 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 72170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72170&action=ed… Bug 12502: QA Follow-up 1) The method under C4 was deleted. There wasn't any reason for a method under Koha, in the end, because it's a simple update that requires no additional processing. If I had to do any legwork with the data before updating the Order fields, I would've written a wrapper. As it stands right now, the work can be done directly in the controller without polluting the Koha/Acquisition/Orders.pm class. 2) Added the ISBN field to csv_header, and added that value to lateorders-export I've also changed the string internaldate to internalnote, small typo fix. 3) Made adjustements client-side and server-side. In the browser, you can now see a small loading icon to inform the user that the 'Save note' button actually triggered an action. A new alert message also informs the user if something awry happened while updating the orders' notes. I took a look at the user page, to see how notes were saved, but I was not satisfied with the idea of mixing an Ajax call with a window.location.reload; doesn't make sense in my mind to uselessly reload the page if the information had already reached the server, and since it was already coded that way, I felt like this change was the best course of action. Server-side, it is now possible to save an empty field. Before this patch, 'if($note)' would actually fail on an empty string, which meant you could never erase a note, for any reason whatsoever. After testing this patch, if the width of the input is still something that you'd like to see changed, I'll have no problem reducing it a little, but you'll have to tell me how large is _too_ large :) 4) Order no. -> Order line 5) Added the new columns to the admin/visibility yaml 6) It would be possible to also display an ISSN, but I won't make this patch any large than it is for now. -- You are receiving this mail because: You are watching all bug changes.

1 0