February 2018 - Koha-bugs - lists.koha-community.org

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #61 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to paxed from comment #60) > (In reply to Jesse Weaver from comment #57) > > Created attachment 70974 [details] [review] [review] > > Bug 15395: Example usage of I18N Template::Toolkit plugin > > > > Moved this patch for example usage to teh end of patch set > > and resolved minor conflict while applyin > > Signed-off-by: Marc Véron <veron(a)veron.ch> > > I'm confused by this example. How does the msgid look like in the po-file? > > msgid "item" > msgid_plural "items" > > Like that? > > If so, then that's a bad example, as it's basically the same as concatenating > number + "item" > The number placeholder should be included in the translatable string, so the > msgid looks like this: > > msgid "one item" > msgid_plural "%s items" > > Because the translator can then actually make it sound natural in their own > language - perhaps the language needs an article before the number, or a > suffix to the number, both of which would be impossible to do with the > original example. The problem solved by this example is not the concatenation of the number and the "item/items" string, but the fact that it allows only two forms (one singular, one plural), which is ok for some languages, but not for all. But I agree that it can be improved. I will submit another patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Sally Healey <sally.healey(a)cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7494] Use partial barcode or callnumber as a fallback for the barcode search in checkout
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7494 --- Comment #20 from Magnus Enger <magnus(a)libriotech.no> --- (In reply to Ravi Thakur from comment #19) > Comment on attachment 18981 [details] [review] > bug 7494: optional checkout-time fallback search for a book > > sir, can u tell me where to make these changes? This development was made a part of Koha in July 2013, so if you have a version of Koha that is more recent than that, yo ushould already have this functionality in place. Look for itemBarcodeFallbackSearch among the system preferences. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7494] Use partial barcode or callnumber as a fallback for the barcode search in checkout
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7494 Ravi Thakur <ravithakur.rt08(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ravithakur.rt08(a)gmail.com --- Comment #19 from Ravi Thakur <ravithakur.rt08(a)gmail.com> --- Comment on attachment 18981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18981 bug 7494: optional checkout-time fallback search for a book sir, can u tell me where to make these changes? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19443] New: Error while attempting to duplicate a patron
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19443 Bug ID: 19443 Summary: Error while attempting to duplicate a patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: alex.arnaud(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com HTML in the patron creating/editing form is not correct. If you create a patron and Koha detect a duplicate one, the new page loaded contains a new form at the top with a button inside: "Not a duplicate. Save as new record" This form is not closed (</form>) and in some situations this could be problematic. Try this test plan: - Edit the syspref IntranetUserJS and type the following code: "$(document).ready(function() { $("#memberentry_library_management").insertBefore("#memberentry_identity"); });" This code move the "Library management" part (cardnumber, Library, Category etc...) on the top of the page. - create a patron so that Koha will warn you about a duplicate one, - click on "Not a duplicate. Save as new record", - you should get error(s) about empty field(s). Note that now, the library management part's fields are empty or reset to default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #23 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 71931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71931&action=ed… Bug 9701: (follow-up) Adjust tests Test plan: prove t/db_dependent/Biblio.t should be green -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #22 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 71930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71930&action=ed… Bug 9701: (QA follow-up) Fix indentation and some strings - Fixes tabs pointed out by the QA script. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53403|0 |1 is obsolete| | Attachment #53404|0 |1 is obsolete| | --- Comment #21 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 71929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71929&action=ed… Bug 9701: Configure default indicator This patch adds the possibility to define default indicators in the MARC frameworks. It adds 2 columns in the marc_tag_structure table in the database in order to accomplish this. All files that reference this table have also been updated to reflect these added fields. Test: Add or edit a MARC framework. In the Field list should be 2 extra columns. It should be possible to add default indicators (1 character) in these fields. Nothing else should have changed in the meantime. The default indicator values are not yet visible in the cataloguing module. The default values are also loaded in the cataloguing form. Test: Define default values in some MARC framework. Go to cataloguing and create a new record using this framework. Verify that the defined defaults are visible when set. Verify the default is empty (as before) if no default was set. Verify that if the default is changed, the record is saved with the manually changed value. Verify that upon changing such a new record, the manually set indicator value is used and not the default one from the framework. Don't forget to run database and database schema update Signed-off-by: Eugene Jose Espinoza <eugenegf(a)yahoo.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19905] New: Don't append wildcard to query terms
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 Bug ID: 19905 Summary: Don't append wildcard to query terms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com Discovered this issue while testing the search links in biblio-details. The links are hard-coded in the template with queries not using quotes for field values, which makes QueryBuilder::_truncate_terms append '*' to the search term. Since wild card searches skips the analyzer-phase, most of our links does not work (since a lot of field values has word boundaries and/or punctuation marks, for example the query "Provider:Taschen," will be converted to "Provider:Taschen,*" and since the indexed value for Provider is "Taschen" this search will produce no results. In my opinion (if I'm not misunderstanding the purpose of this code) appending '*' to words should be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 9